default settings

[sirainen]

• STRING and STRING_NOVAR, URL, FILE setting types should show <empty> as the default, unless overridden
• NAMED_FILTER and NAMED_LIST_FILTER have no defaults, so they shouldn't show default
• STRLIST and BOOLLIST - not sure, don't show or be <empty list>?
• All other settings should error out if default is missing

[cmouse]

is this still relevant?

[sirainen]

yep, nothing has changed.

[slusarz]

• STRING and STRING_NOVAR, URL, FILE setting types should show <empty> as the default, unless overridden
  • These all correctly show "[None]" if not set. Why would "<empty>" be any different than "[None]"?
• NAMED_FILTER and NAMED_LIST_FILTER have no defaults, so they shouldn't show default
  • These both show "[None]" as default if not set. That's correct behavior for me. (We can't hide the default box for these settings if that's what you are asking, because they DO have a default - no setting)
• STRLIST and BOOLLIST - not sure, don't show or be ?
  • These all show "[None]" as well. As mentioned above, "no default" is the same thing as telling the user there is no default. We should not be hiding the "Default" entry if there isn't one, because telling the user there is no default is the default.
• All other settings should error out if default is missing
  • I can try to add something here

[sirainen]

These all correctly show "[None]" if not set. Why would "<empty>" be any different than "[None]"?

Earlier versions of settings.js had explicit "<empty>" default values. Looks like these are gone, so maybe that's fine.

These both show "[None]" as default if not set. That's correct behavior for me. (We can't hide the default box for these settings if that's what you are asking, because they DO have a default - no setting)

These are filters. They have no value .. So yeah, I was thinking of hiding the default, because there is no such concept as a value/default for them.

Update: Or I suppose named list filters could have defaults. Like if we had a default "inbox" namespace. So maybe [None] could kind of make sense there. For named (non-list) filters there's no value at all though.

[slusarz]

I added default checking for various types as outlined above, although with some additional exceptions (UINT can default to 0 because that's used all over the place; same with BOOLEAN and 'no'; IPADDR doesn't make sense to have default listed either, as empty is perfectly acceptable, e.g. trusted networks).

[slusarz]

Added ability to hide default display per settings type.