From 4563ae9d499163d666fc91bfc86f36258a49dbd3 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Tue, 24 Mar 2026 21:09:30 +1100 Subject: [PATCH 1/4] [#2399] Added Behat attribute set to Rector configuration. --- rector.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rector.php b/rector.php index 53e1ebb46..503b8ce5e 100644 --- a/rector.php +++ b/rector.php @@ -82,6 +82,8 @@ // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) + // Behat attribute sets - converts annotations to PHP 8 attributes. + ->withAttributesSets(behat: TRUE) // Code quality improvement sets. ->withPreparedSets( codeQuality: TRUE, From 4447b4bf5998515c201b88bfab9538adedc48c86 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Tue, 24 Mar 2026 21:09:42 +1100 Subject: [PATCH 2/4] Updated snapshots. --- .../Fixtures/handler_process/_baseline/rector.php | 2 ++ .../tools_groups_no_be_tests/rector.php | 10 +++++++++- .../tools_groups_no_be_tests_circleci/rector.php | 10 +++++++++- .../Fixtures/handler_process/tools_no_behat/rector.php | 8 ++++++++ .../handler_process/tools_no_behat_circleci/rector.php | 8 ++++++++ .../handler_process/tools_no_phpunit/rector.php | 2 +- .../tools_no_phpunit_circleci/rector.php | 2 +- 7 files changed, 38 insertions(+), 4 deletions(-) create mode 100644 .vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php create mode 100644 .vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php diff --git a/.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.php b/.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.php index 53e1ebb46..503b8ce5e 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/_baseline/rector.php @@ -82,6 +82,8 @@ // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) + // Behat attribute sets - converts annotations to PHP 8 attributes. + ->withAttributesSets(behat: TRUE) // Code quality improvement sets. ->withPreparedSets( codeQuality: TRUE, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php index 6d8e0f6d3..542b89126 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php @@ -6,7 +6,15 @@ use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector; use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; -@@ -99,7 +98,6 @@ +@@ -83,7 +82,6 @@ + // Includes all rules from PHP 5.3 through 8.4. + ->withPhpSets(php84: TRUE) + // Behat attribute sets - converts annotations to PHP 8 attributes. +- ->withAttributesSets(behat: TRUE) + // Code quality improvement sets. + ->withPreparedSets( + codeQuality: TRUE, +@@ -101,7 +99,6 @@ // Additional rules. ->withRules([ DeclareStrictTypesRector::class, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php index 6d8e0f6d3..542b89126 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php @@ -6,7 +6,15 @@ use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector; use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; -@@ -99,7 +98,6 @@ +@@ -83,7 +82,6 @@ + // Includes all rules from PHP 5.3 through 8.4. + ->withPhpSets(php84: TRUE) + // Behat attribute sets - converts annotations to PHP 8 attributes. +- ->withAttributesSets(behat: TRUE) + // Code quality improvement sets. + ->withPreparedSets( + codeQuality: TRUE, +@@ -101,7 +99,6 @@ // Additional rules. ->withRules([ DeclareStrictTypesRector::class, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php new file mode 100644 index 000000000..0a1ff6fd5 --- /dev/null +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php @@ -0,0 +1,8 @@ +@@ -83,7 +83,6 @@ + // Includes all rules from PHP 5.3 through 8.4. + ->withPhpSets(php84: TRUE) + // Behat attribute sets - converts annotations to PHP 8 attributes. +- ->withAttributesSets(behat: TRUE) + // Code quality improvement sets. + ->withPreparedSets( + codeQuality: TRUE, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php new file mode 100644 index 000000000..0a1ff6fd5 --- /dev/null +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php @@ -0,0 +1,8 @@ +@@ -83,7 +83,6 @@ + // Includes all rules from PHP 5.3 through 8.4. + ->withPhpSets(php84: TRUE) + // Behat attribute sets - converts annotations to PHP 8 attributes. +- ->withAttributesSets(behat: TRUE) + // Code quality improvement sets. + ->withPreparedSets( + codeQuality: TRUE, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/rector.php index 6d8e0f6d3..a8a54b7f9 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit/rector.php @@ -6,7 +6,7 @@ use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector; use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; -@@ -99,7 +98,6 @@ +@@ -101,7 +100,6 @@ // Additional rules. ->withRules([ DeclareStrictTypesRector::class, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/rector.php index 6d8e0f6d3..a8a54b7f9 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/rector.php @@ -6,7 +6,7 @@ use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector; use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; -@@ -99,7 +98,6 @@ +@@ -101,7 +100,6 @@ // Additional rules. ->withRules([ DeclareStrictTypesRector::class, From 695791c0f6fc6c7e7fd4be96a3beb41d96415a07 Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Tue, 24 Mar 2026 21:57:14 +1100 Subject: [PATCH 3/4] [#2399] Added code fence markers around Behat attribute set in Rector configuration. --- rector.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rector.php b/rector.php index 503b8ce5e..31af310ff 100644 --- a/rector.php +++ b/rector.php @@ -82,8 +82,10 @@ // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) + #;< TOOL_BEHAT // Behat attribute sets - converts annotations to PHP 8 attributes. ->withAttributesSets(behat: TRUE) + #;> TOOL_BEHAT // Code quality improvement sets. ->withPreparedSets( codeQuality: TRUE, From 349a4d25c5cc1245d8ab4df6d8fba62618bd38ff Mon Sep 17 00:00:00 2001 From: Alex Skrypnyk Date: Tue, 24 Mar 2026 21:59:23 +1100 Subject: [PATCH 4/4] Updated snapshots. --- .../handler_process/tools_groups_no_be_tests/rector.php | 7 ++++--- .../tools_groups_no_be_tests_circleci/rector.php | 7 ++++--- .../Fixtures/handler_process/tools_no_behat/rector.php | 5 +++-- .../handler_process/tools_no_behat_circleci/rector.php | 5 +++-- 4 files changed, 14 insertions(+), 10 deletions(-) diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php index 542b89126..6884d9fc1 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/rector.php @@ -6,15 +6,16 @@ use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector; use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; -@@ -83,7 +82,6 @@ +@@ -82,8 +81,6 @@ + // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) - // Behat attribute sets - converts annotations to PHP 8 attributes. +- // Behat attribute sets - converts annotations to PHP 8 attributes. - ->withAttributesSets(behat: TRUE) // Code quality improvement sets. ->withPreparedSets( codeQuality: TRUE, -@@ -101,7 +99,6 @@ +@@ -101,7 +98,6 @@ // Additional rules. ->withRules([ DeclareStrictTypesRector::class, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php index 542b89126..6884d9fc1 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/rector.php @@ -6,15 +6,16 @@ use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector; use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; -@@ -83,7 +82,6 @@ +@@ -82,8 +81,6 @@ + // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) - // Behat attribute sets - converts annotations to PHP 8 attributes. +- // Behat attribute sets - converts annotations to PHP 8 attributes. - ->withAttributesSets(behat: TRUE) // Code quality improvement sets. ->withPreparedSets( codeQuality: TRUE, -@@ -101,7 +99,6 @@ +@@ -101,7 +98,6 @@ // Additional rules. ->withRules([ DeclareStrictTypesRector::class, diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php index 0a1ff6fd5..b7723e06f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat/rector.php @@ -1,7 +1,8 @@ -@@ -83,7 +83,6 @@ +@@ -82,8 +82,6 @@ + // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) - // Behat attribute sets - converts annotations to PHP 8 attributes. +- // Behat attribute sets - converts annotations to PHP 8 attributes. - ->withAttributesSets(behat: TRUE) // Code quality improvement sets. ->withPreparedSets( diff --git a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php index 0a1ff6fd5..b7723e06f 100644 --- a/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php +++ b/.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/rector.php @@ -1,7 +1,8 @@ -@@ -83,7 +83,6 @@ +@@ -82,8 +82,6 @@ + // PHP version upgrade sets - modernizes syntax to PHP 8.4. // Includes all rules from PHP 5.3 through 8.4. ->withPhpSets(php84: TRUE) - // Behat attribute sets - converts annotations to PHP 8 attributes. +- // Behat attribute sets - converts annotations to PHP 8 attributes. - ->withAttributesSets(behat: TRUE) // Code quality improvement sets. ->withPreparedSets(