FindReplaceOverlay has wrong background in texteditor inside SharedHeaderFormEditor multi-page editor

[tomaswolf]

The Find/Replace Overlay shows up with gray background in light mode (or without themeing) inside the EGit Diff viewer:

Occurs at least on Windows and Mac OS; didn't test on Linux.

Eclipse versions: 2026-03, 2025-12 (didn't check older versions)
OS: Mac OS 13.7.7 and Windows 11

To reproduce:

1. Open the Git History view.
2. Select a commit.
3. Choose "Open in Commit Viewer" from the context menu.
4. In the opened viewer (opens in the editor area; it's actually a read-only editor), select the "Diff" tab.
5. Set the focus to the opened text editor and type Cmd/Ctrl-F.

In other editors, including read-only text editors like the "Effective POM" tab when opening a maven pom.xml, the toolbar shows with normal white background:

See also: eclipse-egit/egit#157

Findings so far:

• In dark mode all looks normal.
• Doesn't seem to be a CSS issue as it occurs also when themeing is disabled.
• EGit's CommitEditor is a SharedHeaderFormEditor.

[fedejeanne]

cc @HeikoKlare

[HeikoKlare]

I remember that we had issues with inconsistent colors already, but I do not find an according GH issue anymore.
There is a branch lying around in my fork in which I tried some fixing of inconsistent colors: https://github.com/HeikoKlare/eclipse.platform.ui/tree/findreplaceoverlay-colors
Not sure if that state was in any way usable, but it may serve as a starting point if anyone wants to work on this issue.

I've added this to the find/replace umbrella issue for the sake of visibility: #2021