Registry exception in property tester init prevents proper startup

[eric-milles]

• I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

From a fresh installation and clean workspace:

• install from this spec: https://github.com/user-attachments/files/26249857/eclipse-windows-setup.txt
• open maven project
• open java source
• restart eclipse

see groovy/groovy-eclipse#1660

When groovy bundles are refreshed to select a specific one, a property tester is part of that refresh. The next request to org.eclipse.core.internal.expressions.TypeExtensionManager#loadTesters fails with org.eclipse.core.runtime.InvalidRegistryObjectException.

The tester loader loop already catches CoreException and substitutes a null tester plus logs. I think this loop could also catch InvalidRegistryObjectException.

eclipse.platform/runtime/bundles/org.eclipse.core.expressions/src/org/eclipse/core/internal/expressions/TypeExtensionManager.java

Line 193 in d049690

result[i]= new PropertyTesterDescriptor(config);

			IPropertyTester[] result= new IPropertyTester[typeConfigs.size()];
			for (int i= 0; i < result.length; i++) {
				IConfigurationElement config= typeConfigs.get(i);
				try {
					result[i]= new PropertyTesterDescriptor(config);
				} catch (CoreException e) {
					ILog.of(TypeExtensionManager.class).log(e.getStatus());
					result[i]= NULL_PROPERTY_TESTER;
				} catch (InvalidRegistryObjectException e) { // NEW
					ILog.of(TypeExtensionManager.class).log(...);
					result[i]= NULL_PROPERTY_TESTER;
				}
			}

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[eric-milles]

PropertyTesterDescriptor constructor could catch InvalidRegistryObjectException and rethrow as CoreException with proper status.

[iloveeclipse]

From a fresh installation and clean workspace:

• install from this spec: https://github.com/user-attachments/files/26249857/eclipse-windows-setup.txt
• open maven project
• open java source
• restart eclipse

Could you please attach the full error log for that scenario, ideally based on latest Eclipse release?

[eric-milles]

This is an example of what I am seeing:

org.eclipse.core.runtime.InvalidRegistryObjectException: Invalid registry object
	at org.eclipse.core.internal.registry.RegistryObjectManager.basicGetObject(RegistryObjectManager.java:308)
	at org.eclipse.core.internal.registry.RegistryObjectManager.getObject(RegistryObjectManager.java:296)
	at org.eclipse.core.internal.registry.ConfigurationElementHandle.getConfigurationElement(ConfigurationElementHandle.java:29)
	at org.eclipse.core.internal.registry.ConfigurationElementHandle.getAttribute(ConfigurationElementHandle.java:38)
	at org.eclipse.core.internal.expressions.PropertyTesterDescriptor.<init>(PropertyTesterDescriptor.java:39)
	at org.eclipse.core.internal.expressions.TypeExtensionManager.loadTesters(TypeExtensionManager.java:193)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:79)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:151)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:151)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:151)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:151)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:133)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:133)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:133)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:133)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:133)
	at org.eclipse.core.internal.expressions.TypeExtension.findTypeExtender(TypeExtension.java:133)
	at org.eclipse.core.internal.expressions.TypeExtensionManager.getProperty(TypeExtensionManager.java:125)
	at org.eclipse.core.expressions.TestExpression.evaluate(TestExpression.java:105)
	at org.eclipse.core.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:57)
	at org.eclipse.core.expressions.WithExpression.evaluate(WithExpression.java:84)
	at org.eclipse.ui.internal.services.EvaluationReference.evaluate(EvaluationReference.java:76)
	at org.eclipse.ui.internal.services.EvaluationReference.evaluate(EvaluationReference.java:106)
	at org.eclipse.ui.internal.services.EvaluationReference.changed(EvaluationReference.java:100)
	at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:109)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:371)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:387)
	at org.eclipse.ui.internal.services.EvaluationService$1.changed(EvaluationService.java:78)
	at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:109)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:371)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:387)
	at org.eclipse.e4.core.commands.ExpressionContext.addVariable(ExpressionContext.java:87)
	at org.eclipse.ui.internal.services.EvaluationService.changeVariable(EvaluationService.java:143)
	at org.eclipse.ui.internal.services.EvaluationService$3.sourceChanged(EvaluationService.java:123)
	at org.eclipse.ui.AbstractSourceProvider.fireSourceChanged(AbstractSourceProvider.java:84)
	at org.eclipse.ui.internal.services.WorkbenchSourceProvider.checkActivePart(WorkbenchSourceProvider.java:382)
	at org.eclipse.ui.internal.services.WorkbenchSourceProvider.checkActivePart(WorkbenchSourceProvider.java:278)
	at org.eclipse.ui.internal.services.WorkbenchSourceProvider.handleCheck(WorkbenchSourceProvider.java:267)
	at org.eclipse.ui.internal.services.WorkbenchSourceProvider.checkOtherSources(WorkbenchSourceProvider.java:769)
	at org.eclipse.ui.internal.services.WorkbenchSourceProvider.lambda$2(WorkbenchSourceProvider.java:755)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:91)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1342)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1216)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1241)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1226)
	at org.eclipse.swt.widgets.Decorations.WM_ACTIVATE(Decorations.java:1540)
	at org.eclipse.swt.widgets.Shell.WM_ACTIVATE(Shell.java:2422)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4856)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:336)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1499)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2395)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5132)
	at org.eclipse.swt.internal.win32.OS.BringWindowToTop(Native Method)
	at org.eclipse.swt.widgets.Decorations.bringToTop(Decorations.java:210)
	at org.eclipse.swt.widgets.Shell.open(Shell.java:1301)
	at org.eclipse.e4.ui.workbench.renderers.swt.WBWRenderer.postProcess(WBWRenderer.java:731)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:676)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:762)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$2.run(PartRenderingEngine.java:726)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:710)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1075)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1038)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:677)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:185)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:615)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:563)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1415)

There is a different trace in the linked issue.

[eric-milles]

I do see this event handler being called. Not sure at the moment if it is a timing issue, because getProperty (synchronized) is called from another thread.

eclipse.platform/runtime/bundles/org.eclipse.core.expressions/src/org/eclipse/core/internal/expressions/TypeExtensionManager.java

Line 205 in d049690

public void registryChanged(IRegistryChangeEvent event) {

[eric-milles]

It seems that when a source editor is left open, the main thread is handling a lot of part rendering before the Registry event dispatcher thread gets a chance to notify of registry deltas.

[eric-milles]

If I force EquinoxRegistryStrategy not to use jobs, the updates come sooner and the property tester errors subside. I don't know too much about this; is there a way to detect if the JobManager is available or ready during early startup?

https://github.com/eclipse-equinox/equinox/blob/bf9df0eb2d1c561156f34abacd52326574fddb80/bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/osgi/EquinoxRegistryStrategy.java#L95

[harrisric]

Probably also relates to report eclipse-platform/eclipse.platform.ui#2889