tp::install uses deprecated options_hash/settings_hash

[zajdee]

Hi,
thank you for your work on puppet-tp.

It seems that even the latest install.pp calls tp::conf with settings_hash and options_hash on multiple places, for example:

puppet-tp/manifests/install.pp

Lines 431 to 437 in 89524ae

	# Additional confs and dirs
	$conf_defaults = {
	'ensure' => tp::ensure2file($ensure),
	'settings_hash' => $settings,
	'options_hash' => $all_options,
	'data_module' => $data_module,
	}

However these two functions are now deprecated:

puppet-tp/manifests/conf.pp

Lines 258 to 263 in 89524ae

	if $settings_hash != {} {
	deprecation('settings_hash', 'Replace with my_settings')
	}
	if $options_hash != {} {
	deprecation('options_hash', 'Replace with my_options')
	}

The call to deprecation() causes Puppet to fail when in strict mode.

[alvagante]

@zajdee Thanks for the notice, can you give a look at the above MR to confirm if it fixes your issues?