ChrisTimms-JordanLyn_Project1 - code review

[ChibsDev]

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]

User stories

• See information about each member of your team so that I can know who you are

• Browse your website on mobile, tablet, and desktop devices

• Click to navigate to different sections of your webpage

• Contact you to enquire about working with you

• Visit your website at a publicly accessible domain name

additionally

• Navigate your website using keyboard controls

• Hear my screen reader describe the content on your website

Learning outcomes

Accessibility

• Structure a site using semantic HTML to aid accessibility

• Ensure a web page is readable for screen readers

• Ensure our UI has sufficient colour contrast so that everyone can perceive it comfortably

• Use various tools to check that our website meets accessibility criteria

Design

• Use CSS media queries to ensure our content is always presented effectively on screens of different sizes

• Demonstrate a mobile-first approach to building a website

• Use CSS variables to apply repeated colours to HTML elements

• Use CSS Flexbox to style children in a single-direction layout (ie a row or a column)

• Use CSS Grid to style children in two-direction layout

Workflow

• Ensure our Git commit history tells a coherent story

HTML Forms

• Use the appropriate input types in HTML forms for gathering different types of information

UI bugs

[Can you see any obvious bugs or areas to improve?]

Instructions

[Does everything work as expected or were there missing instructions?]

File structure

[When you open the project in your editor, does the file structure make sense?]

Flow of control

[ Can you you follow the different paths the code might take?]

Naming

[Do variables and functions have clear and descriptive names?]

Readability

Index.html is very comprehensive and understandable.

[ChibsDev]

Havent seen everything but from what I see this project is pretty much done. Most if not all of the user stories seem to be fulfilled, the website is clear, i was able to navigate through the site using the 'tab' button. Looking forward to diving deeper into this project more !