From 906d43bbda565c8fe0fc6a553aa20beb445844cb Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Fri, 20 Mar 2026 03:33:48 -0700 Subject: [PATCH] Remove obsolete workflows Summary: Changelog: [Internal] Removes obsolete workflows which were testing Hermes V1 integration. Since Hermes V1 is the default now, those are no longer needed. Differential Revision: D97464853 --- .github/workflows/test-hermes-v1-android.yml | 70 ------------------ .github/workflows/test-hermes-v1-ios.yml | 76 -------------------- .github/workflows/test-hermes-v1.yml | 39 ---------- 3 files changed, 185 deletions(-) delete mode 100644 .github/workflows/test-hermes-v1-android.yml delete mode 100644 .github/workflows/test-hermes-v1-ios.yml delete mode 100644 .github/workflows/test-hermes-v1.yml diff --git a/.github/workflows/test-hermes-v1-android.yml b/.github/workflows/test-hermes-v1-android.yml deleted file mode 100644 index 1c7b7eedf12b..000000000000 --- a/.github/workflows/test-hermes-v1-android.yml +++ /dev/null @@ -1,70 +0,0 @@ -name: Test Hermes V1 with nightly on Android - -on: - workflow_call: - inputs: - retry-count: - description: 'Number of times to retry the build on failure' - required: false - type: number - default: 3 - -jobs: - test-hermes-v1-android: - name: Test Hermes V1 on Android - runs-on: 4-core-ubuntu - strategy: - matrix: - flavor: [debug, release] - steps: - - name: Checkout - uses: actions/checkout@v6 - - - name: Setup node.js - uses: actions/setup-node@v6 - with: - node-version: '22.14.0' - cache: yarn - - - name: Set up JDK 17 - uses: actions/setup-java@v5 - with: - java-version: '17' - distribution: 'zulu' - - - name: Prepare the app with Hermes V1 - uses: ./.github/actions/prepare-hermes-v1-app - with: - retry-count: ${{ inputs.retry-count }} - - - name: Build Android with retry - uses: nick-fields/retry@v3 - env: - CMAKE_VERSION: 3.31.5 - ORG_GRADLE_PROJECT_reactNativeArchitectures: x86_64 - with: - timeout_minutes: 45 - max_attempts: ${{ inputs.retry-count }} - retry_wait_seconds: 30 - shell: bash - command: | - cd /tmp/RNApp/android - CAPITALIZED_FLAVOR=$(echo "${{ matrix.flavor }}" | awk '{print toupper(substr($0, 1, 1)) substr($0, 2)}') - ./gradlew assemble${CAPITALIZED_FLAVOR} -PhermesV1Enabled=true - on_retry_command: | - echo "Cleaning up for Android retry..." - cd /tmp/RNApp/android - ./gradlew clean || true - rm -rf build app/build .gradle || true - - - name: Run E2E Tests - uses: ./.github/actions/maestro-android - timeout-minutes: 60 - with: - app-path: /tmp/RNApp/android/app/build/outputs/apk/${{ matrix.flavor }}/app-${{ matrix.flavor }}.apk - app-id: com.rnapp - maestro-flow: ./scripts/e2e/.maestro/ - install-java: 'false' - flavor: ${{ matrix.flavor }} - working-directory: /tmp/RNApp - emulator-arch: x86_64 diff --git a/.github/workflows/test-hermes-v1-ios.yml b/.github/workflows/test-hermes-v1-ios.yml deleted file mode 100644 index bdafd9181b81..000000000000 --- a/.github/workflows/test-hermes-v1-ios.yml +++ /dev/null @@ -1,76 +0,0 @@ -name: Test Hermes V1 with nightly on iOS - -on: - workflow_call: - inputs: - retry-count: - description: 'Number of times to retry the build on failure' - required: false - type: number - default: 3 - -jobs: - test-hermes-v1-ios: - name: Test Hermes V1 on iOS - runs-on: macos-15-large - strategy: - matrix: - flavor: [debug, release] - steps: - - name: Checkout - uses: actions/checkout@v6 - - - name: Setup node.js - uses: actions/setup-node@v6 - with: - node-version: '22.14.0' - cache: yarn - - - name: Prepare capitalized flavor - id: prepare-flavor - shell: bash - run: | - CAPITALIZED_FLAVOR=$(echo "${{ matrix.flavor }}" | awk '{print toupper(substr($0, 1, 1)) substr($0, 2)}') - echo "capitalized_flavor=$CAPITALIZED_FLAVOR" >> $GITHUB_OUTPUT - - - name: Prepare the app with Hermes V1 - uses: ./.github/actions/prepare-hermes-v1-app - with: - retry-count: ${{ inputs.retry-count }} - - - name: Setup xcode - uses: maxim-lobanov/setup-xcode@v1 - - - name: Build iOS with retry - uses: nick-fields/retry@v3 - with: - timeout_minutes: 45 - max_attempts: ${{ inputs.retry-count }} - retry_wait_seconds: 30 - shell: bash - command: | - cd /tmp/RNApp/ios - bundle install - RCT_HERMES_V1_ENABLED=1 bundle exec pod install - xcodebuild build \ - -workspace "RNApp.xcworkspace" \ - -scheme "RNApp" \ - -configuration "${{ steps.prepare-flavor.outputs.capitalized_flavor }}" \ - -sdk "iphonesimulator" \ - -destination "generic/platform=iOS Simulator" \ - -derivedDataPath "/tmp/RNApp" \ - -quiet - on_retry_command: | - echo "Cleaning up for iOS retry..." - cd /tmp/RNApp/ios - rm -rf Pods Podfile.lock build - rm -rf ~/Library/Developer/Xcode/DerivedData/* || true - - - name: Run E2E Tests - uses: ./.github/actions/maestro-ios - with: - app-path: "/tmp/RNApp/Build/Products/${{ steps.prepare-flavor.outputs.capitalized_flavor }}-iphonesimulator/RNApp.app" - app-id: org.reactjs.native.example.RNApp - maestro-flow: ./scripts/e2e/.maestro/ - flavor: ${{ steps.prepare-flavor.outputs.capitalized_flavor }} - working-directory: /tmp/RNApp diff --git a/.github/workflows/test-hermes-v1.yml b/.github/workflows/test-hermes-v1.yml deleted file mode 100644 index d11e444e5ff6..000000000000 --- a/.github/workflows/test-hermes-v1.yml +++ /dev/null @@ -1,39 +0,0 @@ -# This jobs runs every day 2 hours after the nightly job for React Native so we can verify how the nightly is behaving. -name: Check Hermes V1 with the nightly build - -on: - workflow_dispatch: - # nightly build @ 4:15 AM UTC - schedule: - - cron: '15 4 * * *' - -concurrency: - group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.ref }} - cancel-in-progress: true - -jobs: - check-nightly: - runs-on: ubuntu-latest - if: github.repository == 'facebook/react-native' - steps: - - name: Checkout - uses: actions/checkout@v6 - - name: Check nightly - run: | - TODAY=$(date "+%Y%m%d") - echo "Checking nightly for $TODAY" - NIGHTLY="$(npm view react-native | grep $TODAY)" - if [[ -z $NIGHTLY ]]; then - echo 'Nightly job failed.' - exit 1 - else - echo 'Nightly Worked, All Good!' - fi - - test-hermes-v1-ios: - uses: ./.github/workflows/test-hermes-v1-ios.yml - needs: check-nightly - - test-hermes-v1-android: - uses: ./.github/workflows/test-hermes-v1-android.yml - needs: check-nightly