Skip to content

Commit 70a2bfb

Browse files
committed
PR feedback
1 parent a480977 commit 70a2bfb

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/functions/iac/export.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const STANDARD_TF_VARS: tf.Block[] = [
4545
labels: ["extension_id"],
4646
attributes: {
4747
description:
48-
"The extension ID. Used for reverse compatibility when extensions ahve been ported. Injects an env var and adds a function name prefix",
48+
"The extension ID. Used for reverse compatibility when extensions have been ported. Injects an env var and adds a function name prefix",
4949
default: null,
5050
},
5151
},

src/gcp/cloudfunctions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ export function functionTerraform(
878878
event_type: endpoint.eventTrigger.eventType,
879879
// V1 always uses "resource" as its event filter and it is always required.
880880
resource: endpoint.eventTrigger.eventFilters!.resource!,
881-
// failure_policy: (endpoint.eventTrigger.retry ? { retry: {} } : undefined) as unknown as tf.Value
881+
// TODO: Failure policy
882882
};
883883
} else if (build.isScheduleTriggered(endpoint)) {
884884
throw new FirebaseError("Scheduled functions are not supported in terraform yet", { exit: 1 });

0 commit comments

Comments
 (0)