ENH: remove superfluous Lobe::rasterize_perimeter

We did not use the old overload anymore, so there is no reason to keep
it. Plus, it makes writing the python bindings a tiny bit more awkward.

Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>

Author: MSallermann

flowy/include/lobe.hpp

@@ -187,19 +187,6 @@ class Lobe
         return coord + center;
     }
 
-    inline std::vector<Vector2> rasterize_perimeter( int n_raster_points ) const
-    {
-        VectorX phi_list = xt::linspace<double>( 0.0, 2.0 * Math::pi, n_raster_points, false );
-        auto res         = std::vector<Vector2>( n_raster_points );
-
-        for( int idx_phi = 0; idx_phi < n_raster_points; idx_phi++ )
-        {
-            res[idx_phi] = point_at_angle( phi_list[idx_phi] );
-        }
-
-        return res;
-    }
-
     inline std::vector<Vector2> rasterize_perimeter( std::span<double> sin_phi, std::span<double> cos_phi ) const
     {
         const int n_raster_points = sin_phi.size();

src/topography.cpp

@@ -516,11 +516,8 @@ Vector2 Topography::find_preliminary_budding_point( const Lobe & lobe, size_t np
     // First, we rasterize the perimeter of the ellipse
     const auto sin = std::span<double>( sin_phi_lobe_perimeter->begin(), sin_phi_lobe_perimeter->end() );
     const auto cos = std::span<double>( cos_phi_lobe_perimeter->begin(), cos_phi_lobe_perimeter->end() );
-
     std::vector<Vector2> perimeter = lobe.rasterize_perimeter( sin, cos );
 
-    // std::vector<Vector2> perimeter = lobe.rasterize_perimeter( npoints );
-
     // Then, we find the point of minimal elevation amongst the rasterized points on the perimeter
     auto min_elevation_point_it = std::min_element(
         perimeter.begin(), perimeter.end(), [&]( const Vector2 & p1, const Vector2 & p2 )

test/test_topography.cpp

@@ -140,13 +140,6 @@ TEST_CASE( "find_preliminary_budding_point", "[budding_point]" )
     my_lobe.semi_axes = { 0.8, 0.8 };
     my_lobe.set_azimuthal_angle( 0.0 );
 
-    auto perimeter = my_lobe.rasterize_perimeter( 32 );
-    for( auto & p : perimeter )
-    {
-        INFO( fmt::format( "p = {}\n", fmt::streamed( p ) ) );
-        INFO( fmt::format( "height = {}\n\n", topography.height_and_slope( p ).first ) );
-    }
-
     Flowy::Vector2 budding_point = topography.find_preliminary_budding_point( my_lobe, 32 );
 
     INFO( fmt::format( "budding_point  = {}", budding_point ) );