chore: remove SpotBugs

SpotBugs is not providing value. Remove the plugin, config, and
exclusion file. Convert the workaround in SerializeWorkflows to
use try-with-resources.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>

Author: honnix

flytekit-examples-scala/pom.xml

@@ -29,11 +29,6 @@
   <name>Flytekit Java Examples in Scala</name>
   <description>Examples of Tasks, Workflows and Launch plans written in Scala.</description>
 
-  <properties>
-    <!-- spotbugs doesn't understand Scala code -->
-    <spotbugs.skip>true</spotbugs.skip>
-  </properties>
-
   <dependencyManagement>
     <dependencies>
       <dependency>

flytekit-scala-tests/pom.xml

@@ -32,11 +32,6 @@
     macro expansion that can't be done
     in the same module.</description>
 
-  <properties>
-    <!-- spotbugs doesn't understand Scala code -->
-    <spotbugs.skip>true</spotbugs.skip>
-  </properties>
-
   <dependencyManagement>
     <dependencies>
       <dependency>

flytekit-scala_2.12/pom.xml

@@ -31,11 +31,6 @@
   <description>Classes used by developers to build Flyte's Tasks, Workflows and Launch plans in
     Scala 2.12.</description>
 
-  <properties>
-    <!-- spotbugs doesn't understand Scala code -->
-    <spotbugs.skip>true</spotbugs.skip>
-  </properties>
-
   <dependencyManagement>
     <dependencies>
       <dependency>

flytekit-scala_2.13/pom.xml

@@ -31,11 +31,6 @@
   <description>Classes used by developers to build Flyte's Tasks, Workflows and Launch plans in
     Scala 2.13.</description>
 
-  <properties>
-    <!-- spotbugs doesn't understand Scala code -->
-    <spotbugs.skip>true</spotbugs.skip>
-  </properties>
-
   <dependencyManagement>
     <dependencies>
       <dependency>

jflyte/src/main/java/org/flyte/jflyte/SerializeWorkflows.java

@@ -18,7 +18,6 @@
 
 import static org.flyte.jflyte.utils.TokenSourceFactoryLoader.getTokenSource;
 
-import com.google.errorprone.annotations.Var;
 import com.google.protobuf.ByteString;
 import java.io.File;
 import java.io.FileOutputStream;
@@ -102,23 +101,11 @@ public Integer call() {
 
   private static BiConsumer<String, ByteString> fileWriter(String folder) {
     return (filename, bytes) -> {
-      @Var FileOutputStream fos = null;
-
-      // ugly because spotbugs doesn't like try-with-resources
-      try {
-        fos = new FileOutputStream(new File(folder, filename));
+      try (FileOutputStream fos = new FileOutputStream(new File(folder, filename))) {
         bytes.writeTo(fos);
         fos.flush();
       } catch (IOException e) {
         throw new UncheckedIOException("failed to write to " + folder + "/" + filename, e);
-      } finally {
-        if (fos != null) {
-          try {
-            fos.close();
-          } catch (IOException e) {
-            // ignore, any significant error should happen during flush
-          }
-        }
       }
     };
   }

pom.xml

@@ -107,7 +107,6 @@
     <sl4j.version>1.7.36</sl4j.version>
     <!-- also remember to bump the version in flytekit-bom module -->
     <spotless.version>2.21.0</spotless.version>
-    <spotbugs.excludeFilterFile>spotbugs-exclude.xml</spotbugs.excludeFilterFile>
     <error_prone.version>2.27.0</error_prone.version>
     <junit.version>5.7.0</junit.version>
 
@@ -593,26 +592,6 @@
             </execution>
           </executions>
         </plugin>
-        <plugin>
-          <groupId>com.github.spotbugs</groupId>
-          <artifactId>spotbugs-maven-plugin</artifactId>
-          <version>4.2.3</version>
-          <configuration>
-            <includeTests>true</includeTests>
-            <effort>Max</effort>
-            <threshold>Low</threshold>
-            <failOnError>true</failOnError>
-            <xmlOutput>true</xmlOutput>
-          </configuration>
-          <executions>
-            <execution>
-              <goals>
-                <goal>check</goal>
-              </goals>
-              <phase>verify</phase>
-            </execution>
-          </executions>
-        </plugin>
         <plugin>
           <artifactId>maven-javadoc-plugin</artifactId>
           <version>3.3.1</version>
@@ -766,10 +745,6 @@
         <groupId>com.diffplug.spotless</groupId>
         <artifactId>spotless-maven-plugin</artifactId>
       </plugin>
-      <plugin>
-        <groupId>com.github.spotbugs</groupId>
-        <artifactId>spotbugs-maven-plugin</artifactId>
-      </plugin>
       <plugin>
         <groupId>org.apache.rat</groupId>
         <artifactId>apache-rat-plugin</artifactId>