From 7475ebcdb7d5ceeaceeb23a77bdc54666648cfa7 Mon Sep 17 00:00:00 2001
From: luigi <louis_liu@pesi.com.tw>
Date: Fri, 13 Feb 2026 12:07:39 +0800
Subject: [PATCH] Fix memory safety: allocate pos_helper on heap to avoid
 invalid free in CoreAttention

---
 src/layers.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/layers.h b/src/layers.h
index dedc91c..51603f8 100644
--- a/src/layers.h
+++ b/src/layers.h
@@ -1421,7 +1421,7 @@ namespace chatllm
               sinks(BlockParams::CoreAttentionUseSinks::get() > 0 ?
                     ggml::new_tensor_1d(ctx, ggml::type::GGML_TYPE_F32, BlockParams::CoreAttentionUseSinks::get())
                     : nullptr),
-              pos_helper(helper ? helper : &def_pos_helper)
+              pos_helper(helper ? helper : new BaseTensorPosHelper(max_length))
         {
             allocate_pos_tensor(ctx);
         }