fix(replay): Fix crash when root view has no window or is too small (#4805)

* fix(replay): Fix crash when root view has no window or is too small

* Changelog

* move the null check under if(added)

* revert

* revert

Author: romtsn

CHANGELOG.md

@@ -19,6 +19,8 @@
 - Avoid StrictMode warnings ([#4724](https://github.com/getsentry/sentry-java/pull/4724))
 - Use logger from options for JVM profiler ([#4771](https://github.com/getsentry/sentry-java/pull/4771))
 - Session Replay: Avoid deadlock when pausing replay if no connection ([#4788](https://github.com/getsentry/sentry-java/pull/4788))
+- Session Replay: Fix capturing roots with no windows ([#4805](https://github.com/getsentry/sentry-java/pull/4805))
+- Session Replay: Fix `java.lang.IllegalArgumentException: width and height must be > 0` ([#4805](https://github.com/getsentry/sentry-java/pull/4805))
 
 ### Miscellaneous
 

sentry-android-replay/src/main/java/io/sentry/android/replay/ScreenshotRecorder.kt

@@ -289,7 +289,7 @@ public data class ScreenshotRecorderConfig(
     private fun Int.adjustToBlockSize(): Int {
       val remainder = this % 16
       return if (remainder <= 8) {
-        this - remainder
+        maxOf(16, this - remainder)
       } else {
         this + (16 - remainder)
       }

sentry-android-replay/src/main/java/io/sentry/android/replay/WindowRecorder.kt

@@ -110,6 +110,11 @@ internal class WindowRecorder(
   override fun onRootViewsChanged(root: View, added: Boolean) {
     rootViewsLock.acquire().use {
       if (added) {
+        if (root.phoneWindow == null) {
+          options.logger.log(WARNING, "Root view does not have a phone window, skipping.")
+          return
+        }
+
         rootViews.add(WeakReference(root))
         capturer?.recorder?.bind(root)
         determineWindowSize(root)