Skip to content

Commit ad8abe7

Browse files
committed
Sync with 'master'
2 parents 66d5323 + b15384c commit ad8abe7

3 files changed

Lines changed: 20 additions & 9 deletions

File tree

Documentation/RelNotes/2.54.0.adoc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -509,6 +509,12 @@ Fixes since v2.53
509509
working tree, which was broken.
510510
(merge 339eba65a7 th/backfill-auto-detect-sparseness-fix later to maint).
511511

512+
* add_files_to_cache() used diff_files() to detect only the paths that
513+
are different between the index and the working tree and add them,
514+
which does not need rename detection, which interfered with unnecessary
515+
conflicts.
516+
(merge c0ce43376b ng/add-files-to-cache-wo-rename later to maint).
517+
512518
* Other code cleanup, docfix, build fix, etc.
513519
(merge d79fff4a11 jk/remote-tracking-ref-leakfix later to maint).
514520
(merge 7a747f972d dd/t5403-modernise later to maint).

run-command.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1895,14 +1895,19 @@ void run_processes_parallel(const struct run_process_parallel_opts *opts)
18951895
"max:%"PRIuMAX,
18961896
(uintmax_t)opts->processes);
18971897

1898+
pp_init(&pp, opts, &pp_sig);
1899+
18981900
/*
18991901
* Child tasks might receive input via stdin, terminating early (or not), so
19001902
* ignore the default SIGPIPE which gets handled by each feed_pipe_fn which
19011903
* actually writes the data to children stdin fds.
1904+
*
1905+
* This _must_ come after pp_init(), because it installs its own
1906+
* SIGPIPE handler (to cleanup children), and we want to supersede
1907+
* that.
19021908
*/
19031909
sigchain_push(SIGPIPE, SIG_IGN);
19041910

1905-
pp_init(&pp, opts, &pp_sig);
19061911
while (1) {
19071912
for (i = 0;
19081913
i < spawn_cap && !pp.shutdown &&
@@ -1928,10 +1933,10 @@ void run_processes_parallel(const struct run_process_parallel_opts *opts)
19281933
}
19291934
}
19301935

1931-
pp_cleanup(&pp, opts);
1932-
19331936
sigchain_pop(SIGPIPE);
19341937

1938+
pp_cleanup(&pp, opts);
1939+
19351940
if (do_trace2)
19361941
trace2_region_leave(tr2_category, tr2_label, NULL);
19371942
}

t/t1800-hook.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ test_description='git-hook command and config-managed multihooks'
66
. "$TEST_DIRECTORY"/lib-terminal.sh
77

88
setup_hooks () {
9-
test_config hook.ghi.command "/path/ghi"
10-
test_config hook.ghi.event pre-commit --add
11-
test_config hook.ghi.event test-hook --add
12-
test_config_global hook.def.command "/path/def"
9+
test_config hook.ghi.command "/path/ghi" &&
10+
test_config hook.ghi.event pre-commit --add &&
11+
test_config hook.ghi.event test-hook --add &&
12+
test_config_global hook.def.command "/path/def" &&
1313
test_config_global hook.def.event pre-commit --add
1414
}
1515

1616
setup_hookdir () {
17-
mkdir .git/hooks
18-
write_script .git/hooks/pre-commit <<-EOF
17+
mkdir -p .git/hooks &&
18+
write_script .git/hooks/pre-commit <<-EOF &&
1919
echo \"Legacy Hook\"
2020
EOF
2121
test_when_finished rm -rf .git/hooks

0 commit comments

Comments
 (0)