From 03862142e64850d98e4483ffdf9a0a98ded3f132 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Fri, 20 Mar 2026 14:57:11 -0400 Subject: [PATCH 1/2] refactor: handler overrides Signed-off-by: Adam Setch --- src/main/updater.test.ts | 8 ++++---- .../utils/notifications/handlers/checkSuite.ts | 10 +++++----- .../utils/notifications/handlers/commit.ts | 6 +++--- .../utils/notifications/handlers/discussion.ts | 12 ++++++------ .../utils/notifications/handlers/index.ts | 15 --------------- .../utils/notifications/handlers/issue.ts | 12 ++++++------ .../utils/notifications/handlers/pullRequest.ts | 12 ++++++------ .../utils/notifications/handlers/release.ts | 8 ++++---- .../notifications/handlers/repositoryAdvisory.ts | 8 ++++---- .../handlers/repositoryDependabotAlertsThread.ts | 8 ++++---- .../handlers/repositoryInvitation.ts | 6 +++--- .../handlers/repositoryVulnerabilityAlert.ts | 6 +++--- .../utils/notifications/handlers/workflowRun.ts | 8 ++++---- tsconfig.json | 1 + 14 files changed, 53 insertions(+), 67 deletions(-) diff --git a/src/main/updater.test.ts b/src/main/updater.test.ts index fb7d1f727..f75e9906f 100644 --- a/src/main/updater.test.ts +++ b/src/main/updater.test.ts @@ -61,10 +61,10 @@ import { autoUpdater } from 'electron-updater'; describe('main/updater.ts', () => { let menubar: Menubar; class TestMenuBuilder extends MenuBuilder { - public setCheckForUpdatesMenuEnabled = vi.fn(); - public setNoUpdateAvailableMenuVisibility = vi.fn(); - public setUpdateAvailableMenuVisibility = vi.fn(); - public setUpdateReadyForInstallMenuVisibility = vi.fn(); + public override setCheckForUpdatesMenuEnabled = vi.fn(); + public override setNoUpdateAvailableMenuVisibility = vi.fn(); + public override setUpdateAvailableMenuVisibility = vi.fn(); + public override setUpdateReadyForInstallMenuVisibility = vi.fn(); } let menuBuilder: TestMenuBuilder; diff --git a/src/renderer/utils/notifications/handlers/checkSuite.ts b/src/renderer/utils/notifications/handlers/checkSuite.ts index 8e1cc06e5..a65f46d9a 100644 --- a/src/renderer/utils/notifications/handlers/checkSuite.ts +++ b/src/renderer/utils/notifications/handlers/checkSuite.ts @@ -30,9 +30,9 @@ export interface CheckSuiteAttributes { } class CheckSuiteHandler extends DefaultHandler { - readonly type = 'CheckSuite'; + override readonly type = 'CheckSuite'; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, ): Promise> { @@ -49,7 +49,7 @@ class CheckSuiteHandler extends DefaultHandler { return {}; } - iconType(notification: GitifyNotification): FC { + override iconType(notification: GitifyNotification): FC { switch (notification.subject.state as GitifyCheckSuiteStatus) { case 'CANCELLED': return StopIcon; @@ -64,7 +64,7 @@ class CheckSuiteHandler extends DefaultHandler { } } - iconColor(notification: GitifyNotification): IconColor { + override iconColor(notification: GitifyNotification): IconColor { switch (notification.subject.state as GitifyCheckSuiteStatus) { case 'SUCCESS': return IconColor.GREEN; @@ -75,7 +75,7 @@ class CheckSuiteHandler extends DefaultHandler { } } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { return getCheckSuiteUrl(notification); } } diff --git a/src/renderer/utils/notifications/handlers/commit.ts b/src/renderer/utils/notifications/handlers/commit.ts index 5ea7c2429..6fcab242f 100644 --- a/src/renderer/utils/notifications/handlers/commit.ts +++ b/src/renderer/utils/notifications/handlers/commit.ts @@ -18,9 +18,9 @@ import { DefaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class CommitHandler extends DefaultHandler { - readonly type = 'Commit'; + override readonly type = 'Commit'; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, ): Promise> { @@ -65,7 +65,7 @@ class CommitHandler extends DefaultHandler { }; } - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return GitCommitIcon; } } diff --git a/src/renderer/utils/notifications/handlers/discussion.ts b/src/renderer/utils/notifications/handlers/discussion.ts index 54d7ae43b..f2f387f92 100644 --- a/src/renderer/utils/notifications/handlers/discussion.ts +++ b/src/renderer/utils/notifications/handlers/discussion.ts @@ -29,11 +29,11 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class DiscussionHandler extends DefaultHandler { - readonly type = 'Discussion'; + override readonly type = 'Discussion'; - readonly supportsMergedQueryEnrichment = true; + override readonly supportsMergedQueryEnrichment = true; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, fetchedData?: DiscussionDetailsFragment, @@ -82,7 +82,7 @@ class DiscussionHandler extends DefaultHandler { }; } - iconType(notification: GitifyNotification): FC { + override iconType(notification: GitifyNotification): FC { switch (notification.subject.state as GitifyDiscussionState) { case 'DUPLICATE': return DiscussionDuplicateIcon; @@ -95,7 +95,7 @@ class DiscussionHandler extends DefaultHandler { } } - iconColor(notification: GitifyNotification): IconColor { + override iconColor(notification: GitifyNotification): IconColor { switch (notification.subject.state) { case 'ANSWERED': return IconColor.GREEN; @@ -106,7 +106,7 @@ class DiscussionHandler extends DefaultHandler { } } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/discussions'; return url.href as Link; diff --git a/src/renderer/utils/notifications/handlers/index.ts b/src/renderer/utils/notifications/handlers/index.ts index 0697d937d..d296ecdc1 100644 --- a/src/renderer/utils/notifications/handlers/index.ts +++ b/src/renderer/utils/notifications/handlers/index.ts @@ -44,18 +44,3 @@ export function createNotificationHandler( return defaultHandler; } } - -export const handlers = { - checkSuiteHandler, - commitHandler, - discussionHandler, - issueHandler, - pullRequestHandler, - releaseHandler, - repositoryAdvisoryHandler, - repositoryDependabotAlertsThreadHandler, - repositoryInvitationHandler, - repositoryVulnerabilityAlertHandler, - workflowRunHandler, - defaultHandler, -}; diff --git a/src/renderer/utils/notifications/handlers/issue.ts b/src/renderer/utils/notifications/handlers/issue.ts index a81298a3d..17bd9f36e 100644 --- a/src/renderer/utils/notifications/handlers/issue.ts +++ b/src/renderer/utils/notifications/handlers/issue.ts @@ -23,11 +23,11 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class IssueHandler extends DefaultHandler { - readonly type = 'Issue'; + override readonly type = 'Issue'; - readonly supportsMergedQueryEnrichment = true; + override readonly supportsMergedQueryEnrichment = true; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, fetchedData?: IssueDetailsFragment, @@ -66,7 +66,7 @@ class IssueHandler extends DefaultHandler { }; } - iconType(notification: GitifyNotification): FC { + override iconType(notification: GitifyNotification): FC { switch (notification.subject.state as GitifyIssueState) { case 'CLOSED': case 'COMPLETED': @@ -81,7 +81,7 @@ class IssueHandler extends DefaultHandler { } } - iconColor(notification: GitifyNotification): IconColor { + override iconColor(notification: GitifyNotification): IconColor { switch (notification.subject.state as GitifyIssueState) { case 'OPEN': case 'REOPENED': @@ -95,7 +95,7 @@ class IssueHandler extends DefaultHandler { } } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/issues'; return url.href as Link; diff --git a/src/renderer/utils/notifications/handlers/pullRequest.ts b/src/renderer/utils/notifications/handlers/pullRequest.ts index 9a57a7962..6cfc857de 100644 --- a/src/renderer/utils/notifications/handlers/pullRequest.ts +++ b/src/renderer/utils/notifications/handlers/pullRequest.ts @@ -29,11 +29,11 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class PullRequestHandler extends DefaultHandler { - readonly type = 'PullRequest' as const; + override readonly type = 'PullRequest' as const; - readonly supportsMergedQueryEnrichment = true; + override readonly supportsMergedQueryEnrichment = true; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, fetchedData?: PullRequestDetailsFragment, @@ -80,7 +80,7 @@ class PullRequestHandler extends DefaultHandler { }; } - iconType(notification: GitifyNotification): FC { + override iconType(notification: GitifyNotification): FC { switch (notification.subject.state as GitifyPullRequestState) { case 'DRAFT': return GitPullRequestDraftIcon; @@ -95,7 +95,7 @@ class PullRequestHandler extends DefaultHandler { } } - iconColor(notification: GitifyNotification): IconColor { + override iconColor(notification: GitifyNotification): IconColor { switch (notification.subject.state as GitifyPullRequestState) { case 'OPEN': return IconColor.GREEN; @@ -110,7 +110,7 @@ class PullRequestHandler extends DefaultHandler { } } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/pulls'; return url.href as Link; diff --git a/src/renderer/utils/notifications/handlers/release.ts b/src/renderer/utils/notifications/handlers/release.ts index 1d2678926..3ee30c0b1 100644 --- a/src/renderer/utils/notifications/handlers/release.ts +++ b/src/renderer/utils/notifications/handlers/release.ts @@ -19,9 +19,9 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class ReleaseHandler extends DefaultHandler { - readonly type = 'Release'; + override readonly type = 'Release'; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, ): Promise> { @@ -52,11 +52,11 @@ class ReleaseHandler extends DefaultHandler { }; } - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return TagIcon; } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/releases'; return url.href as Link; diff --git a/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts b/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts index 2bcbefe77..d7c032767 100644 --- a/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts +++ b/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts @@ -7,19 +7,19 @@ import type { GitifyNotification, Link, UserType } from '../../../types'; import { DefaultHandler, defaultHandler } from './default'; class RepositoryAdvisoryHandler extends DefaultHandler { - readonly type = 'RepositoryAdvisory'; + override readonly type = 'RepositoryAdvisory'; - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return AlertIcon; } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/security/advisories'; return url.href as Link; } - defaultUserType(): UserType { + override defaultUserType(): UserType { return 'Bot'; } } diff --git a/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts b/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts index ee26ed1bb..3a2e9961d 100644 --- a/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts +++ b/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts @@ -8,19 +8,19 @@ import type { GitifyNotification, Link, UserType } from '../../../types'; import { DefaultHandler, defaultHandler } from './default'; class RepositoryDependabotAlertsThreadHandler extends DefaultHandler { - readonly type = 'RepositoryDependabotAlertsThread'; + override readonly type = 'RepositoryDependabotAlertsThread'; - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return AlertIcon; } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/security/dependabot'; return url.href as Link; } - defaultUserType(): UserType { + override defaultUserType(): UserType { return 'Bot'; } } diff --git a/src/renderer/utils/notifications/handlers/repositoryInvitation.ts b/src/renderer/utils/notifications/handlers/repositoryInvitation.ts index e72bd01a1..53f6b807f 100644 --- a/src/renderer/utils/notifications/handlers/repositoryInvitation.ts +++ b/src/renderer/utils/notifications/handlers/repositoryInvitation.ts @@ -7,13 +7,13 @@ import type { GitifyNotification, Link } from '../../../types'; import { DefaultHandler, defaultHandler } from './default'; class RepositoryInvitationHandler extends DefaultHandler { - readonly type = 'RepositoryInvitation'; + override readonly type = 'RepositoryInvitation'; - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return MailIcon; } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { const url = new URL(defaultHandler.defaultUrl(notification)); url.pathname += '/invitations'; return url.href as Link; diff --git a/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts b/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts index 5af5171b6..30114198d 100644 --- a/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts +++ b/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts @@ -7,13 +7,13 @@ import type { GitifyNotification, UserType } from '../../../types'; import { DefaultHandler } from './default'; class RepositoryVulnerabilityAlertHandler extends DefaultHandler { - readonly type = 'RepositoryVulnerabilityAlert'; + override readonly type = 'RepositoryVulnerabilityAlert'; - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return AlertIcon; } - defaultUserType(): UserType { + override defaultUserType(): UserType { return 'Bot'; } } diff --git a/src/renderer/utils/notifications/handlers/workflowRun.ts b/src/renderer/utils/notifications/handlers/workflowRun.ts index 9eb94150b..b5aec9324 100644 --- a/src/renderer/utils/notifications/handlers/workflowRun.ts +++ b/src/renderer/utils/notifications/handlers/workflowRun.ts @@ -21,9 +21,9 @@ export interface WorkflowRunAttributes { } class WorkflowRunHandler extends DefaultHandler { - readonly type = 'WorkflowRun'; + override readonly type = 'WorkflowRun'; - async enrich( + override async enrich( notification: GitifyNotification, _settings: SettingsState, ): Promise> { @@ -40,11 +40,11 @@ class WorkflowRunHandler extends DefaultHandler { return {}; } - iconType(_notification: GitifyNotification): FC { + override iconType(_notification: GitifyNotification): FC { return RocketIcon; } - defaultUrl(notification: GitifyNotification): Link { + override defaultUrl(notification: GitifyNotification): Link { return getWorkflowRunUrl(notification); } } diff --git a/tsconfig.json b/tsconfig.json index 3b5fc388c..07d4f41ed 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -16,6 +16,7 @@ "allowSyntheticDefaultImports": true, "forceConsistentCasingInFileNames": true, + "noImplicitOverride": true, "noUnusedLocals": true, "noUnusedParameters": true, "noFallthroughCasesInSwitch": true, From 5fcd1dee06fa458b1cafe3f0f16834dacb08f1e2 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Fri, 20 Mar 2026 15:02:32 -0400 Subject: [PATCH 2/2] refactor: handler overrides Signed-off-by: Adam Setch --- src/renderer/utils/notifications/handlers/checkSuite.ts | 2 -- src/renderer/utils/notifications/handlers/commit.ts | 2 -- src/renderer/utils/notifications/handlers/default.ts | 5 +---- src/renderer/utils/notifications/handlers/discussion.ts | 2 -- src/renderer/utils/notifications/handlers/issue.ts | 2 -- src/renderer/utils/notifications/handlers/pullRequest.ts | 2 -- src/renderer/utils/notifications/handlers/release.ts | 2 -- .../utils/notifications/handlers/repositoryAdvisory.ts | 2 -- .../handlers/repositoryDependabotAlertsThread.ts | 2 -- .../utils/notifications/handlers/repositoryInvitation.ts | 2 -- .../notifications/handlers/repositoryVulnerabilityAlert.ts | 2 -- src/renderer/utils/notifications/handlers/types.ts | 5 +---- src/renderer/utils/notifications/handlers/workflowRun.ts | 2 -- 13 files changed, 2 insertions(+), 30 deletions(-) diff --git a/src/renderer/utils/notifications/handlers/checkSuite.ts b/src/renderer/utils/notifications/handlers/checkSuite.ts index a65f46d9a..cb2905475 100644 --- a/src/renderer/utils/notifications/handlers/checkSuite.ts +++ b/src/renderer/utils/notifications/handlers/checkSuite.ts @@ -30,8 +30,6 @@ export interface CheckSuiteAttributes { } class CheckSuiteHandler extends DefaultHandler { - override readonly type = 'CheckSuite'; - override async enrich( notification: GitifyNotification, _settings: SettingsState, diff --git a/src/renderer/utils/notifications/handlers/commit.ts b/src/renderer/utils/notifications/handlers/commit.ts index 6fcab242f..ba41c62ec 100644 --- a/src/renderer/utils/notifications/handlers/commit.ts +++ b/src/renderer/utils/notifications/handlers/commit.ts @@ -18,8 +18,6 @@ import { DefaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class CommitHandler extends DefaultHandler { - override readonly type = 'Commit'; - override async enrich( notification: GitifyNotification, _settings: SettingsState, diff --git a/src/renderer/utils/notifications/handlers/default.ts b/src/renderer/utils/notifications/handlers/default.ts index 99505631d..76f443d21 100644 --- a/src/renderer/utils/notifications/handlers/default.ts +++ b/src/renderer/utils/notifications/handlers/default.ts @@ -9,15 +9,12 @@ import { IconColor, type Link, type SettingsState, - type SubjectType, type UserType, } from '../../../types'; import type { NotificationTypeHandler } from './types'; export class DefaultHandler implements NotificationTypeHandler { - type?: SubjectType; - - supportsMergedQueryEnrichment?: boolean = false; + supportsMergedQueryEnrichment = false; async enrich( _notification: GitifyNotification, diff --git a/src/renderer/utils/notifications/handlers/discussion.ts b/src/renderer/utils/notifications/handlers/discussion.ts index f2f387f92..966125480 100644 --- a/src/renderer/utils/notifications/handlers/discussion.ts +++ b/src/renderer/utils/notifications/handlers/discussion.ts @@ -29,8 +29,6 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class DiscussionHandler extends DefaultHandler { - override readonly type = 'Discussion'; - override readonly supportsMergedQueryEnrichment = true; override async enrich( diff --git a/src/renderer/utils/notifications/handlers/issue.ts b/src/renderer/utils/notifications/handlers/issue.ts index 17bd9f36e..85d14a122 100644 --- a/src/renderer/utils/notifications/handlers/issue.ts +++ b/src/renderer/utils/notifications/handlers/issue.ts @@ -23,8 +23,6 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class IssueHandler extends DefaultHandler { - override readonly type = 'Issue'; - override readonly supportsMergedQueryEnrichment = true; override async enrich( diff --git a/src/renderer/utils/notifications/handlers/pullRequest.ts b/src/renderer/utils/notifications/handlers/pullRequest.ts index 6cfc857de..aa51290d9 100644 --- a/src/renderer/utils/notifications/handlers/pullRequest.ts +++ b/src/renderer/utils/notifications/handlers/pullRequest.ts @@ -29,8 +29,6 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class PullRequestHandler extends DefaultHandler { - override readonly type = 'PullRequest' as const; - override readonly supportsMergedQueryEnrichment = true; override async enrich( diff --git a/src/renderer/utils/notifications/handlers/release.ts b/src/renderer/utils/notifications/handlers/release.ts index 3ee30c0b1..789d96712 100644 --- a/src/renderer/utils/notifications/handlers/release.ts +++ b/src/renderer/utils/notifications/handlers/release.ts @@ -19,8 +19,6 @@ import { DefaultHandler, defaultHandler } from './default'; import { getNotificationAuthor } from './utils'; class ReleaseHandler extends DefaultHandler { - override readonly type = 'Release'; - override async enrich( notification: GitifyNotification, _settings: SettingsState, diff --git a/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts b/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts index d7c032767..7bc15028b 100644 --- a/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts +++ b/src/renderer/utils/notifications/handlers/repositoryAdvisory.ts @@ -7,8 +7,6 @@ import type { GitifyNotification, Link, UserType } from '../../../types'; import { DefaultHandler, defaultHandler } from './default'; class RepositoryAdvisoryHandler extends DefaultHandler { - override readonly type = 'RepositoryAdvisory'; - override iconType(_notification: GitifyNotification): FC { return AlertIcon; } diff --git a/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts b/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts index 3a2e9961d..1aef950a1 100644 --- a/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts +++ b/src/renderer/utils/notifications/handlers/repositoryDependabotAlertsThread.ts @@ -8,8 +8,6 @@ import type { GitifyNotification, Link, UserType } from '../../../types'; import { DefaultHandler, defaultHandler } from './default'; class RepositoryDependabotAlertsThreadHandler extends DefaultHandler { - override readonly type = 'RepositoryDependabotAlertsThread'; - override iconType(_notification: GitifyNotification): FC { return AlertIcon; } diff --git a/src/renderer/utils/notifications/handlers/repositoryInvitation.ts b/src/renderer/utils/notifications/handlers/repositoryInvitation.ts index 53f6b807f..3aea9258b 100644 --- a/src/renderer/utils/notifications/handlers/repositoryInvitation.ts +++ b/src/renderer/utils/notifications/handlers/repositoryInvitation.ts @@ -7,8 +7,6 @@ import type { GitifyNotification, Link } from '../../../types'; import { DefaultHandler, defaultHandler } from './default'; class RepositoryInvitationHandler extends DefaultHandler { - override readonly type = 'RepositoryInvitation'; - override iconType(_notification: GitifyNotification): FC { return MailIcon; } diff --git a/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts b/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts index 30114198d..a0225f597 100644 --- a/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts +++ b/src/renderer/utils/notifications/handlers/repositoryVulnerabilityAlert.ts @@ -7,8 +7,6 @@ import type { GitifyNotification, UserType } from '../../../types'; import { DefaultHandler } from './default'; class RepositoryVulnerabilityAlertHandler extends DefaultHandler { - override readonly type = 'RepositoryVulnerabilityAlert'; - override iconType(_notification: GitifyNotification): FC { return AlertIcon; } diff --git a/src/renderer/utils/notifications/handlers/types.ts b/src/renderer/utils/notifications/handlers/types.ts index 69e23c16b..3038221a5 100644 --- a/src/renderer/utils/notifications/handlers/types.ts +++ b/src/renderer/utils/notifications/handlers/types.ts @@ -8,17 +8,14 @@ import type { IconColor, Link, SettingsState, - SubjectType, UserType, } from '../../../types'; export interface NotificationTypeHandler { - readonly type?: SubjectType; - /** * Whether the notification handler supports enrichment via merged GraphQL query. */ - readonly supportsMergedQueryEnrichment?: boolean; + readonly supportsMergedQueryEnrichment: boolean; /** * Enriches a base notification with additional information (state, author, metrics, etc). diff --git a/src/renderer/utils/notifications/handlers/workflowRun.ts b/src/renderer/utils/notifications/handlers/workflowRun.ts index b5aec9324..44a83f4e7 100644 --- a/src/renderer/utils/notifications/handlers/workflowRun.ts +++ b/src/renderer/utils/notifications/handlers/workflowRun.ts @@ -21,8 +21,6 @@ export interface WorkflowRunAttributes { } class WorkflowRunHandler extends DefaultHandler { - override readonly type = 'WorkflowRun'; - override async enrich( notification: GitifyNotification, _settings: SettingsState,