From f0b7b3720da9076a46cae8d27dea7def1666e221 Mon Sep 17 00:00:00 2001 From: ldetmer Date: Tue, 24 Mar 2026 11:29:05 -0400 Subject: [PATCH 1/5] feat(bigquery): add url.template to span tracing --- .../bigquery/spi/v2/HttpBigQueryRpc.java | 39 ++++++++++++++++++- .../telemetry/BigQueryTelemetryTracer.java | 1 + .../HttpTracingRequestInitializer.java | 1 - .../bigquery/spi/v2/HttpBigQueryRpcTest.java | 3 ++ 4 files changed, 42 insertions(+), 2 deletions(-) diff --git a/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java b/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java index d4ef3832f8c2..8eccc74fe8b1 100644 --- a/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java +++ b/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java @@ -193,6 +193,7 @@ public Dataset getDatasetSkipExceptionTranslation( "DatasetService", "GetDataset", gcpResourceDestinationId, + bqGetRequest.getUriTemplate(), options), span -> { Dataset dataset = bqGetRequest.execute(); @@ -243,6 +244,7 @@ public Tuple> listDatasetsSkipExceptionTranslation( "DatasetService", "ListDatasets", gcpResourceDestinationId, + datasetsListRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -301,6 +303,7 @@ public Dataset createSkipExceptionTranslation(Dataset dataset, Map op "DatasetService", "InsertDataset", gcpResourceDestinationId, + bqCreateRequest.getUriTemplate(), options), span -> { Dataset datasetResponse = bqCreateRequest.execute(); @@ -354,6 +357,7 @@ public Table createSkipExceptionTranslation(Table table, Map options) "TableService", "InsertTable", gcpResourceDestinationId, + bqCreateRequest.getUriTemplate(), options), span -> { Table tableResponse = bqCreateRequest.execute(); @@ -405,6 +409,7 @@ public Routine createSkipExceptionTranslation(Routine routine, Map op "RoutineService", "InsertRoutine", gcpResourceDestinationId, + bqCreateRequest.getUriTemplate(), options), span -> { Routine routineResponse = bqCreateRequest.execute(); @@ -456,6 +461,7 @@ public Job createSkipExceptionTranslation(Job job, Map options) throw "JobService", "InsertJob", gcpResourceDestinationId, + bqCreateRequest.getUriTemplate(), options), span -> { Job jobResponse = bqCreateRequest.execute(); @@ -504,6 +510,7 @@ public Job createJobForQuerySkipExceptionTranslation(Job job) throws IOException "JobService", "InsertJob", gcpResourceDestinationId, + bqCreateRequest.getUriTemplate(), null), span -> { Job jobResponse = bqCreateRequest.execute(); @@ -558,6 +565,7 @@ public boolean deleteDatasetSkipExceptionTranslation( "DatasetService", "DeleteDataset", gcpResourceDestinationId, + bqDeleteRequest.getUriTemplate(), options), span -> { bqDeleteRequest.execute(); @@ -609,6 +617,7 @@ public Dataset patchSkipExceptionTranslation(Dataset dataset, Map opt "DatasetService", "PatchDataset", gcpResourceDestinationId, + bqPatchRequest.getUriTemplate(), options), span -> { Dataset datasetResponse = bqPatchRequest.execute(); @@ -664,6 +673,7 @@ public Table patchSkipExceptionTranslation(Table table, Map options) "TableService", "PatchTable", gcpResourceDestinationId, + bqPatchRequest.getUriTemplate(), options), span -> { Table tableResponse = bqPatchRequest.execute(); @@ -721,6 +731,7 @@ public Table getTableSkipExceptionTranslation( "TableService", "GetTable", gcpResourceDestinationId, + bqGetRequest.getUriTemplate(), options), span -> { Table tableResponse = bqGetRequest.execute(); @@ -779,6 +790,7 @@ public Tuple> listTablesSkipExceptionTranslation( "TableService", "ListTables", gcpResourceDestinationId, + tableListRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -853,6 +865,7 @@ public boolean deleteTableSkipExceptionTranslation( "TableService", "DeleteTable", gcpResourceDestinationId, + bqDeleteRequest.getUriTemplate(), null), span -> { bqDeleteRequest.execute(); @@ -903,6 +916,7 @@ public Model patchSkipExceptionTranslation(Model model, Map options) "ModelService", "PatchModel", gcpResourceDestinationId, + bqPatchRequest.getUriTemplate(), options), span -> { Model modelResponse = bqPatchRequest.execute(); @@ -960,6 +974,7 @@ public Model getModelSkipExceptionTranslation( "ModelService", "GetModel", gcpResourceDestinationId, + bqGetRequest.getUriTemplate(), options), span -> { Model modelResponse = bqGetRequest.execute(); @@ -1012,6 +1027,7 @@ public Tuple> listModelsSkipExceptionTranslation( "ModelService", "ListModels", gcpResourceDestinationId, + modelListRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -1070,6 +1086,7 @@ public boolean deleteModelSkipExceptionTranslation( "ModelService", "DeleteModel", gcpResourceDestinationId, + bqDeleteRequest.getUriTemplate(), null), span -> { bqDeleteRequest.execute(); @@ -1122,6 +1139,7 @@ public Routine updateSkipExceptionTranslation(Routine routine, Map op "RoutineService", "UpdateRoutine", gcpResourceDestinationId, + bqUpdateRequest.getUriTemplate(), options), span -> { Routine routineResponse = bqUpdateRequest.execute(); @@ -1179,6 +1197,7 @@ public Routine getRoutineSkipExceptionTranslation( "RoutineService", "GetRoutine", gcpResourceDestinationId, + bqGetRequest.getUriTemplate(), options), span -> { Routine routineResponse = bqGetRequest.execute(); @@ -1231,6 +1250,7 @@ public Tuple> listRoutinesSkipExceptionTranslation( "RoutineService", "ListRoutines", gcpResourceDestinationId, + routineListRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -1288,6 +1308,7 @@ public boolean deleteRoutineSkipExceptionTranslation( "RoutineService", "DeleteRoutine", gcpResourceDestinationId, + bqDeleteRequest.getUriTemplate(), null), span -> { bqDeleteRequest.execute(); @@ -1336,6 +1357,7 @@ public TableDataInsertAllResponse insertAllSkipExceptionTranslation( "TableDataService", "InsertAll", gcpResourceDestinationId, + insertAllRequest.getUriTemplate(), null), span -> insertAllRequest.execute()); } @@ -1387,6 +1409,7 @@ public TableDataList listTableDataSkipExceptionTranslation( "TableDataService", "List", gcpResourceDestinationId, + bqListRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -1448,6 +1471,7 @@ public TableDataList listTableDataWithRowLimitSkipExceptionTranslation( "TableDataService", "List", gcpResourceDestinationId, + bqListRequest.getUriTemplate(), null), span -> { if (span != null) { @@ -1500,6 +1524,7 @@ public Job getJobSkipExceptionTranslation( "JobService", "GetJob", gcpResourceDestinationId, + bqGetRequest.getUriTemplate(), options), span -> { Job jobResponse = bqGetRequest.execute(); @@ -1550,6 +1575,7 @@ public Job getQueryJobSkipExceptionTranslation(String projectId, String jobId, S "JobService", "GetJob", gcpResourceDestinationId, + bqGetRequest.getUriTemplate(), null), span -> { Job jobResponse = bqGetRequest.execute(); @@ -1612,6 +1638,7 @@ public Tuple> listJobsSkipExceptionTranslation( "JobService", "ListJobs", gcpResourceDestinationId, + listJobsRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -1689,6 +1716,7 @@ public boolean cancelSkipExceptionTranslation(String projectId, String jobId, St "JobService", "CancelJob", gcpResourceDestinationId, + bqCancelRequest.getUriTemplate(), null), span -> { bqCancelRequest.execute(); @@ -1730,6 +1758,7 @@ public boolean deleteJobSkipExceptionTranslation( "JobService", "DeleteJob", gcpResourceDestinationId, + bqDeleteRequest.getUriTemplate(), null), span -> { bqDeleteRequest.execute(); @@ -1783,6 +1812,7 @@ public GetQueryResultsResponse getQueryResultsSkipExceptionTranslation( "JobService", "GetQueryResults", gcpResourceDestinationId, + queryRequest.getUriTemplate(), options), span -> { if (span != null) { @@ -1835,6 +1865,7 @@ public GetQueryResultsResponse getQueryResultsWithRowLimitSkipExceptionTranslati "JobService", "GetQueryResults", gcpResourceDestinationId, + queryRequest.getUriTemplate(), null), span -> { if (span != null) { @@ -1875,6 +1906,7 @@ public QueryResponse queryRpcSkipExceptionTranslation(String projectId, QueryReq "JobService", "Query", gcpResourceDestinationId, + queryRequest.getUriTemplate(), null), span -> { return queryRequest.execute(); @@ -2006,6 +2038,7 @@ public Policy getIamPolicySkipExceptionTranslation(String resourceId, Map