From ad69e9c2392755694f042c4130eb2048fd6d6760 Mon Sep 17 00:00:00 2001 From: Joseph Eftekhari Date: Wed, 4 Mar 2026 19:56:47 -1000 Subject: [PATCH] fix: warn on credential file permission failures instead of ignoring Replaced silent `let _ =` on set_permissions calls in save_encrypted with eprintln! warnings so users are aware if their credential files end up with insecure permissions. Also log keyring access failures instead of silently falling through to file storage. --- .changeset/fix-credential-permission-warnings.md | 10 ++++++++++ src/credential_store.rs | 4 +++- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 .changeset/fix-credential-permission-warnings.md diff --git a/.changeset/fix-credential-permission-warnings.md b/.changeset/fix-credential-permission-warnings.md new file mode 100644 index 0000000..d78e3b8 --- /dev/null +++ b/.changeset/fix-credential-permission-warnings.md @@ -0,0 +1,10 @@ +--- +"@googleworkspace/cli": patch +--- + +fix: warn on credential file permission failures instead of ignoring + +Replaced silent `let _ =` on `set_permissions` calls in `save_encrypted` +with `eprintln!` warnings so users are aware if their credential files +end up with insecure permissions. Also log keyring access failures +instead of silently falling through to file storage. diff --git a/src/credential_store.rs b/src/credential_store.rs index 654b5dd..7b9bd73 100644 --- a/src/credential_store.rs +++ b/src/credential_store.rs @@ -119,7 +119,9 @@ fn get_or_create_key() -> anyhow::Result<[u8; 32]> { return Ok(cache_key(key)); } - Err(_) => {} // Fallthrough to file storage + Err(e) => { + eprintln!("Warning: keyring access failed, falling back to file storage: {e}"); + } } }