You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current format of test data is not perfectly compatible with the debug output of ewms-pilot. In particular:
in- pickles of ewms-pilot are dictionaries already containing reco_algo and pframe, while the current CI pipeline expects a bare pframe in the pickle, and wraps it in a dictionary with reco_algo with an auxiliary script. Should we drop the "old" format and update the test data for millipede_original?
the out pickle for comparison is expected to have a filename in the form *.out.pkl while ewms-pilot outputs something in the form f"out-{HASH}.pkl". We may want to make this consistent.
Additional remarks:
the scan of hese_event_01.json outputs a file named run00127907.evt000020178442.HESE_1.npz but is supposedly a simulated event. I find it a bit confusing.
The current format of test data is not perfectly compatible with the debug output of ewms-pilot. In particular:
in-pickles of ewms-pilot are dictionaries already containingreco_algoandpframe, while the current CI pipeline expects a barepframein the pickle, and wraps it in a dictionary withreco_algowith an auxiliary script. Should we drop the "old" format and update the test data formillipede_original?outpickle for comparison is expected to have a filename in the form*.out.pklwhile ewms-pilot outputs something in the formf"out-{HASH}.pkl". We may want to make this consistent.Additional remarks:
hese_event_01.jsonoutputs a file namedrun00127907.evt000020178442.HESE_1.npzbut is supposedly a simulated event. I find it a bit confusing.