diff --git a/core/src/components/popover/popover.scss b/core/src/components/popover/popover.common.scss similarity index 100% rename from core/src/components/popover/popover.scss rename to core/src/components/popover/popover.common.scss diff --git a/core/src/components/popover/popover.ionic.scss b/core/src/components/popover/popover.ionic.scss new file mode 100644 index 00000000000..979b81ac651 --- /dev/null +++ b/core/src/components/popover/popover.ionic.scss @@ -0,0 +1,21 @@ +@use "../../themes/ionic/ionic.globals.scss" as globals; +@use "./popover.common.scss"; + +// Ionic Popover +// -------------------------------------------------- + +:host { + --width: 250px; + --max-height: 90%; + --box-shadow: #{globals.$ion-elevation-4}; + --backdrop-opacity: 0.3; +} + +.popover-content { + @include globals.border-radius(globals.$ion-border-radius-400); + @include globals.transform-origin(start, top); +} + +.popover-viewport { + transition-delay: 100ms; +} diff --git a/core/src/components/popover/popover.ios.scss b/core/src/components/popover/popover.ios.scss index e3ccdcb217c..360c9c6b712 100644 --- a/core/src/components/popover/popover.ios.scss +++ b/core/src/components/popover/popover.ios.scss @@ -1,4 +1,4 @@ -@import "./popover"; +@import "./popover.common.scss"; @import "./popover.ios.vars"; // iOS Popover diff --git a/core/src/components/popover/popover.md.scss b/core/src/components/popover/popover.md.scss index 7b4e5c2d19d..e48db871e10 100644 --- a/core/src/components/popover/popover.md.scss +++ b/core/src/components/popover/popover.md.scss @@ -1,4 +1,4 @@ -@import "./popover"; +@import "./popover.common.scss"; @import "./popover.md.vars"; // Material Design Popover diff --git a/core/src/components/popover/popover.tsx b/core/src/components/popover/popover.tsx index c330b471780..dfe725e31db 100644 --- a/core/src/components/popover/popover.tsx +++ b/core/src/components/popover/popover.tsx @@ -53,7 +53,7 @@ import { configureDismissInteraction, configureKeyboardInteraction, configureTri styleUrls: { ios: 'popover.ios.scss', md: 'popover.md.scss', - ionic: 'popover.md.scss', + ionic: 'popover.ionic.scss', }, shadow: true, }) diff --git a/core/src/components/popover/test/basic/popover.e2e.ts b/core/src/components/popover/test/basic/popover.e2e.ts index ae30596d0e2..fadb7557e5d 100644 --- a/core/src/components/popover/test/basic/popover.e2e.ts +++ b/core/src/components/popover/test/basic/popover.e2e.ts @@ -3,7 +3,7 @@ import { configs, test } from '@utils/test/playwright'; import { PopoverFixture } from '../fixture'; -configs().forEach(({ title, screenshot, config }) => { +configs({ modes: ['md', 'ios', 'ionic-md'] }).forEach(({ title, screenshot, config }) => { test.describe(title('popover: rendering'), async () => { test('should not have visual regressions', async ({ page }) => { const popoverFixture = new PopoverFixture(page); @@ -18,7 +18,7 @@ configs().forEach(({ title, screenshot, config }) => { /** * This behavior does not vary across directions. */ -configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { +configs({ directions: ['ltr'], modes: ['md', 'ios', 'ionic-md'] }).forEach(({ title, screenshot, config }) => { test.describe(title('popover: rendering variants'), async () => { let popoverFixture!: PopoverFixture; test.beforeEach(async ({ page }) => { diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..e74d5da469f Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..05e92782eac Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..e646b433e5a Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..c2d1e31c5d4 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Firefox-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..946548e0b25 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..b8e13863bbb Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ionic-md-rtl-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..7f79f222513 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..4d26867c19c Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..e73d1f26f2d Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..a4b6539dfd6 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..c151171b4e8 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..4b6fe00de7b Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ionic-md-ltr-light-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png new file mode 100644 index 00000000000..5e126d9ba02 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png new file mode 100644 index 00000000000..8e4b1477c29 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Safari-linux.png new file mode 100644 index 00000000000..8cf99bcc5a1 Binary files /dev/null and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ionic-md-ltr-light-Mobile-Safari-linux.png differ