Reduce Gradle and Android warning noise

Author: 8Keep

build.gradle

@@ -6,7 +6,7 @@ buildscript {
         mavenCentral()
         google()
         maven {
-            url "https://plugins.gradle.org/m2/"
+            url = "https://plugins.gradle.org/m2/"
         }
     }
     dependencies {
@@ -121,7 +121,7 @@ task copyLibs(type: Copy){
 }
 
 task dist(dependsOn: [':jme3-examples:dist', 'mergedJavadoc']){
-    description 'Creates a jME3 examples distribution with all jme3 binaries, sources, javadoc and external libraries under ./dist'
+    description = 'Creates a jME3 examples distribution with all jme3 binaries, sources, javadoc and external libraries under ./dist'
 }
 
 def mergedJavadocSubprojects = [
@@ -241,5 +241,4 @@ if (skipPrebuildLibraries != "true" && buildNativeProjects != "true") {
         }
 
         assemble.dependsOn extractPrebuiltNatives
-    }
-}
+}

common.gradle

@@ -93,26 +93,26 @@ task javadocJar(type: Jar, dependsOn: javadoc, description: 'Creates a jar from
 }
 
 ext.pomConfig = {
-    name POM_NAME
-    description POM_DESCRIPTION
-    url POM_URL
-    inceptionYear POM_INCEPTION_YEAR
+    name = POM_NAME
+    description = POM_DESCRIPTION
+    url = POM_URL
+    inceptionYear = POM_INCEPTION_YEAR
     scm {
-        url POM_SCM_URL
-        connection POM_SCM_CONNECTION
-        developerConnection POM_SCM_DEVELOPER_CONNECTION
+        url = POM_SCM_URL
+        connection = POM_SCM_CONNECTION
+        developerConnection = POM_SCM_DEVELOPER_CONNECTION
     }
     licenses {
         license {
-            name POM_LICENSE_NAME
-            url POM_LICENSE_URL
-            distribution POM_LICENSE_DISTRIBUTION
+            name = POM_LICENSE_NAME
+            url = POM_LICENSE_URL
+            distribution = POM_LICENSE_DISTRIBUTION
         }
     }
     developers {
         developer {
-            name 'jMonkeyEngine Team'
-            id 'jMonkeyEngine'
+            name = 'jMonkeyEngine Team'
+            id = 'jMonkeyEngine'
         }
     }
 }
@@ -155,7 +155,7 @@ publishing {
                 }
                 url = POM_URL
             }
-            version project.version
+            version = project.version
         }
     }
 
@@ -210,8 +210,8 @@ tasks.withType(Sign) {
 }
 
 checkstyle {
-    toolVersion libs.versions.checkstyle.get()
-    configFile file("${gradle.rootProject.rootDir}/config/checkstyle/checkstyle.xml")
+    toolVersion = libs.versions.checkstyle.get()
+    configFile = file("${gradle.rootProject.rootDir}/config/checkstyle/checkstyle.xml")
 }
 
 checkstyleMain {

jme3-android/src/main/java/com/jme3/app/AndroidHarness.java

@@ -5,6 +5,7 @@
 import android.content.DialogInterface;
 import android.graphics.drawable.Drawable;
 import android.graphics.drawable.NinePatchDrawable;
+import android.graphics.Point;
 import android.opengl.GLSurfaceView;
 import android.os.Bundle;
 import android.util.Log;
@@ -216,7 +217,9 @@ public void onCreate(Bundle savedInstanceState) {
             //TODO try to find a better way to get a hand on the resolution
             WindowManager wind = this.getWindowManager();
             Display disp = wind.getDefaultDisplay();
-            Log.d("AndroidHarness", "Resolution from Window, width:" + disp.getWidth() + ", height: " + disp.getHeight());
+            Point displaySize = new Point();
+            disp.getSize(displaySize);
+            Log.d("AndroidHarness", "Resolution from Window, width:" + displaySize.x + ", height: " + displaySize.y);
 
             // Create Settings
             logger.log(Level.FINE, "Creating settings");
@@ -232,7 +235,7 @@ public void onCreate(Bundle savedInstanceState) {
             settings.setSamples(eglSamples);
             settings.setStencilBits(eglStencilBits);
 
-            settings.setResolution(disp.getWidth(), disp.getHeight());
+            settings.setResolution(displaySize.x, displaySize.y);
             settings.setAudioRenderer(audioRendererType);
 
             settings.setFrameRate(frameRate);
@@ -410,9 +413,9 @@ public void layoutDisplay() {
             frameLayout = new FrameLayout(this);
             splashImageView = new ImageView(this);
 
-            Drawable drawable = this.getResources().getDrawable(splashPicID);
+            Drawable drawable = splashImageView.getContext().getDrawable(splashPicID);
             if (drawable instanceof NinePatchDrawable) {
-                splashImageView.setBackgroundDrawable(drawable);
+                splashImageView.setBackground(drawable);
             } else {
                 splashImageView.setImageResource(splashPicID);
             }

jme3-android/src/main/java/com/jme3/app/AndroidHarnessFragment.java

@@ -70,6 +70,7 @@
  *
  * @author iwgeric
  */
+@SuppressWarnings("deprecation")
 public class AndroidHarnessFragment extends Fragment implements
         TouchListener, DialogInterface.OnClickListener, View.OnLayoutChangeListener, SystemListener {
     private static final Logger logger = Logger.getLogger(AndroidHarnessFragment.class.getName());
@@ -494,9 +495,9 @@ public void createLayout() {
         if (splashPicID != 0) {
             splashImageView = new ImageView(getActivity());
 
-            Drawable drawable = getResources().getDrawable(splashPicID);
+            Drawable drawable = splashImageView.getContext().getDrawable(splashPicID);
             if (drawable instanceof NinePatchDrawable) {
-                splashImageView.setBackgroundDrawable(drawable);
+                splashImageView.setBackground(drawable);
             } else {
                 splashImageView.setImageResource(splashPicID);
             }

jme3-android/src/main/java/com/jme3/system/android/JmeAndroidSystem.java

@@ -75,6 +75,7 @@ public void writeImageFile(OutputStream outStream, String format, ByteBuffer ima
 
 
     @Override
+    @SuppressWarnings("deprecation")
     public JmeContext newContext(AppSettings settings, Type contextType) {
         if (settings.getAudioRenderer() == null) {
             audioRendererType = null;

jme3-android/src/main/java/com/jme3/system/android/OGLESContext.java

@@ -493,8 +493,8 @@ public void requestDialog(
                     public void run() {
                         final FrameLayout layoutTextDialogInput = new FrameLayout(view.getContext());
                         final EditText editTextDialogInput = new EditText(view.getContext());
-                        editTextDialogInput.setWidth(LayoutParams.FILL_PARENT);
-                        editTextDialogInput.setHeight(LayoutParams.FILL_PARENT);
+                        editTextDialogInput.setWidth(LayoutParams.MATCH_PARENT);
+                        editTextDialogInput.setHeight(LayoutParams.MATCH_PARENT);
                         editTextDialogInput.setPadding(20, 20, 20, 20);
                         editTextDialogInput.setGravity(Gravity.FILL_HORIZONTAL);
                         //editTextDialogInput.setImeOptions(EditorInfo.IME_FLAG_NO_EXTRACT_UI);

jme3-core/src/test/java/com/jme3/material/plugins/J3MLoaderTest.java

@@ -19,7 +19,7 @@
 import org.mockito.Mockito;
 import org.mockito.junit.MockitoJUnitRunner;
 
-import static org.mockito.Matchers.any;
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.verify;
 import static org.junit.Assert.*;
 import static org.mockito.Mockito.when;