Skip to content

Upgrade all legacy Angular design patterns and methodologies #1361

@jaypatrick

Description

@jaypatrick

Scan ALL angular code and make sure no previous version design patterns are used. Everything should be the latest and greatest features from Angular 21. An example of how this is costing us productivity, look at PR #1360 : Angular 21 changed angular-app-engine-manifest.mjs from a side-effect module (auto-called setAngularAppEngineManifest() on import) to a pure data export. The server.ts was still using the Angular 17 import './src/main.server' pattern, which never registered the engine manifest — so new AngularAppEngine(), which reads it eagerly as a class field initializer, threw at Worker module load time (Cloudflare error 10021: Angular app engine manifest is not set). A compounding issue: because nothing in server.ts used setAngularAppEngineManifest, esbuild tree-shook the function entirely out of the output chunk" This was a FOUR HOUR CI fix that should have never existed in the first place since we were using Angular 17 design methodologies. All angular code must be completely up to date with Angular 21 features, and if any older styles are found, they need to be upgraded immediately.

Metadata

Metadata

Labels

bugSomething isn't workingenhancementNew feature or requestfrontendAngular frontend

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions