-
+
From 9d6b44eabbfcf95ccd1027403496e76bca3c2047 Mon Sep 17 00:00:00 2001 From: Paul Keen <125715+pftg@users.noreply.github.com> Date: Mon, 29 Sep 2025 17:18:11 +0200 Subject: [PATCH 153/154] wip --- test/unit/template_cleanup_validation_test.rb | 40 ++++++++ themes/beaver/assets/css/components.css | 2 +- themes/beaver/layouts/404.html | 26 ++--- themes/beaver/layouts/careers/single.html | 28 +++--- themes/beaver/layouts/clients/single.html | 60 ++++++------ themes/beaver/layouts/home.html | 46 ++++----- themes/beaver/layouts/page/about.html | 80 ++++++++-------- themes/beaver/layouts/page/careers.html | 94 +++++++++---------- themes/beaver/layouts/page/clients.html | 22 ++--- .../layouts/page/free-consultation.html | 16 ++-- themes/beaver/layouts/page/services.html | 52 +++++----- themes/beaver/layouts/page/test-cta.html | 50 +++++----- themes/beaver/layouts/page/test-hero.html | 30 +++--- themes/beaver/layouts/page/use-cases.html | 18 ++-- .../layouts/partials/homepage/hero.html | 30 +++--- .../layouts/partials/homepage/services.html | 34 +++---- themes/beaver/layouts/services/single.html | 74 +++++++-------- themes/beaver/layouts/use-cases/single.html | 54 +++++------ 18 files changed, 398 insertions(+), 358 deletions(-) diff --git a/test/unit/template_cleanup_validation_test.rb b/test/unit/template_cleanup_validation_test.rb index 859777f80..be9cbc9f3 100644 --- a/test/unit/template_cleanup_validation_test.rb +++ b/test/unit/template_cleanup_validation_test.rb @@ -281,6 +281,46 @@ def test_performance_indicators end end + def test_fl_node_removal_layout_preservation + # Validates that FL-node class removal preserves essential layout structure + @test_pages.each do |page_name, file_path| + next unless test_page_exists?(page_name) + + doc = parse_html_file(file_path) + + # Essential FL structural classes should remain (layout-critical) + structural_classes = %w[fl-row-content fl-col-content fl-module-content fl-row fl-col fl-module] + + # Verify structural FL classes are preserved for layout + structural_elements = doc.css(".fl-row-content, .fl-col-content, .fl-module-content") + if structural_elements.any? + # If FL structure exists, validate it's complete + assert doc.css(".fl-row").any?, "#{page_name} should preserve fl-row layout structure" + assert doc.css(".fl-row-content").any?, "#{page_name} should preserve fl-row-content layout" + end + + # Decorative FL-node classes should be safely removable without layout impact + # This test ensures the page renders correctly regardless of FL-node-[hash] presence + page_content = doc.css("main, article, .content, body").first + assert page_content, "#{page_name} should have main content area after FL-node cleanup" + + # Verify no broken class references remain after cleanup + broken_class_patterns = [ + "fl-node-undefined", + "fl-node-null", + "fl-node-error", + "data-node=\"undefined\"", + "data-node=\"null\"" + ] + + broken_class_patterns.each do |pattern| + page_html = doc.to_html + assert !page_html.include?(pattern), + "#{page_name} should not have broken FL-node references: #{pattern}" + end + end + end + def test_accessibility_basics @test_pages.each do |page_name, file_path| next unless test_page_exists?(page_name) diff --git a/themes/beaver/assets/css/components.css b/themes/beaver/assets/css/components.css index 06c3ae139..e42c885c6 100644 --- a/themes/beaver/assets/css/components.css +++ b/themes/beaver/assets/css/components.css @@ -4,7 +4,7 @@ COMMENTED TO MAKE TESTS PASS */ /* @import 'components/foundation'; */ @import 'components/alerts'; -/* @import 'components/forms'; +/* @import 'components/forms'; */ @import 'components/content-block'; @import 'components/css-utilities'; diff --git a/themes/beaver/layouts/404.html b/themes/beaver/layouts/404.html index 3918e0e1a..e1b149899 100644 --- a/themes/beaver/layouts/404.html +++ b/themes/beaver/layouts/404.html @@ -43,18 +43,18 @@
-
+
-
+
-
+

We can’t seem to find the page you’re looking for @@ -66,7 +66,7 @@

-
+

Sorry, the page you requested could not be found.

@@ -75,7 +75,7 @@

-
+
-
+
-
+
@@ -114,11 +114,11 @@

class="fl-col-group fl-node-wngd074viayh error-page__spacer-section" data-node="wngd074viayh">
-
+
-
+
@@ -130,11 +130,11 @@

-
+
-
+

Working with teams, CTOs praise us as @@ -146,7 +146,7 @@

-
+

Talk with one of our experts to get a technical @@ -159,7 +159,7 @@

-
+
-
+
-
+
-
+

{{ .Params.position }}
-
+
-
+

{{ .name }}

@@ -66,7 +66,7 @@

-
+

{{ .value }}

@@ -79,11 +79,11 @@

-
+
-
+

Share to

@@ -92,7 +92,7 @@