hooks enabled: an exporter with beforeHook set to exit, still executes the afterHook following a beforeHook failure

[evakhoni]

an exporter with beforeHook set to exit, still executes the afterHook following a beforeHook failure, and only after that exists. is this an expected behavior?

INFO:jumpstarter.exporter.hooks:Subprocess completed with code: 127
ERROR:jumpstarter.exporter.hooks:Hook failed with exit code 127 (on_failure=exit, raising exception)
ERROR:jumpstarter.exporter.hooks:beforeLease hook failed with on_failure='exit': Hook failed with exit code 127
INFO:jumpstarter.exporter.exporter:Updated status to BEFORE_LEASE_HOOK_FAILED: beforeLease hook failed (on_failure=exit, shutting down): Hook failed with exit code 127
INFO:jumpstarter.exporter.exporter:Exporter marked for stop upon lease exit
INFO:jumpstarter.exporter.exporter:Handling new connection request on lease 019c6c8d-dc6a-7336-ba78-3a4125243f7a (router=router.jumpstarter.10.0.0.1.nip.io:8083)
INFO:jumpstarter.exporter.exporter:Handling new connection request on lease 019c6c8d-dc6a-7336-ba78-3a4125243f7a (router=router.jumpstarter.10.0.0.1.nip.io:8083)
INFO:jumpstarter.exporter.exporter:Currently not leased
INFO:jumpstarter.exporter.exporter:Lease ended, signaling handle_lease to run afterLease hook
INFO:jumpstarter.exporter.exporter:Lease ended event received, stopping connection handling
INFO:jumpstarter.exporter.exporter:Running afterLease hook on session close
INFO:jumpstarter.exporter.exporter:Updated status to AFTER_LEASE_HOOK: Running afterLease hooks
INFO:jumpstarter.exporter.hooks:Executing after-lease hook for lease 019c6c8d-dc6a-7336-ba78-3a4125243f7a

[mangelajo]

I don't think this is necessarily a bug, more like a feature.

i.e. if the after is "power off" I think it would be a good think

WDYT @kirkbrauer

[mangelajo]

I am closing as this not being a bug, but feel free to reopen if you disagree.