Skip to content

Commit ce96325

Browse files
fix: overflow scrolling. (#14)
1 parent 8c60315 commit ce96325

4 files changed

Lines changed: 17 additions & 17 deletions

File tree

docs/next-steps.md

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,20 @@
22

33
Focused follow-up work for `@knighted/develop`.
44

5-
1. **Style isolation behavior docs**
6-
- Document ShadowRoot on/off behavior and how style isolation changes in light DOM mode.
7-
- Clarify that light DOM preview can inherit shell styles and include recommendations for scoping.
8-
9-
2. **Preview UX polish**
10-
- Keep tooltip affordances for mode-specific behavior.
11-
- Continue tightening panel control alignment and spacing without introducing extra markup.
12-
13-
3. **In-browser component/style linting**
5+
1. **In-browser component/style linting**
146
- Explore running lint checks for component and style sources directly in the playground.
157
- Prefer CDN-delivered tooling where possible and preserve graceful fallback behavior when unavailable.
168

17-
4. **In-browser component type checking**
9+
2. **In-browser component type checking**
1810
- Add editor-linked diagnostics navigation so each issue can jump to the exact line/column in the component source.
1911
- Surface line/column context directly in the diagnostics UI (not just message text) to speed up triage.
2012
- Continue improving typecheck performance for first-run and large sources while keeping the preview loop non-blocking.
2113

22-
5. **In-browser component testing**
14+
3. **In-browser component testing**
2315
- Explore authoring and running component-focused tests in-browser (for example, a Vitest-compatible flow) using CDN-delivered tooling.
2416
- Define a lightweight test UX that supports writing tests, running them on demand, and displaying results in-app.
2517

26-
6. **CDN failure recovery UX**
18+
4. **CDN failure recovery UX**
2719
- Detect transient CDN/module loading failures and surface a clear recovery action in-app.
2820
- Add a user-triggered retry path (for example, Reload page / Force reload) when runtime bootstrap imports fail.
2921
- Consider an optional automatic one-time retry before showing recovery controls, while avoiding infinite reload loops.

src/styles/layout-shell.css

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,15 @@
298298
overflow: hidden;
299299
}
300300

301+
.app-grid:not(.app-grid--preview-right):not(.app-grid--preview-left) .preview-panel {
302+
min-height: 0;
303+
}
304+
301305
.preview-panel .panel-content {
302306
min-height: 0;
307+
height: 100%;
303308
max-height: 100%;
304-
overflow: hidden;
309+
overflow: auto;
305310
}
306311

307312
.preview-panel.panel--collapsed-horizontal,

src/styles/panels-editor.css

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,9 @@ textarea:focus {
323323
}
324324

325325
.preview-panel.panel--collapsed-horizontal .panel-collapse-toggle {
326-
width: 100%;
327-
min-width: 0;
326+
width: 32px;
327+
min-width: 32px;
328+
height: 32px;
328329
justify-content: center;
329330
}
330331

@@ -377,8 +378,9 @@ textarea:focus {
377378

378379
.component-panel.panel--collapsed-horizontal .panel-collapse-toggle,
379380
.styles-panel.panel--collapsed-horizontal .panel-collapse-toggle {
380-
width: 100%;
381-
min-width: 0;
381+
width: 32px;
382+
min-width: 32px;
383+
height: 32px;
382384
}
383385

384386
@media (max-width: 900px) {

src/styles/preview-controls.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
--preview-host-z-index: 1;
99
display: var(--preview-host-display);
1010
flex: var(--preview-host-flex);
11+
height: 100%;
1112
min-height: var(--preview-host-min-height);
1213
max-height: 100%;
1314
padding: var(--preview-host-padding);

0 commit comments

Comments
 (0)