Skip to content
lint

refactor: add internal Promise/Future classes for future use #2226

Sign in to view logs

refactor: add internal Promise/Future classes for future use

refactor: add internal Promise/Future classes for future use #2226

Triggered via pull request April 15, 2026 19:31
@beekldbeekld
synchronize #521
beeklimt/promises
Status Success
Total duration 2m 7s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
1m 49s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
/libs/internal/include/launchdarkly/async/promise.hpp:477:50 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L477
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:475:58 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L475
no type named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:470:39 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L470
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:465:30 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L465
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:462:17 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L462
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:461:18 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L461
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:460:13 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L460
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:363:50 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L363
expected ';' after return statement
/libs/internal/include/launchdarkly/async/promise.hpp:363:41 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L363
no member named 'monostate' in namespace 'std'
/libs/internal/include/launchdarkly/async/promise.hpp:223:58 [clang-diagnostic-error]: /libs/internal/include/launchdarkly/async/promise.hpp#L223
no type named 'monostate' in namespace 'std'
cpp-linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
/libs/internal/include/launchdarkly/async/promise.hpp:194:29 [bugprone-move-forwarding-reference]: /libs/internal/include/launchdarkly/async/promise.hpp#L194
forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead
/libs/internal/include/launchdarkly/async/promise.hpp:177:37 [bugprone-move-forwarding-reference]: /libs/internal/include/launchdarkly/async/promise.hpp#L177
forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead
/libs/internal/include/launchdarkly/async/promise.hpp:164:62 [performance-unnecessary-value-param]: /libs/internal/include/launchdarkly/async/promise.hpp#L164
the parameter 'executor' is copied for each invocation but only used as a const reference; consider making it a const reference
/libs/internal/include/launchdarkly/async/promise.hpp:61:19 [performance-noexcept-move-constructor]: /libs/internal/include/launchdarkly/async/promise.hpp#L61
move assignment operators should be marked noexcept
/libs/internal/include/launchdarkly/async/promise.hpp:60:5 [performance-noexcept-move-constructor]: /libs/internal/include/launchdarkly/async/promise.hpp#L60
move constructors should be marked noexcept
/libs/internal/include/launchdarkly/async/promise.hpp:58:22 [readability-identifier-length]: /libs/internal/include/launchdarkly/async/promise.hpp#L58
parameter name 'f' is too short, expected at least 3 characters
/libs/internal/include/launchdarkly/async/promise.hpp:58:5 [bugprone-forwarding-reference-overload]: /libs/internal/include/launchdarkly/async/promise.hpp#L58
constructor accepting a forwarding reference can hide the move constructor
/libs/internal/include/launchdarkly/async/promise.hpp:46:16 [readability-identifier-length]: /libs/internal/include/launchdarkly/async/promise.hpp#L46
parameter name 'f' is too short, expected at least 3 characters
/libs/internal/include/launchdarkly/async/promise.hpp:38:12 [cppcoreguidelines-special-member-functions]: /libs/internal/include/launchdarkly/async/promise.hpp#L38
class 'Base' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
/libs/internal/include/launchdarkly/async/promise.hpp:34:7 [cppcoreguidelines-special-member-functions]: /libs/internal/include/launchdarkly/async/promise.hpp#L34
class 'Continuation' defines a move constructor and a move assignment operator but does not define a destructor, a copy constructor or a copy assignment operator
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0tuffaQAAAAAdcUk3YkKgS6qwHfRkkYgFUEhMMzBFREdFMDQxOABFZGdl
cpp-linter
Failed to restore: Cache service responded with 400