From 9b823ad84d610a8854b15a8c2bd39dea235ebb06 Mon Sep 17 00:00:00 2001 From: Jethro Donaldson Date: Wed, 1 Apr 2026 01:40:56 +1300 Subject: [PATCH 1/2] nemo-file-conflict-dialog.c: check for empty dialog->details->entry No call to nemo_file_conflict_dialog_get_new_name() would usually be possible while entry is empty, but can be made to happen, see #3750. --- libnemo-private/nemo-file-conflict-dialog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libnemo-private/nemo-file-conflict-dialog.c b/libnemo-private/nemo-file-conflict-dialog.c index 70b28b746..cf707a909 100644 --- a/libnemo-private/nemo-file-conflict-dialog.c +++ b/libnemo-private/nemo-file-conflict-dialog.c @@ -622,6 +622,7 @@ nemo_file_conflict_dialog_class_init (NemoFileConflictDialogClass *klass) char * nemo_file_conflict_dialog_get_new_name (NemoFileConflictDialog *dialog) { + g_assert(gtk_entry_get_text_length (GTK_ENTRY (dialog->details->entry)) > 0); return g_strdup (gtk_entry_get_text (GTK_ENTRY (dialog->details->entry))); } From 26030df4de01e6d9b86f03c7dd52a86adadd0566 Mon Sep 17 00:00:00 2001 From: Jethro Donaldson Date: Wed, 1 Apr 2026 01:42:17 +1300 Subject: [PATCH 2/2] nemo-file-conflict-dialog.c: hide details->rename_button initially Ensure the existing attempt to hide details->rename_button is not undone by the call to gtk_widget_show_all() at the end of the nemo_file_conflict_dialog_init() function. Fixes #3750. --- libnemo-private/nemo-file-conflict-dialog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libnemo-private/nemo-file-conflict-dialog.c b/libnemo-private/nemo-file-conflict-dialog.c index cf707a909..a71974579 100644 --- a/libnemo-private/nemo-file-conflict-dialog.c +++ b/libnemo-private/nemo-file-conflict-dialog.c @@ -566,6 +566,7 @@ nemo_file_conflict_dialog_init (NemoFileConflictDialog *fcd) _("Re_name"), CONFLICT_RESPONSE_RENAME); gtk_widget_hide (details->rename_button); + gtk_widget_set_no_show_all(details->rename_button, TRUE); details->replace_button = gtk_dialog_add_button (dialog,