Skip to content

Commit 185f0f3

Browse files
committed
Address PR review comments: fix integration test description, add license header requirement, unify container name
1 parent ecaf973 commit 185f0f3

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.github/agents/pr-verification.agent.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,11 @@ Create a single Java file that resembles a **minimal real application**:
134134
- Add comments explaining the customer scenario and why this workflow previously failed.
135135
- Keep it minimal — only the code needed to reproduce the scenario.
136136
- The sample must be compilable with `./gradlew build`.
137+
- Every generated Java file must include the standard Microsoft MIT license header at the top:
138+
```java
139+
// Copyright (c) Microsoft Corporation.
140+
// Licensed under the MIT License.
141+
```
137142

138143
### Example Skeleton
139144

.github/copilot-instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ definitions.
116116
## Testing Approach
117117

118118
- **Unit tests:** JUnit-based, in `client/src/test/`
119-
- **Integration tests:** Run against DTS emulator, in `client/src/test/` (integrationTest source set)
119+
- **Integration tests:** JUnit tests in `client/src/test/` that run against the DTS emulator via the dedicated Gradle `integrationTest` task (uses JUnit tags to select tests)
120120
- **End-to-end tests:** Run against Azure Functions host, in `endtoendtests/`
121121
- **Static analysis:** SpotBugs for bug detection
122122

.github/workflows/pr-verification.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949

5050
- name: 🐳 Start DTS Emulator
5151
run: |
52-
docker run --name dts-emulator -d --rm -p 4001:8080 \
52+
docker run --name durabletask-emulator -d --rm -p 4001:8080 \
5353
mcr.microsoft.com/dts/dts-emulator:latest
5454
5555
echo "Waiting for emulator to be ready..."
@@ -130,4 +130,4 @@ jobs:
130130

131131
- name: 🧹 Stop DTS Emulator
132132
if: always()
133-
run: docker stop dts-emulator 2>/dev/null || true
133+
run: docker stop durabletask-emulator 2>/dev/null || true

0 commit comments

Comments
 (0)