fail fast

YunchuWang · YunchuWang · commit fe06a41ba39e · 2025-03-26T14:10:12.000-07:00
diff --git a/.github/workflows/build-validation.yml b/.github/workflows/build-validation.yml
@@ -46,7 +46,7 @@ jobs:
     
     - name: Run SpotBugs
       run: ./gradlew spotbugsMain spotbugsTest
-      continue-on-error: true
+      continue-on-error: false
       
     - name: Upload SpotBugs reports
       uses: actions/upload-artifact@v4
diff --git a/azurefunctions/build.gradle b/azurefunctions/build.gradle
@@ -91,7 +91,7 @@ spotbugs {
     toolVersion = '4.9.2'
     effort = 'max'
     reportLevel = 'medium'
-    ignoreFailures = true
+    ignoreFailures = false
     excludeFilter = file('spotbugs-exclude.xml')
 }
 
diff --git a/azuremanaged/build.gradle b/azuremanaged/build.gradle
@@ -119,7 +119,7 @@ spotbugs {
     toolVersion = '4.9.2'
     effort = 'max'
     reportLevel = 'medium'
-    ignoreFailures = true
+    ignoreFailures = false
     excludeFilter = file('spotbugs-exclude.xml')
 }
 
diff --git a/client/build.gradle b/client/build.gradle
@@ -187,7 +187,7 @@ spotbugs {
     toolVersion = '4.9.2'
     effort = 'max'
     reportLevel = 'medium'
-    ignoreFailures = true
+    ignoreFailures = false
     excludeFilter = file('spotbugs-exclude.xml')
 }
 
diff --git a/internal/durabletask-protobuf/PROTO_SOURCE_COMMIT_HASH b/internal/durabletask-protobuf/PROTO_SOURCE_COMMIT_HASH
@@ -1 +1 @@
-b1e9c96572a9fa0b81829fe0e976cd39de91877e
+c85ef11430ff8e10e21105abb545b0803bb86c66
diff --git a/internal/durabletask-protobuf/protos/orchestrator_service.proto b/internal/durabletask-protobuf/protos/orchestrator_service.proto
@@ -463,6 +463,7 @@ message PurgeInstanceFilter {
 
 message PurgeInstancesResponse {
     int32 deletedInstanceCount = 1;
+    google.protobuf.BoolValue isComplete = 2;
 }
 
 message CreateTaskHubRequest {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ spotbugs {`
`91`	`91`	`toolVersion = '4.9.2'`
`92`	`92`	`effort = 'max'`
`93`	`93`	`reportLevel = 'medium'`
`94`		`- ignoreFailures = true`
	`94`	`+ ignoreFailures = false`
`95`	`95`	`excludeFilter = file('spotbugs-exclude.xml')`
`96`	`96`	`}`
`97`	`97`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ spotbugs {`
`119`	`119`	`toolVersion = '4.9.2'`
`120`	`120`	`effort = 'max'`
`121`	`121`	`reportLevel = 'medium'`
`122`		`- ignoreFailures = true`
	`122`	`+ ignoreFailures = false`
`123`	`123`	`excludeFilter = file('spotbugs-exclude.xml')`
`124`	`124`	`}`
`125`	`125`
Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ spotbugs {`
`187`	`187`	`toolVersion = '4.9.2'`
`188`	`188`	`effort = 'max'`
`189`	`189`	`reportLevel = 'medium'`
`190`		`- ignoreFailures = true`
	`190`	`+ ignoreFailures = false`
`191`	`191`	`excludeFilter = file('spotbugs-exclude.xml')`
`192`	`192`	`}`
`193`	`193`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-b1e9c96572a9fa0b81829fe0e976cd39de91877e`
	`1`	`+c85ef11430ff8e10e21105abb545b0803bb86c66`
Original file line number	Diff line number	Diff line change
`@@ -463,6 +463,7 @@ message PurgeInstanceFilter {`
`463`	`463`
`464`	`464`	`message PurgeInstancesResponse {`
`465`	`465`	`int32 deletedInstanceCount = 1;`
	`466`	`+ google.protobuf.BoolValue isComplete = 2;`
`466`	`467`	`}`
`467`	`468`
`468`	`469`	`message CreateTaskHubRequest {`