From e4b84ffd1120e52acf805004b83d32b875b84655 Mon Sep 17 00:00:00 2001 From: Steven Malis <137308034+smalis-msft@users.noreply.github.com> Date: Wed, 4 Mar 2026 11:49:54 -0500 Subject: [PATCH] Make CoreDumpBuilder::new not generic This allows type inference to work better, no longer needing these types specified by the caller. --- elfcore/src/coredump.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/elfcore/src/coredump.rs b/elfcore/src/coredump.rs index 047ebb8..b144330 100644 --- a/elfcore/src/coredump.rs +++ b/elfcore/src/coredump.rs @@ -975,7 +975,7 @@ pub struct CoreDumpBuilder<'a, P: ProcessInfoSource, M: ReadProcessMemory> { memory_reader: M, } -impl<'a, P: ProcessInfoSource, M: ReadProcessMemory> CoreDumpBuilder<'a, P, M> { +impl<'a> CoreDumpBuilder<'a, ProcessView, LinuxProcessMemoryReader> { /// Create a new core dump builder for the process with the provided PID #[cfg(target_os = "linux")] pub fn new( @@ -990,7 +990,9 @@ impl<'a, P: ProcessInfoSource, M: ReadProcessMemory> CoreDumpBuilder<'a, P, M> { memory_reader, }) } +} +impl<'a, P: ProcessInfoSource, M: ReadProcessMemory> CoreDumpBuilder<'a, P, M> { /// Create a new core dump builder from a custom `ProcessInfoSource` pub fn from_source(source: P, memory_reader: M) -> CoreDumpBuilder<'a, P, M> { CoreDumpBuilder {