The ls command does not respect the options in the manifest

[kevinramharak]

I was testing the vsce ls command with my extension and have the following properties set in my package.json:

    "vsce": {
        "dependencies": false
    },
    "files": [
        "dist/extension.min.cjs",
        "assets/**/*",
        "LICENSE"
    ],

Yet when running npx @vscode/vsce ls --tree it outputs:

regex-radar-0.1.0.vsix
├─ LICENSE [1.07 KB]
├─ package.json [7 KB]
├─ ../
│  └─ ../
│     ├─ .gitignore [0.13 KB]
│     ├─ .prettierrc [0.73 KB]
│     ├─ LICENSE [1.07 KB]
│     ├─ README.md [6.34 KB]
│     ├─ package-lock.json [54.05 KB]
│     ├─ package.json [0.83 KB]
│     ├─ tsconfig.json [0.89 KB]
│     ├─ turbo.json [0.55 KB]
│     ├─ .git/
      │  └─ <huge output of files>
│     ├─ .vscode/
│     │  ├─ di.json.code-snippets [0.55 KB]
│     │  ├─ extensions.json [0.1 KB]
│     │  └─ launch.json [3.46 KB]
│     ├─ assets/
│     │  ├─ logo-wide.png [544.75 KB]
│     │  └─ logo.png [424.46 KB]
│     ├─ esbuild/
│     │  ├─ shared-options.js [1.15 KB]
│     │  └─ plugins/
│     │     ├─ problem-matcher-plugin.js [0.64 KB]
│     │     ├─ scm-importer-plugin.js [0.71 KB]
│     │     └─ workspace-packages-plugin.js [1.16 KB]
│     ├─ examples/
│     │  ├─ .gitignore [0.01 KB]
│     │  ├─ examples.js [2.37 KB]
│     │  ├─ examples.ts [2.3 KB]
│     │  ├─ .vscode/
│     │  │  └─ settings.json [0.06 KB]
│     │  └─ node_modules/
│     │     └─ index.js [0.11 KB]
│     ├─ node_modules/
      │  └─ <huge output of files>
├─ assets/
│  └─ icon.png [49.63 KB]
└─ dist/
   └─ extension.min.cjs [776.61 KB]

When I run npx @vscode/vsce ls --tree --no-dependencies it outputs:

regex-radar-0.1.0.vsix
├─ LICENSE [1.07 KB]
├─ package.json [7 KB]
├─ assets/
│  └─ icon.png [49.63 KB]
└─ dist/
   └─ extension.min.cjs [776.61 KB]

Which is also what is the result in the vsix when I run npx @vscode/vsce pack.

My project is a monorepo setup like:

• root
  • apps
    • vscode-extension
      • package.json (this is where vsce is invoked)
  • packages
    • server
    • lsp-types
    • parsers
  • node_modules

I would expect the ls command to:

• respect the vsce field just like publish and pack do.
• even if dependencies is true, I would not expect ls files/folders from the directory where node_modules is located. Especially folders like .vscode which the docs say will always be ignored and .git which makes no sense to ever include.

I think the reason it does not respect the vsce options is because ls is not using patchOptionsWithManifest like package and publish are.

I do not understand why ls is showing other files and folders from the root directory.

[kevinramharak]

Actually running vscde pack with vsce.dependencies: true in my package.json will cause the same issues with not respecting files:

> npx @vscode/vsce pack
 WARNING  This extension consists of 1679 files, out of which 183 are JavaScript files. For performance reasons, you should bundle your extension: https://aka.ms/vscode-bundle-extension. You should also exclude unnecessary files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore.

 INFO  Files included in the VSIX:
regex-radar-0.1.0.vsix
├─ [Content_Types].xml
├─ extension.vsixmanifest
└─ extension/
   ├─ LICENSE.txt [1.07 KB]
   ├─ package.json [6.97 KB]
   ├─ ../
   │  └─ ../
   │     ├─ .gitignore [0.13 KB]
   │     ├─ .prettierrc [0.73 KB]
   │     ├─ LICENSE [1.07 KB]
   │     ├─ README.md [6.34 KB]
   │     ├─ package-lock.json [54.05 KB]
   │     ├─ package.json [0.83 KB]
   │     ├─ tsconfig.json [0.89 KB]
   │     ├─ turbo.json [0.55 KB]
   │     ├─ .git/ (1013 files) [1.6 MB]
   │     ├─ .turbo/ (110 files) [1.15 MB]
   │     ├─ .vscode/ (3 files) [4.11 KB]
   │     ├─ assets/ (2 files) [969.21 KB]
   │     ├─ esbuild/ (4 files) [3.66 KB]
   │     ├─ examples/ (5 files) [4.84 KB]
   │     ├─ node_modules/ (316 files) [1.68 MB]
   │     ├─ notebooks/ (1 file) [2.65 KB]
   │     └─ packages/ (211 files) [4.54 MB]
   ├─ assets/
   │  └─ icon.png [49.63 KB]
   └─ dist/
      └─ extension.min.cjs [776.61 KB]

=> Run vsce ls --tree to see all included files.

 ERROR  invalid relative path: extension/../../turbo.json

[kevinramharak]

Ok the pack issue is a duplicate of #580 so no need to create an issue for that, but the ls issue still stands, will be fixed with #1214.