From 610f05fec7eb3b7906dd2a5ecf930293a8bfb9fe Mon Sep 17 00:00:00 2001 From: Ernst von Oelsen Date: Sat, 12 Apr 2025 16:41:54 +0200 Subject: [PATCH 1/2] Add global flag '--help/-h'. --- pkg/app/master/cli_test.go | 22 ++++++++++++++++++++++ pkg/app/master/command/cliflags.go | 7 +++++++ 2 files changed, 29 insertions(+) create mode 100644 pkg/app/master/cli_test.go diff --git a/pkg/app/master/cli_test.go b/pkg/app/master/cli_test.go new file mode 100644 index 00000000..50291608 --- /dev/null +++ b/pkg/app/master/cli_test.go @@ -0,0 +1,22 @@ +package app + +import ( + "github.com/mintoolkit/mint/pkg/app/master/signals" + "github.com/stretchr/testify/require" + "testing" +) + +func TestCLI(t *testing.T) { + signals.InitHandlers() + cli := newCLI() + + runArgs := [][]string{ + {"mint", "--version"}, + {"mint", "-v"}, + {"mint", "help"}, + {"mint", "-h"}, + } + for _, args := range runArgs { + require.NoError(t, cli.Run(args)) + } +} diff --git a/pkg/app/master/command/cliflags.go b/pkg/app/master/command/cliflags.go index 842d908d..6ad4b60e 100644 --- a/pkg/app/master/command/cliflags.go +++ b/pkg/app/master/command/cliflags.go @@ -38,6 +38,7 @@ const ( FlagCRTIOInactivityTimeout = "crt-io-inactivity-timeout" FlagCRTSaveInactivityTimeout = "crt-save-inactivity-timeout" FlagCRTCopyInactivityTimeout = "crt-copy-inactivity-timeout" + FlagHelp = "help" ) const ( @@ -71,6 +72,7 @@ const ( FlagCRTIOInactivityTimeoutUsage = "CRT I/O general inactivity timeout" FlagCRTSaveInactivityTimeoutUsage = "CRT save image operation inactivity timeout (overrides the general I/O timeout)" FlagCRTCopyInactivityTimeoutUsage = "CRT copy from container operation inactivity timeout (overrides the general I/O timeout)" + FlagHelpUsage = "Show help info" ) // Shared command flag names @@ -433,6 +435,11 @@ func GlobalFlags() []cli.Flag { Usage: FlagCRTCopyInactivityTimeoutUsage, EnvVars: []string{"DSLIM_CRT_COPY_INACTIVITY_TIMEOUT"}, }, + &cli.BoolFlag{ + Name: FlagHelp, + Aliases: []string{"h"}, + Usage: FlagHelpUsage, + }, &cli.StringFlag{ Name: FlagStatePath, Value: "", From 49e103177db3c41e6dfb477bdd4a9d84614f2e01 Mon Sep 17 00:00:00 2001 From: Ernst von Oelsen Date: Fri, 6 Feb 2026 12:22:24 +0100 Subject: [PATCH 2/2] Remove ambigous -v flag and properly test --help. --- pkg/app/master/cli_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/app/master/cli_test.go b/pkg/app/master/cli_test.go index 50291608..f15d0c7a 100644 --- a/pkg/app/master/cli_test.go +++ b/pkg/app/master/cli_test.go @@ -12,8 +12,8 @@ func TestCLI(t *testing.T) { runArgs := [][]string{ {"mint", "--version"}, - {"mint", "-v"}, {"mint", "help"}, + {"mint", "--help"}, {"mint", "-h"}, } for _, args := range runArgs {