Skip to content

keepalive calls session.Close for all errors including 404 #897

@BadBastion

Description

@BadBastion

logger.Error("keepalive ping failed; closing session", "error", err)

This includes method-not-found 404s. This means a server that's perfectly healthy but doesn't implement ping gets its session killed. Since ping is optional some servers don't implement it and make keepalives hard/unsafe to enable globally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions