Skip to content

Commit f840749

Browse files
committed
move vale validation in existing job
1 parent f467b0d commit f840749

4 files changed

Lines changed: 18 additions & 29 deletions

File tree

.github/workflows/ci.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
os: [macos-latest, windows-latest, ubuntu-latest]
3030
permissions:
3131
contents: read
32+
pull-requests: write
3233
steps:
3334
- run: echo '${{ github.actor }}'
3435
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -43,6 +44,19 @@ jobs:
4344
node-version: '22.18.0'
4445
cache: 'pnpm' # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies
4546
- run: pnpm install
47+
- name: Vale
48+
uses: vale-cli/vale-action@d89dee975228ae261d22c15adcd03578634d429c # v2.1.1
49+
if: ${{ matrix.os == 'ubuntu-latest' }}
50+
continue-on-error: true # GitHub Action flag needed until https://github.com/errata-ai/vale-action/issues/89 is fixed
51+
with:
52+
# Errors should be more visible
53+
fail_on_error: true
54+
# The other reports don't work, not really https://github.com/reviewdog/reviewdog#reporters
55+
reporter: github-pr-check
56+
# Required, set by GitHub actions automatically:
57+
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
58+
token: ${{secrets.GITHUB_TOKEN}}
59+
version: 3.12.0
4660
- name: Cache Next.js build
4761
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
4862
with:

.github/workflows/vale-action.yml

Lines changed: 0 additions & 25 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"eslint:ci": "eslint . --report-unused-disable-directives --max-warnings 0",
4242
"stylelint": "stylelint --reportInvalidScopeDisables --reportNeedlessDisables \"docs/**/*.?(c|m)[jt]s?(x)\" \"docs/**/*.css\" --ignore-path .lintignore",
4343
"markdownlint": "markdownlint-cli2 \"**/*.md\"",
44-
"valelint": "pnpm dlx --package @vvago/vale vale sync && git ls-files | grep -E \"\\.(md|mdx)$\" | xargs pnpm dlx --package @vvago/vale vale --filter='.Level==\"error\"'",
44+
"valelint": "pnpm dlx --package @vvago/vale@3.12.0 vale sync && git ls-files | grep -E \"\\.(md|mdx)$\" | xargs pnpm dlx --package @vvago/vale@3.12.0 vale --filter='.Level==\"error\"'",
4545
"prettier": "pretty-quick --ignore-path .lintignore --branch master",
4646
"prettier:all": "prettier --write . --ignore-path .lintignore",
4747
"size:snapshot": "pnpm -F ./test/bundle-size check",

pnpm-lock.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)