Skip to content

Bug: Review requests not dismissed when required reviews satisfied #72

@drewdunsford

Description

@drewdunsford

NOTE: Heavily edited from original Issue submission (see Edits)

When an file has an OR rule for multiple codeowner groups, the system does not dismiss unneeded reviewer groups when one of the codeowners groups is satisfied.

  1. File 1 requires team A or B to approve
  2. A member of team A approves, satisfying the required reviews for File 1
  3. Team B still requested for review

Expected Behavior:
Since the rule A or B is satisfied by A approval, the requested review for B is no longer necessary, and ought to be dismissed

Actual Behavior:
The system keeps the review request for group B active, even though it's already been satisfied.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions