From 6999919bde5e7c93af9a56ebdbf53cd8c1f8b63b Mon Sep 17 00:00:00 2001 From: Josh Date: Fri, 24 May 2024 11:39:35 -0400 Subject: [PATCH 1/2] fix(autoApproveSync): Cleanup triggering by labels * Don't bother to trigger on `opened since we won't have a label until PR is `labeled` * Don't trigger every time *any* label is added - This was causing overlapping requests that were multiplied by how many labels are attached to a given PR Signed-off-by: Josh --- config/workflows/autoApproveSync.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/config/workflows/autoApproveSync.yml b/config/workflows/autoApproveSync.yml index 4beff67..80b10ca 100644 --- a/config/workflows/autoApproveSync.yml +++ b/config/workflows/autoApproveSync.yml @@ -11,7 +11,6 @@ on: - master - main types: - - opened - reopened - synchronize - labeled @@ -27,7 +26,7 @@ jobs: auto-approve: name: Auto approve sync runs-on: ubuntu-latest - if: ${{ contains(github.event.pull_request.labels.*.name, 'sync') && github.actor == 'nextcloud-android-bot' }} + if: ${{ github.event.pull_request.label.name == 'sync' && github.actor == 'nextcloud-android-bot' }} steps: - uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0 with: From 029a1be066cf136154af8ff93b6e921c51c32877 Mon Sep 17 00:00:00 2001 From: Josh Date: Fri, 24 May 2024 11:47:36 -0400 Subject: [PATCH 2/2] Update autoApproveSync.yml Signed-off-by: Josh --- config/workflows/autoApproveSync.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/workflows/autoApproveSync.yml b/config/workflows/autoApproveSync.yml index 80b10ca..f2b7657 100644 --- a/config/workflows/autoApproveSync.yml +++ b/config/workflows/autoApproveSync.yml @@ -26,7 +26,7 @@ jobs: auto-approve: name: Auto approve sync runs-on: ubuntu-latest - if: ${{ github.event.pull_request.label.name == 'sync' && github.actor == 'nextcloud-android-bot' }} + if: ${{ github.event.label.name == 'sync' && github.actor == 'nextcloud-android-bot' }} steps: - uses: hmarr/auto-approve-action@f0939ea97e9205ef24d872e76833fa908a770363 # v4.0.0 with: