Hitting the save button too quickly doesn't save the changes

[max65482]

Describe the bug

When editing a contact, changes are not saved when the save button is pushed too quickly.

Steps to reproduce

1. Open an existing contact.
2. Edit a field (e.g. phone number).
3. Hit "Save" instantly (be fast!).
4. Reload the page.

Expected behavior

The field reflects the edit.

Actual behavior

The edited field has the original state before the edits.

timing_bug.mp4

Contact version

7.3.10 and latest master

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response

[hamza221]

I was not able to reproduce, can you please share a screencast ?

[max65482]

Screencast added above.
It's definitely a sub-second timing issue. No huge impact, so I could live with a don't-fix decision.

[SebastianKrupinski]

That looks like a slow reactivity in vue or a debounce

[max65482]

Yep, found it. It's this debounce currently set to 500 ms. Half a second could be a bit long for busy caffeine-intoxicated people. Maybe 100 ms is better. But it's a trade-off...

contacts/src/mixins/PropertyMixin.js

Lines 114 to 117 in 9b9a85b

	updateValue: debounce(function(e) {
	// https://vuejs.org/v2/guide/components-custom-events.html#sync-Modifier
	this.$emit('update:value', this.localValue)
	}, 500),

[max65482]

#5010 is a proposal for 100 ms.

[SebastianKrupinski]

@max65482 can we split the difference? I agree the original 500ms is to long, but the 100ms is to short I think, how about 250/200?

[max65482]

Ok, set it to 250 ms in the PR.