fix: Resolved Xcode code warnings.

Unused result values, mutable variables which never are altered, unused declarations, and variables being written to but never read.

Signed-off-by: Iva Horn <iva.horn@nextcloud.com>

Author: i2h3

Sources/NextcloudFileProviderKit/Database/FilesDatabaseManager.swift

@@ -260,7 +260,7 @@ public final class FilesDatabaseManager: Sendable {
 
         for existingMetadata in existingMetadatas {
             guard !updatedMetadatas.contains(where: { $0.ocId == existingMetadata.ocId }),
-                  var metadataToDelete = itemMetadatas.where({ $0.ocId == existingMetadata.ocId }).first
+                  let metadataToDelete = itemMetadatas.where({ $0.ocId == existingMetadata.ocId }).first
             else { continue }
 
             deletedMetadatas.append(metadataToDelete)
@@ -627,7 +627,7 @@ public final class FilesDatabaseManager: Sendable {
                     }
             }
 
-        var handledDeleteOcIds = Set(deleted.map(\.ocId))
+        let handledDeleteOcIds = Set(deleted.map(\.ocId))
 
         deleted
             .map { // assemble remote location

Sources/NextcloudFileProviderKit/Enumeration/Enumerator.swift

@@ -161,23 +161,15 @@ public class Enumerator: NSObject, NSFileProviderEnumerator {
         logger.debug("Enumerating page: \(String(data: page.rawValue, encoding: .utf8) ?? "")", [.account: account.ncKitAccount, .url: serverUrl])
 
         Task {
-            var providedPage: NSFileProviderPage? = nil // Used for pagination token sent to server
             // Do not pass in the NSFileProviderPage default pages, these are not valid Nextcloud
             // pagination tokens
-            var pageIndex = 0
             var pageTotal: Int? = nil
 
             if page != NSFileProviderPage.initialPageSortedByName as NSFileProviderPage, page != NSFileProviderPage.initialPageSortedByDate as NSFileProviderPage {
                 if let enumPageResponse = try? JSONDecoder().decode(EnumeratorPageResponse.self, from: page.rawValue) {
-                    if let token = enumPageResponse.token?.data(using: .utf8) {
-                        providedPage = NSFileProviderPage(token)
-                    }
-
                     if let total = enumPageResponse.total {
                         pageTotal = total
                     }
-
-                    pageIndex = enumPageResponse.index
                 } else {
                     logger.error("Could not parse page")
                 }

Sources/NextcloudFileProviderKit/Enumeration/EnumeratorPageResponse.swift

@@ -30,7 +30,5 @@ struct EnumeratorPageResponse: Sendable, Codable {
         } else {
             total = nil
         }
-
-        let totalString = total != nil ? String(total ?? -1) : "nil"
     }
 }

Sources/NextcloudFileProviderKit/Item/Item+KeepDownloaded.swift

@@ -9,7 +9,7 @@ public extension Item {
     }
 
     func set(keepDownloaded: Bool, domain: NSFileProviderDomain) async throws {
-        try dbManager.set(keepDownloaded: keepDownloaded, for: metadata)
+        _ = try dbManager.set(keepDownloaded: keepDownloaded, for: metadata)
 
         guard let manager = NSFileProviderManager(for: domain) else {
             if #available(iOS 17.1, macOS 14.1, *) {

Sources/NextcloudFileProviderKit/Item/Item.swift

@@ -378,7 +378,7 @@ public class Item: NSObject, NSFileProviderItem {
             return nil
         }
 
-        var parentItemIdentifier: NSFileProviderItemIdentifier? = if metadata.isTrashed {
+        let parentItemIdentifier: NSFileProviderItemIdentifier? = if metadata.isTrashed {
             .trashContainer
         } else {
             await dbManager.parentItemIdentifierWithRemoteFallback(