From 354d429a9d70d837a167ba216a581c451b7b6913 Mon Sep 17 00:00:00 2001 From: Git'Fellow <12234510+solracsf@users.noreply.github.com> Date: Tue, 31 Mar 2026 11:01:34 +0200 Subject: [PATCH] fix: update email button text to 'Open shared item' Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> --- apps/sharebymail/lib/ShareByMailProvider.php | 4 ++-- apps/sharebymail/tests/ShareByMailProviderTest.php | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/sharebymail/lib/ShareByMailProvider.php b/apps/sharebymail/lib/ShareByMailProvider.php index 27203cb26a722..8906db0084fe8 100644 --- a/apps/sharebymail/lib/ShareByMailProvider.php +++ b/apps/sharebymail/lib/ShareByMailProvider.php @@ -359,7 +359,7 @@ protected function sendEmail(IShare $share, array $emails): void { } $emailTemplate->addBodyButton( - $this->l->t('Open %s', [$filename]), + $this->l->t('Open shared item'), $link ); @@ -533,7 +533,7 @@ protected function sendNote(IShare $share): void { $link = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.showShare', ['token' => $share->getToken()]); $emailTemplate->addBodyButton( - $this->l->t('Open %s', [$filename]), + $this->l->t('Open shared item'), $link ); diff --git a/apps/sharebymail/tests/ShareByMailProviderTest.php b/apps/sharebymail/tests/ShareByMailProviderTest.php index 66afbd3335bcd..aaa608cc44645 100644 --- a/apps/sharebymail/tests/ShareByMailProviderTest.php +++ b/apps/sharebymail/tests/ShareByMailProviderTest.php @@ -1309,7 +1309,7 @@ public function testSendMailNotificationWithSameUserAndUserEmail(): void { ->expects($this->once()) ->method('addBodyButton') ->with( - 'Open file.txt', + 'Open shared item', 'https://example.com/file.txt' ); $message @@ -1428,7 +1428,7 @@ public function testSendMailNotificationWithSameUserAndUserEmailAndNote(): void ->expects($this->once()) ->method('addBodyButton') ->with( - 'Open file.txt', + 'Open shared item', 'https://example.com/file.txt' ); $message @@ -1552,7 +1552,7 @@ public function testSendMailNotificationWithSameUserAndUserEmailAndExpiration(): ->expects($this->once()) ->method('addBodyButton') ->with( - 'Open file.txt', + 'Open shared item', 'https://example.com/file.txt' ); $message @@ -1656,7 +1656,7 @@ public function testSendMailNotificationWithDifferentUserAndNoUserEmail(): void ->expects($this->once()) ->method('addBodyButton') ->with( - 'Open file.txt', + 'Open shared item', 'https://example.com/file.txt' ); $message @@ -1750,7 +1750,7 @@ public function testSendMailNotificationWithSameUserAndUserEmailAndReplyToDesact ->expects($this->once()) ->method('addBodyButton') ->with( - 'Open file.txt', + 'Open shared item', 'https://example.com/file.txt' ); $message @@ -1848,7 +1848,7 @@ public function testSendMailNotificationWithDifferentUserAndNoUserEmailAndReplyT ->expects($this->once()) ->method('addBodyButton') ->with( - 'Open file.txt', + 'Open shared item', 'https://example.com/file.txt' ); $message