readline: fix setupHistoryManager initialization order and stream handling

- Reorder initialization: assign this.input before setupHistoryManager()
- Preserve original options object for proper history manager initialization
- Fix REPL.setupHistory() callback invocation logic
- Fix stream event handling in repl persistent history test

Fixes: #61526

Author: Zohaibarif69

lib/internal/readline/interface.js

@@ -172,9 +172,11 @@ function InterfaceConstructor(input, output, completer, terminal) {
   let crlfDelay;
   let prompt = '> ';
   let signal;
+  let inputOptions;
 
   if (input?.input) {
     // An options object was given
+    inputOptions = input;
     output = input.output;
     completer = input.completer;
     terminal = input.terminal;
@@ -233,7 +235,7 @@ function InterfaceConstructor(input, output, completer, terminal) {
   this[kSubstringSearch] = null;
   this.output = output;
   this.input = input;
-  this.setupHistoryManager(input);
+  this.setupHistoryManager(inputOptions || input);
   this[kUndoStack] = [];
   this[kRedoStack] = [];
   this[kPreviousCursorCols] = -1;
@@ -384,13 +386,20 @@ class Interface extends InterfaceConstructor {
   setupHistoryManager(options) {
     this.historyManager = new ReplHistory(this, options);
 
-    // Only initialize REPL history when createInterface()
-  // was called with an options object (options.input).
-  // This prevents accidental REPL history init when
-  // createInterface(input) is used.
-  if (options?.input && typeof options.onHistoryFileLoaded === 'function') {
-    this.historyManager.initialize(options.onHistoryFileLoaded);
-  }
+    // Only initialize REPL history when called from REPL.setupHistory(),
+    // not from the readline constructor. 
+    // Constructor passes: stream OR { input: stream, output: stream, ... }
+    // setupHistory passes: { filePath: ..., size: ..., onHistoryFileLoaded: ... }
+    // Detect constructor calls by checking for stream.on() or options.input
+    if (options && typeof options === 'object') {
+      const isStream = typeof options.on === 'function';
+      const hasInputProperty = options.input !== undefined;
+      const isFromConstructor = isStream || hasInputProperty;
+      
+      if (!isFromConstructor && typeof options.onHistoryFileLoaded === 'function') {
+        this.historyManager.initialize(options.onHistoryFileLoaded);
+      }
+    }
 
     ObjectDefineProperty(this, 'history', {
       __proto__: null, configurable: true, enumerable: true,

test/parallel/test-readline-history-init-order.js

@@ -1,18 +1,48 @@
 'use strict';
 
-const assert = require('assert');
+const common = require('../common');
 const readline = require('readline');
 const { PassThrough } = require('stream');
 
-assert.doesNotThrow(() => {
-  const input = new PassThrough();
+// Regression test for https://github.com/nodejs/node/issues/61526
+// This test ensures that createInterface() doesn't crash when input
+// has an onHistoryFileLoaded property (e.g., from a Proxy or jest.mock)
 
-  // This simulates the condition that previously caused
-  // accidental REPL history initialization.
+// Test case 1: options object with onHistoryFileLoaded as function
+{
+  const input = new PassThrough();
   input.onHistoryFileLoaded = () => {};
 
   readline.createInterface({
     input,
     output: new PassThrough()
   });
-});
+}
+
+// Test case 2: options object without onHistoryFileLoaded
+{
+  const input = new PassThrough();
+  readline.createInterface({
+    input,
+    output: new PassThrough()
+  });
+}
+
+// Test case 3: options object with onHistoryFileLoaded as non-function
+{
+  const input = new PassThrough();
+  input.onHistoryFileLoaded = { some: 'object' };
+
+  readline.createInterface({
+    input,
+    output: new PassThrough()
+  });
+}
+
+// Test case 4: direct stream with onHistoryFileLoaded (original bug scenario)
+{
+  const input = new PassThrough();
+  input.onHistoryFileLoaded = () => {};
+
+  readline.createInterface(input, new PassThrough());
+}

test/parallel/test-repl-persistent-history.js

@@ -183,8 +183,10 @@ function cleanupTmpFile() {
 }
 
 // Copy our fixture to the tmp directory
+const writeStream = fs.createWriteStream(historyPath);
 fs.createReadStream(historyFixturePath)
-  .pipe(fs.createWriteStream(historyPath)).on('unpipe', () => runTest());
+  .pipe(writeStream);
+writeStream.on('finish', () => runTest());
 
 const runTestWrap = common.mustCall(runTest, numtests);