update sqlite limits to allow null for resetting to compile-time maximum

Author: mertcanaltin

doc/api/sqlite.md

@@ -479,12 +479,17 @@ console.log(db.limits.length);
 
 // Set a new limit
 db.limits.sqlLength = 100000;
+
+// Reset a limit to its compile-time maximum
+db.limits.sqlLength = null;
 ```
 
 Available properties: `length`, `sqlLength`, `column`, `exprDepth`,
 `compoundSelect`, `vdbeOp`, `functionArg`, `attach`, `likePatternLength`,
 `variableNumber`, `triggerDepth`.
 
+Setting a property to `null` resets the limit to its compile-time maximum value.
+
 ### `database.open()`
 
 <!-- YAML

src/node_sqlite.cc

@@ -14,6 +14,7 @@
 
 #include <array>
 #include <cinttypes>
+#include <climits>
 
 namespace node {
 namespace sqlite {
@@ -793,16 +794,21 @@ Intercepted DatabaseSyncLimits::LimitsSetter(
     return Intercepted::kYes;
   }
 
-  if (!value->IsInt32()) {
-    THROW_ERR_INVALID_ARG_TYPE(isolate, "Limit value must be an integer.");
-    return Intercepted::kYes;
-  }
-
-  int new_value = value.As<Int32>()->Value();
+  int new_value;
 
-  // Validate non-negative
-  if (new_value < 0) {
-    THROW_ERR_OUT_OF_RANGE(isolate, "Limit value must be non-negative.");
+  if (value->IsNull()) {
+    // null resets the limit to the compile-time maximum
+    new_value = INT_MAX;
+  } else if (value->IsInt32()) {
+    new_value = value.As<Int32>()->Value();
+    // Validate non-negative
+    if (new_value < 0) {
+      THROW_ERR_OUT_OF_RANGE(isolate, "Limit value must be non-negative.");
+      return Intercepted::kYes;
+    }
+  } else {
+    THROW_ERR_INVALID_ARG_TYPE(
+        isolate, "Limit value must be an integer or null.");
     return Intercepted::kYes;
   }
 

test/parallel/test-sqlite-limits.js

@@ -80,13 +80,26 @@ suite('DatabaseSync limits', () => {
     t.assert.strictEqual(db.limits.column, 50);
   });
 
+  test('null resets limit to maximum', (t) => {
+    const db = new DatabaseSync(':memory:');
+    const originalLength = db.limits.length;
+
+    // Set to a lower value
+    db.limits.length = 100;
+    t.assert.strictEqual(db.limits.length, 100);
+
+    // Reset to maximum using null
+    db.limits.length = null;
+    t.assert.strictEqual(db.limits.length, originalLength);
+  });
+
   test('throws on invalid argument type', (t) => {
     const db = new DatabaseSync(':memory:');
     t.assert.throws(() => {
       db.limits.length = 'invalid';
     }, {
       name: 'TypeError',
-      message: /Limit value must be an integer/,
+      message: /Limit value must be an integer or null/,
     });
   });