From 154a246ad7dd253488f096a62cd46b00d8c87249 Mon Sep 17 00:00:00 2001
From: MaxChang3 <36927158+maxchang3@users.noreply.github.com>
Date: Thu, 19 Mar 2026 00:33:30 +0800
Subject: [PATCH] fix: localize warning messages

---
 app/components/Package/SkillsModal.vue |  7 ++++---
 app/components/diff/SidebarPanel.vue   |  5 ++++-
 app/composables/useI18nWarning.ts      |  7 +++++++
 i18n/locales/en.json                   |  9 ++++++++-
 i18n/locales/zh-CN.json                |  6 +++++-
 i18n/schema.json                       | 21 +++++++++++++++++++++
 server/utils/compare.ts                |  8 ++++++--
 server/utils/skills.ts                 | 10 ++++++----
 shared/types/compare.ts                |  4 +++-
 shared/types/skills.ts                 |  9 +++------
 shared/types/warning.ts                |  6 ++++++
 test/nuxt/a11y.spec.ts                 |  4 +++-
 12 files changed, 76 insertions(+), 20 deletions(-)
 create mode 100644 app/composables/useI18nWarning.ts
 create mode 100644 shared/types/warning.ts

diff --git a/app/components/Package/SkillsModal.vue b/app/components/Package/SkillsModal.vue
index 65d1fb57ac..c868c7a0f8 100644
--- a/app/components/Package/SkillsModal.vue
+++ b/app/components/Package/SkillsModal.vue
@@ -36,10 +36,11 @@ const installCommand = computed(() => {
 
 const { copied, copy } = useClipboard({ copiedDuring: 2000 })
 const copyCommand = () => installCommand.value && copy(installCommand.value)
+const translateWarning = useI18nWarning()
 
 function getWarningTooltip(skill: SkillListItem): string | undefined {
   if (!skill.warnings?.length) return undefined
-  return skill.warnings.map(w => w.message).join(', ')
+  return skill.warnings.map(translateWarning).join(', ')
 }
 </script>
 
@@ -218,10 +219,10 @@ function getWarningTooltip(skill: SkillListItem): string | undefined {
                     )
                   }}
                 </span>
-                <template v-for="warning in skill.warnings" :key="warning.message">
+                <template v-for="warning in skill.warnings" :key="warning.key">
                   <span class="text-amber-500">
                     <span class="i-lucide:circle-alert size-3 align-[-2px] me-0.5" />{{
-                      warning.message
+                      translateWarning(warning)
                     }}
                   </span>
                 </template>
diff --git a/app/components/diff/SidebarPanel.vue b/app/components/diff/SidebarPanel.vue
index 385a779d20..8c35b6e351 100644
--- a/app/components/diff/SidebarPanel.vue
+++ b/app/components/diff/SidebarPanel.vue
@@ -19,6 +19,7 @@ const fileFilter = defineModel<'all' | 'added' | 'removed' | 'modified'>('fileFi
 
 const sectionOrder = ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies']
 const { t } = useI18n()
+const translateWarning = useI18nWarning()
 const sectionMeta = computed<Record<string, { label: string; icon: string }>>(() => ({
   dependencies: { label: t('compare.dependencies'), icon: 'i-lucide:box' },
   devDependencies: { label: t('compare.dev_dependencies'), icon: 'i-lucide:wrench' },
@@ -112,7 +113,9 @@ function handleFileSelect(file: FileChange) {
         <div class="flex items-start gap-2">
           <span class="i-lucide:triangle-alert w-3.5 h-3.5 text-yellow-500 shrink-0 mt-0.5" />
           <div class="text-3xs text-fg-muted">
-            <p v-for="warning in compare.meta.warnings" :key="warning">{{ warning }}</p>
+            <p v-for="warning in compare.meta.warnings" :key="warning.key">
+              {{ translateWarning(warning) }}
+            </p>
           </div>
         </div>
       </div>
diff --git a/app/composables/useI18nWarning.ts b/app/composables/useI18nWarning.ts
new file mode 100644
index 0000000000..1232feeb6b
--- /dev/null
+++ b/app/composables/useI18nWarning.ts
@@ -0,0 +1,7 @@
+import type { WarningMessage } from '#shared/types/warning'
+
+export function useI18nWarning() {
+  const { t } = useI18n()
+
+  return (warning: WarningMessage): string => t(warning.key, warning.data ?? {})
+}
diff --git a/i18n/locales/en.json b/i18n/locales/en.json
index 7f383e7301..f64431ca82 100644
--- a/i18n/locales/en.json
+++ b/i18n/locales/en.json
@@ -286,6 +286,10 @@
         "refs": "{count} ref | {count} refs",
         "assets": "{count} asset | {count} assets"
       },
+      "warnings": {
+        "no_license": "No license specified",
+        "no_compatibility": "No compatibility info"
+      },
       "view_source": "View source"
     },
     "links": {
@@ -1205,7 +1209,10 @@
     "files_button": "Files",
     "select_file_prompt": "Select a file from the sidebar to view its diff",
     "close_files_panel": "Close files panel",
-    "filter_files_label": "Filter files by change type"
+    "filter_files_label": "Filter files by change type",
+    "warnings": {
+      "files_truncated": "File list truncated to {count} files"
+    }
   },
   "pds": {
     "title": "npmx.social",
diff --git a/i18n/locales/zh-CN.json b/i18n/locales/zh-CN.json
index e6cc3aa6f6..a429ef7739 100644
--- a/i18n/locales/zh-CN.json
+++ b/i18n/locales/zh-CN.json
@@ -272,7 +272,11 @@
         "refs": "{count} 个引用 | {count} 个引用",
         "assets": "{count} 个资源 | {count} 个资源"
       },
-      "view_source": "查看源代码"
+      "view_source": "查看源代码",
+      "warnings": {
+        "no_compatibility": "无兼容性信息",
+        "no_license": "未指定许可证"
+      }
     },
     "links": {
       "repo": "仓库",
diff --git a/i18n/schema.json b/i18n/schema.json
index fe5e5adc93..dada974afc 100644
--- a/i18n/schema.json
+++ b/i18n/schema.json
@@ -862,6 +862,18 @@
               },
               "additionalProperties": false
             },
+            "warnings": {
+              "type": "object",
+              "properties": {
+                "no_license": {
+                  "type": "string"
+                },
+                "no_compatibility": {
+                  "type": "string"
+                }
+              },
+              "additionalProperties": false
+            },
             "view_source": {
               "type": "string"
             }
@@ -3621,6 +3633,15 @@
         },
         "filter_files_label": {
           "type": "string"
+        },
+        "warnings": {
+          "type": "object",
+          "properties": {
+            "files_truncated": {
+              "type": "string"
+            }
+          },
+          "additionalProperties": false
         }
       },
       "additionalProperties": false
diff --git a/server/utils/compare.ts b/server/utils/compare.ts
index a71bd34a8b..2654289aff 100644
--- a/server/utils/compare.ts
+++ b/server/utils/compare.ts
@@ -1,4 +1,5 @@
 import { diff as semverDiff } from 'semver'
+import type { WarningMessage } from '#shared/types/warning'
 
 /**
  * Parse a version range from a URL segment.
@@ -236,9 +237,12 @@ export function buildCompareResponse(
   const fileChanges = compareFileTrees(fromTree, toTree)
   const dependencyChanges = compareDependencies(fromPkg, toPkg)
 
-  const warnings: string[] = []
+  const warnings: WarningMessage[] = []
   if (fileChanges.truncated) {
-    warnings.push(`File list truncated to ${MAX_FILES_COMPARE} files`)
+    warnings.push({
+      key: 'compare.warnings.files_truncated',
+      data: { count: String(MAX_FILES_COMPARE) },
+    })
   }
 
   return {
diff --git a/server/utils/skills.ts b/server/utils/skills.ts
index d9e431ef24..57754f70de 100644
--- a/server/utils/skills.ts
+++ b/server/utils/skills.ts
@@ -1,3 +1,5 @@
+import type { WarningMessage } from '#shared/types/warning'
+
 const MAX_SKILL_FILE_SIZE = 500 * 1024
 
 /**
@@ -154,13 +156,13 @@ export async function fetchSkillContent(
 /**
  * Validate skill frontmatter and return warnings.
  */
-export function validateSkill(frontmatter: SkillFrontmatter): SkillWarning[] {
-  const warnings: SkillWarning[] = []
+export function validateSkill(frontmatter: SkillFrontmatter): WarningMessage[] {
+  const warnings: WarningMessage[] = []
   if (!frontmatter.license) {
-    warnings.push({ type: 'warning', message: 'No license specified' })
+    warnings.push({ key: 'package.skills.warnings.no_license' })
   }
   if (!frontmatter.compatibility) {
-    warnings.push({ type: 'warning', message: 'No compatibility info' })
+    warnings.push({ key: 'package.skills.warnings.no_compatibility' })
   }
   return warnings
 }
diff --git a/shared/types/compare.ts b/shared/types/compare.ts
index bce433b877..4cb926c935 100644
--- a/shared/types/compare.ts
+++ b/shared/types/compare.ts
@@ -1,3 +1,5 @@
+import type { WarningMessage } from '#shared/types/warning'
+
 /** A change in a dependency between versions */
 export interface DependencyChange {
   /** Package name */
@@ -60,7 +62,7 @@ export interface CompareResponse {
     /** Whether file list was truncated due to size */
     truncated?: boolean
     /** Any warnings during comparison */
-    warnings?: string[]
+    warnings?: WarningMessage[]
     /** Time taken to compute (ms) */
     computeTime?: number
   }
diff --git a/shared/types/skills.ts b/shared/types/skills.ts
index eb5a7be92a..f6b9078276 100644
--- a/shared/types/skills.ts
+++ b/shared/types/skills.ts
@@ -1,3 +1,5 @@
+import type { WarningMessage } from '#shared/types/warning'
+
 export interface SkillFrontmatter {
   name: string
   description: string
@@ -6,11 +8,6 @@ export interface SkillFrontmatter {
   metadata?: Record<string, string>
 }
 
-export interface SkillWarning {
-  type: 'error' | 'warning'
-  message: string
-}
-
 export interface SkillFileCounts {
   scripts?: number
   references?: number
@@ -23,7 +20,7 @@ export interface SkillListItem {
   dirName: string
   license?: string
   compatibility?: string
-  warnings?: SkillWarning[]
+  warnings?: WarningMessage[]
   fileCounts?: SkillFileCounts
 }
 
diff --git a/shared/types/warning.ts b/shared/types/warning.ts
new file mode 100644
index 0000000000..c84015108f
--- /dev/null
+++ b/shared/types/warning.ts
@@ -0,0 +1,6 @@
+export interface WarningMessage {
+  /** i18n translation key returned by the API. */
+  key: string
+  /** Named interpolation params for the translation key. */
+  data?: Record<string, string>
+}
diff --git a/test/nuxt/a11y.spec.ts b/test/nuxt/a11y.spec.ts
index 72e3c3bedd..fcb09f0aa9 100644
--- a/test/nuxt/a11y.spec.ts
+++ b/test/nuxt/a11y.spec.ts
@@ -3426,7 +3426,9 @@ describe('component accessibility audits', () => {
     it('should have no accessibility violations with warnings', async () => {
       const compareWithWarnings = {
         ...mockCompare,
-        meta: { warnings: ['Some files were truncated'] },
+        meta: {
+          warnings: [{ key: 'compare.warnings.files_truncated', data: { count: '1000' } }],
+        },
       }
       const component = await mountSuspended(DiffSidebarPanel, {
         props: {