[ADD] estate_property: Safeguard your code with unit tests

Author: abotaha23

estate/__init__.py

@@ -1 +1,2 @@
 from . import models
+from . import tests

estate/models/estate_property.py

@@ -39,8 +39,8 @@ class EstateProperty(models.Model):
     state = fields.Selection(
         selection=[
             ('new', "New"),
-            ('offer received', "Offer Received"),
-            ('offer accepted', "Offer Accepted"),
+            ('offer_received', "Offer Received"),
+            ('offer_accepted', "Offer Accepted"),
             ('sold', "Sold"),
             ('canceled', "Canceled")
         ],
@@ -101,7 +101,7 @@ def _check_price(self):
     def _onchange_receive_offer(self):
         for record in self.filtered(lambda record: record.state == 'new'):
             if record.offer_ids:
-                record.state = 'offer received'
+                record.state = 'offer_received'
 
     @api.onchange('garden')
     def _onchange_garden(self):
@@ -122,12 +122,11 @@ def _unlike_property(self):
 
     def action_mark_as_sold(self):
         for record in self:
-            if record.state != 'canceled':
-                record.state = 'sold'
-            else:
-                raise UserError(self.env._(
-                    "Canceled properties cannot be sold!")
+            if record.state != 'offer_accepted':
+                raise ValidationError(self.env._(
+                    "Only properties with an accepted offer can be sold!")
                 )
+            record.state = 'sold'
 
     def action_mark_as_canceled(self):
         for record in self:

estate/models/estate_property_offer.py

@@ -1,5 +1,5 @@
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
 from dateutil.relativedelta import relativedelta
 
 
@@ -57,6 +57,10 @@ def create(self, vals_list):
         for vals in vals_list:
             related_property = self.env['estate.property'].browse(
                 vals['property_id'])
+            if related_property.state in ['sold', 'canceled', 'offer_accepted']:
+                raise ValidationError(self.env._(
+                    "You cannot make an offer on a sold or canceled property!")
+                )
             for offer in related_property.offer_ids:
                 if offer.price > vals['price']:
                     raise UserError(self.env._("This offer price is lower than the current ones"))
@@ -73,7 +77,7 @@ def action_accept_offer(self):
             record.status = 'accepted'
             record.property_id.buyer_id = record.partner_id
             record.property_id.selling_price = record.price
-            record.property_id.state = 'offer accepted'
+            record.property_id.state = 'offer_accepted'
 
     def action_refuse_offer(self):
         for record in self:

estate/models/res_users.py

@@ -6,4 +6,4 @@ class ResUsers(models.Model):
     _name = 'res.users'
 
     property_ids = fields.One2many('estate.property', 'seller_id',
-                                   domain=['|', ('state', '=', 'new'), ('state', '=', 'offer received')])
+                                   domain=['|', ('state', '=', 'new'), ('state', '=', 'offer_received')])

estate/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_estate

estate/tests/test_estate.py

@@ -0,0 +1,55 @@
+from odoo.tests.common import TransactionCase
+from odoo.exceptions import ValidationError
+from odoo.tests import tagged
+
+
+@tagged('post_install', '-at_install')
+class TestEstate(TransactionCase):
+
+    @classmethod
+    def setUpClass(cls):
+        """This runs once to set up the data for all tests in this class."""
+        super().setUpClass()
+
+        cls.type_id = cls.env.ref('estate.estate_property_type_residential')
+
+        cls.property = cls.env['estate.property'].create({
+            'name': 'Test Villa',
+            'property_type_id': cls.type_id.id,
+            'expected_price': 100000,
+            'state': 'new',
+        })
+
+        cls.buyer = cls.env['res.partner'].create({'name': 'John Doe'})
+
+    def test_01_create_offer_on_restricted_states(self):
+        """Test: Cannot create offer if property is sold or canceled"""
+        for restricted_state in ['sold', 'canceled', 'offer_accepted']:
+            self.property.state = restricted_state
+
+            with self.assertRaises(ValidationError, msg=f"Should fail on {restricted_state}"):
+                self.env['estate.property.offer'].create({
+                    'property_id': self.property.id,
+                    'price': 50000,
+                    'partner_id': self.buyer.id,
+                })
+
+    def test_02_sell_without_accepted_offer(self):
+        """Test: Cannot sell property if no offers are 'accepted'"""
+        self.property.state = 'new'
+        with self.assertRaises(ValidationError):
+            self.property.action_mark_as_sold()
+
+    def test_03_successful_sell_flow(self):
+        """Test: Property marks as 'sold' correctly when an offer is accepted"""
+        offer = self.env['estate.property.offer'].create({
+            'property_id': self.property.id,
+            'price': 90000,
+            'partner_id': self.buyer.id,
+        })
+
+        offer.action_accept_offer()
+
+        self.property.action_mark_as_sold()
+
+        self.assertEqual(self.property.state, 'sold', "The property should be in 'sold' state.")

estate/views/estate_property_views.xml

@@ -3,7 +3,7 @@
         <field name="name">estate.property.list</field>
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
-            <list decoration-success="state == 'offer received' or state == 'offer accepted'" decoration-bf="state == 'offer accepted'" decoration-muted="state == 'sold'">
+            <list decoration-success="state == 'offer_received' or state == 'offer_accepted'" decoration-bf="state == 'offer_accepted'" decoration-muted="state == 'sold'">
                 <field name="name"/>
                 <field name="property_type_id"/>
                 <field name="tag_ids" options="{'color_field': 'color'}" widget="many2many_tags"/>
@@ -23,9 +23,9 @@
         <field name="arch" type="xml">
             <form>
                 <header>
-                    <button name="action_mark_as_sold" type="object" string="SOLD" invisible="state == 'sold' or state == 'canceled'"/>
+                    <button name="action_mark_as_sold" type="object" string="SOLD" invisible="state != 'offer_accepted'"/>
                     <button name="action_mark_as_canceled" type="object" string="CANCEL" invisible="state == 'sold' or state == 'canceled'"/>
-                    <field name="state" widget="statusbar" statusbar_visible="new, offer received, offer accepted, sold"/>
+                    <field name="state" widget="statusbar" statusbar_visible="new, offer_received, offer_accepted, sold"/>
                 </header>
                 <sheet>
                     <group>
@@ -61,7 +61,7 @@
                             </group>
                         </page>
                         <page string="Offers">
-                            <field name="offer_ids" readonly="state == 'offer accepted' 
+                            <field name="offer_ids" readonly="state == 'offer_accepted' 
                             or state == 'sold' or state == 'canceled'"/>
                         </page>
                         <page string="Ohter Info">
@@ -95,7 +95,7 @@
                                 <span style="margin-right: 3px;">Best Price:</span>
                                 <field name="best_offer"/>
                             </div>
-                            <div t-if="record.state.raw_value == 'offer accepted'
+                            <div t-if="record.state.raw_value == 'offer_accepted'
                             or record.state.raw_value == 'sold'">
                                 <span style="margin-right: 3px;">Selling Price:</span>
                                 <field name="selling_price"/>
@@ -123,7 +123,7 @@
                 <field name="expected_price"/>
                 <field name="facades"/>
 
-                <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer received')]"/>
+                <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
                 <filter string="Postcode" name="postcode" context="{'group_by':'postcode'}"/>
             </search>
         </field>