[LINT] estate: correct based on code review

Author: Yetso

estate/__manifest__.py

@@ -18,6 +18,7 @@
     ],
     'application': True,
     'installable': True,
+    'auto_install': True,
     'author': 'Odoo S.A.',
     'license': 'LGPL-3',
 

estate/models/estate_property.py

@@ -6,15 +6,13 @@
 
 
 class EstateProperty(models.Model):
-    _name = "estate.property"
+    _name = 'estate.property'
     _description = "estate property"
 
     name = fields.Char(required=True, string="Title")
     description = fields.Text()
     postcode = fields.Char()
-    date_availability = fields.Date(
-        default=lambda self: fields.Date.add(fields.Date.today(), months=3), copy=False
-    )
+    date_availability = fields.Date(default=lambda self: fields.Date.add(fields.Date.today(), months=3), copy=False)
     expected_price = fields.Float(required=True)
     selling_price = fields.Float(readonly=True, copy=False)
     bedrooms = fields.Integer(default=2)
@@ -23,17 +21,15 @@ class EstateProperty(models.Model):
     garage = fields.Boolean()
     garden = fields.Boolean()
     garden_area = fields.Integer()
-    garden_orientation = fields.Selection(
-        [('north', "North"), ('south', "South"), ('east', "East"), ('west', "West")]
-    )
+    garden_orientation = fields.Selection([('north', "North"), ('south', "South"), ('east', "East"), ('west', "West")])
     total_area = fields.Integer(compute='_compute_total_area')
-    property_type_id = fields.Many2one('estate.property.type', string="House Type")
-    buyer_id = fields.Many2one('res.partner', string="Buyer", copy=False)
-    seller_id = fields.Many2one('res.users', string="Seller", default=lambda self: self.env.user)
-    tag_ids = fields.Many2many('estate.property.tag', string="Tags")
-    offer_ids = fields.One2many('estate.property.offer', 'property_id', string="")
+    property_type_id = fields.Many2one(comodel_name='estate.property.type', string="House Type")
+    buyer_id = fields.Many2one(comodel_name='res.partner', string="Buyer", copy=False)
+    seller_id = fields.Many2one(comodel_name='res.users', string="Seller", default=lambda self: self.env.user)
+    tag_ids = fields.Many2many(comodel_name='estate.property.tag', string="Tags")
+    offer_ids = fields.One2many(comodel_name='estate.property.offer', inverse_name='property_id', string="")
     best_offer = fields.Float(compute='_compute_best_offer')
-    active = fields.Boolean("Active", default=True)
+    active = fields.Boolean(string="Active", default=True)
     state = fields.Selection(
         string="Status",
         selection=[
@@ -48,50 +44,51 @@ class EstateProperty(models.Model):
         copy=False,
     )
 
-    _check_expected_price = models.Constraint(
-        'CHECK(expected_price > 0)', "The expected price must be stricly positive"
-    )
+    _check_expected_price = models.Constraint('CHECK(expected_price > 0)', "The expected price must be stricly positive")
 
     _check_selling_price = models.Constraint('CHECK(selling_price > 0)', "The selling price must be stricly positive")
 
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
-        for record in self:
-            record.total_area = record.living_area + record.garden_area
+        for record_property in self:
+            record_property.total_area = record_property.living_area + record_property.garden_area
 
     @api.depends('offer_ids.price')
     def _compute_best_offer(self):
-        for record in self:
-            record.best_offer = max(record.offer_ids.mapped('price'), default=0)
+        for record_property in self:
+            record_property.best_offer = max(record_property.offer_ids.mapped('price'), default=0)
 
     @api.onchange('garden')
     def _onchange_garden(self):
-        self.garden_area = 10 if self.garden else 0
-        self.garden_orientation = 'north' if self.garden else ''
+        if self.garden:
+            self.garden_area = 10
+            self.garden_orientation = 'north'
+        else:
+            self.garden_area = 0
+            self.garden_orientation = ''
 
     @api.constrains('selling_price', 'expected_price')
     def _check_selling_expected_price(self):
-        for record in self:
-            if not float_is_zero(record.selling_price, precision_digits=2) and (
-                float_compare( record.expected_price * 0.9, record.selling_price, precision_digits=2,) > 0):
+        for record_property in self:
+            if not float_is_zero(record_property.selling_price, precision_digits=2) and (
+                float_compare(record_property.expected_price * 0.9, record_property.selling_price, precision_digits=2) > 0):
                 raise UserError(self.env._("The selling price must be a least 90% of the expected price!"))
 
     def action_cancel(self):
-        for record in self:
-            if record.state == 'sold':
-                raise UserError(self.env._("Sold properties cannot be cancelled"))
-            record.state = 'cancelled'
+        for record_property in self:
+            if record_property.state == 'sold':
+                raise UserError(record_property.env._("Sold properties cannot be cancelled"))
+            record_property.state = 'cancelled'
         return True
 
     def action_sold(self):
-        for record in self:
-            if record.state == 'cancelled':
-                raise UserError(self.env_("Canceled properties cannot be sold"))
-            record.state = 'sold'
+        for record_property in self:
+            if record_property.state == 'cancelled':
+                raise UserError(record_property.env_("Canceled properties cannot be sold"))
+            record_property.state = 'sold'
         return True
 
     @api.ondelete(at_uninstall=False)
     def _ondelete(self):
-        if not any((property_id.state in ('new', 'cancelled')) for property_id in self):
+        if any((property_id.state not in ('new', 'cancelled')) for property_id in self):
             raise UserError(self.env._("You can only delete property in the state New or Cancelled"))
-

estate/models/estate_property_offer.py

@@ -13,7 +13,7 @@ class EstatePropertyOffer(models.Model):
     price = fields.Float(string="Price")
     status = fields.Selection([('accepted', "Accepted"), ('refused', "Refused")], copy=False)
     partner_id = fields.Many2one('res.partner', required=True)
-    property_id = fields.Many2one('estate.property', required=True)
+    property_id = fields.Many2one('estate.property', required=True, ondelete='cascade')
     validity = fields.Integer(default=7)
     date_deadline = fields.Date(compute='_compute_date_deadline', inverse='_inverse_date_deadline')
     property_type_id = fields.Many2one(related='property_id.property_type_id')
@@ -33,9 +33,8 @@ def _inverse_date_deadline(self):
 
     def action_accept_offer(self):
         for record in self:
-            for offer in record.property_id.offer_ids:
-                if offer.status == 'accepted':
-                    raise UserError(self.env_("Another offer has already been accepted."))
+            if record.property_id.offer_ids.filtered(lambda offer: offer.status == 'accepted'):
+                raise UserError(record.env_("Another offer has already been accepted."))
             record.status = 'accepted'
             record.property_id.buyer_id = record.partner_id
             record.property_id.selling_price = record.price
@@ -50,10 +49,10 @@ def action_refuse_offer(self):
     @api.model_create_multi
     def create(self, vals_list):
         for vals in vals_list:
-            PropertyModel = self.env['estate.property'].browse(vals['property_id'])
-            if float_compare(vals['price'], PropertyModel.best_offer, precision_digits=2) < 0:
-                raise UserError(self.env._("The price must be higher than %s", PropertyModel.best_offer))
+            estate_property = self.env['estate.property'].browse(vals['property_id'])
+            if float_compare(vals['price'], estate_property.best_offer, precision_digits=2) < 0:
+                raise UserError(self.env._("The price must be higher than %s", estate_property.best_offer))
 
-            PropertyModel.state = 'offer_received'
+            estate_property.state = 'offer_received'
 
-        return super(EstatePropertyOffer, self).create(vals_list)
+        return super().create(vals_list)

estate/models/estate_property_type.py

@@ -18,4 +18,3 @@ class EstatePropertyType(models.Model):
     def _compute_offer_count(self):
         for record in self:
             record.offer_count = len(record.offer_ids)
-

estate/models/res_users.py

@@ -11,5 +11,5 @@ class ResUsers(models.Model):
         'estate.property',
         'seller_id',
         string="Available Properties",
-        domain=[('state', 'in', {'new', 'offer_received'})],
+        domain=[('state', 'in', ['new', 'offer_received'])],
     )

estate_account/models/estate_property.py

@@ -30,4 +30,4 @@ def action_sold(self):
                 ],
             }
         )
-        return super(EstateProperty, self).action_sold()
+        return super().action_sold()