From 588424bd533c0188df0f7fa53d9d77cac869e18a Mon Sep 17 00:00:00 2001
From: vishal <1117327+vishalchangrani@users.noreply.github.com>
Date: Fri, 13 Mar 2026 12:21:38 -0400
Subject: [PATCH] Add Pool.getPositionCount() and get_position_count script

Expose the total number of active positions in the FlowALPv0 Pool via a
new public view getter on the Pool resource, and a corresponding Cadence
script for off-chain querying.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 cadence/contracts/FlowALPv0.cdc               |  8 +-
 .../scripts/flow-alp/get_position_count.cdc   | 11 +++
 cadence/tests/get_position_count_test.cdc     | 73 +++++++++++++++++++
 3 files changed, 91 insertions(+), 1 deletion(-)
 create mode 100644 cadence/scripts/flow-alp/get_position_count.cdc
 create mode 100644 cadence/tests/get_position_count_test.cdc

diff --git a/cadence/contracts/FlowALPv0.cdc b/cadence/contracts/FlowALPv0.cdc
index 31a11385..c61edf86 100644
--- a/cadence/contracts/FlowALPv0.cdc
+++ b/cadence/contracts/FlowALPv0.cdc
@@ -1656,7 +1656,13 @@ access(all) contract FlowALPv0 {
         /// Returns whether a given token Type is supported or not
         access(all) view fun isTokenSupported(tokenType: Type): Bool {
             return self.globalLedger[tokenType] != nil
-        } 
+        }
+
+        /// Returns the total number of currently active positions in the Pool.
+        /// A position is counted from the moment it is created until it is closed.
+        access(all) view fun getPositionCount(): Int {
+            return self.positions.length
+        }
 
         /// Returns the current balance of the stability fund for a given token type.
         /// Returns nil if the token type is not supported.
diff --git a/cadence/scripts/flow-alp/get_position_count.cdc b/cadence/scripts/flow-alp/get_position_count.cdc
new file mode 100644
index 00000000..65767a22
--- /dev/null
+++ b/cadence/scripts/flow-alp/get_position_count.cdc
@@ -0,0 +1,11 @@
+import "FlowALPv0"
+
+/// Returns the total number of currently active positions in the FlowALPv0 Pool.
+///
+access(all)
+fun main(): Int {
+    let protocolAddress = Type<@FlowALPv0.Pool>().address!
+    return getAccount(protocolAddress).capabilities.borrow<&FlowALPv0.Pool>(FlowALPv0.PoolPublicPath)
+        ?.getPositionCount()
+        ?? panic("Could not find a configured FlowALPv0 Pool in account \(protocolAddress) at path \(FlowALPv0.PoolPublicPath)")
+}
diff --git a/cadence/tests/get_position_count_test.cdc b/cadence/tests/get_position_count_test.cdc
new file mode 100644
index 00000000..3b7ae812
--- /dev/null
+++ b/cadence/tests/get_position_count_test.cdc
@@ -0,0 +1,73 @@
+import Test
+import BlockchainHelpers
+
+import "MOET"
+import "FlowALPv0"
+import "test_helpers.cdc"
+
+// -----------------------------------------------------------------------------
+// get_position_count script test
+//
+// Verifies that the get_position_count.cdc script correctly returns the total
+// number of active positions in the Pool via the Pool.getPositionCount() getter.
+// -----------------------------------------------------------------------------
+
+access(all)
+fun setup() {
+    deployContracts()
+
+    setMockOraclePrice(signer: PROTOCOL_ACCOUNT, forTokenIdentifier: FLOW_TOKEN_IDENTIFIER, price: 1.0)
+    createAndStorePool(signer: PROTOCOL_ACCOUNT, defaultTokenIdentifier: MOET_TOKEN_IDENTIFIER, beFailed: false)
+    addSupportedTokenZeroRateCurve(
+        signer: PROTOCOL_ACCOUNT,
+        tokenTypeIdentifier: FLOW_TOKEN_IDENTIFIER,
+        collateralFactor: 0.8,
+        borrowFactor: 1.0,
+        depositRate: 1_000_000.0,
+        depositCapacityCap: 1_000_000.0
+    )
+}
+
+// getPositionCount returns 0 when no positions have been opened
+access(all)
+fun test_position_count_is_zero_initially() {
+    let res = _executeScript("../scripts/flow-alp/get_position_count.cdc", [])
+    Test.expect(res, Test.beSucceeded())
+    let count = res.returnValue as! Int
+    Test.assertEqual(0, count)
+}
+
+// getPositionCount increments as positions are opened
+access(all)
+fun test_position_count_reflects_open_positions() {
+    let user1 = Test.createAccount()
+    let user2 = Test.createAccount()
+    setupMoetVault(user1, beFailed: false)
+    setupMoetVault(user2, beFailed: false)
+    mintFlow(to: user1, amount: 1_000.0)
+    mintFlow(to: user2, amount: 1_000.0)
+    grantBetaPoolParticipantAccess(PROTOCOL_ACCOUNT, user1)
+    grantBetaPoolParticipantAccess(PROTOCOL_ACCOUNT, user2)
+
+    // Open first position
+    let open1 = executeTransaction(
+        "../transactions/flow-alp/position/create_position.cdc",
+        [100.0, FLOW_VAULT_STORAGE_PATH, true],
+        user1
+    )
+    Test.expect(open1, Test.beSucceeded())
+
+    let countAfterOne = (_executeScript("../scripts/flow-alp/get_position_count.cdc", []).returnValue as! Int?)!
+    Test.assertEqual(1, countAfterOne)
+
+    // Open second position
+    let open2 = executeTransaction(
+        "../transactions/flow-alp/position/create_position.cdc",
+        [100.0, FLOW_VAULT_STORAGE_PATH, true],
+        user2
+    )
+    Test.expect(open2, Test.beSucceeded())
+
+    let countAfterTwo = (_executeScript("../scripts/flow-alp/get_position_count.cdc", []).returnValue as! Int?)!
+    Test.assertEqual(2, countAfterTwo)
+}