From 25782e9689a53b8924ab20e9bf850605463bb277 Mon Sep 17 00:00:00 2001 From: Griger5 Date: Tue, 13 Jan 2026 15:44:32 +0100 Subject: [PATCH 1/3] reenable Werror and other flags --- CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 50fd4c7b..3bac7bfd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -578,8 +578,7 @@ endif() foreach(target _PyPartMC) target_compile_options(${target} PRIVATE $<$:/W4 /WX> - # $<$>:-Wall -Wextra -Wpedantic -Werror> - $<$>:-Wno-unused-parameter> + $<$>:-Wall -Wextra -Wpedantic -Werror -Wno-unused-parameter> ) endforeach() target_compile_definitions(_PyPartMC PRIVATE PMC_USE_SUNDIALS="1") From aac04ea39d297f8dc673e572ba2a2a29c4845476 Mon Sep 17 00:00:00 2001 From: Griger5 Date: Mon, 2 Mar 2026 13:32:26 +0100 Subject: [PATCH 2/3] bump nanobidnd_json submodule version --- gitmodules/nanobind | 2 +- gitmodules/nanobind_json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gitmodules/nanobind b/gitmodules/nanobind index d4b245ad..7d13bfc2 160000 --- a/gitmodules/nanobind +++ b/gitmodules/nanobind @@ -1 +1 @@ -Subproject commit d4b245ad69f729c3d2095be4c1cb5b94810dae26 +Subproject commit 7d13bfc2581b9a34be2f3ab32c035fd182ffe407 diff --git a/gitmodules/nanobind_json b/gitmodules/nanobind_json index cb8a8565..58c78e5d 160000 --- a/gitmodules/nanobind_json +++ b/gitmodules/nanobind_json @@ -1 +1 @@ -Subproject commit cb8a8565cc3bc7510b448cea6e6ec9cff98a599b +Subproject commit 58c78e5d4e5cf9981817c611c803af352cf2bef6 From fe5591a417dfeff19e30cb7ed698f89f84cf597b Mon Sep 17 00:00:00 2001 From: Griger5 Date: Tue, 3 Mar 2026 11:48:22 +0100 Subject: [PATCH 3/3] fix: remove unused variable --- src/aero_particle.hpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/aero_particle.hpp b/src/aero_particle.hpp index de47ca74..ca14e502 100644 --- a/src/aero_particle.hpp +++ b/src/aero_particle.hpp @@ -72,7 +72,6 @@ struct AeroParticle { { int len = AeroData::__len__(*self.aero_data); auto fn = f_aero_particle_volumes; - auto aero_data_ptr = self.aero_data->ptr.f_arg(); return pypartmc::get_array_values_set_len(self, fn, len); }