Build failure (C4996) when including opentelemetry/logs/provider.h with opentelemetry-cpp[geneva]

[lukeina2z]

Steps to Reproduce

1. Follow this article to integrate vcpkg with MSBuild/VisualStudio.

   Tutorial: Install and use packages with MSBuild in Visual Studio
   https://learn.microsoft.com/en-us/vcpkg/get_started/get-started-msbuild

   .\vcpkg.exe integrate install

2. Create a C++ console application in Visual Studio 2022.

3. In Visual Studio, open Tools → Command Line → Developer Command Prompt.

4. Run:

   vcpkg new --application
   vcpkg add port opentelemetry-cpp[geneva]

5. In the project Property Pages, set: vcpkg → Use Vcpkg Manifest = Yes

6. Include the following header in your .cpp file:

   #include "opentelemetry/logs/provider.h"

7. Build the project.

Expected Result

The project builds successfully with no errors.

Actual Result

The build fails with error C4996 due to deprecated symbols:

opentelemetry::v1::logs::EventLogger was declared deprecated
opentelemetry::v1::logs::EventLogger::~EventLogger was declared deprecated
opentelemetry::v1::logs::EventLoggerProvider was declared deprecated
opentelemetry::v1::logs::EventLoggerProvider::~EventLoggerProvider was declared deprecated
opentelemetry::v1::logs::Provider::GetEventProvider was declared deprecated

Additional Notes

This header is included because its APIs are required to set the Geneva TracerProvider as the global default, specifically to call:

GetLoggerProvider()
SetLoggerProvider()

Here is my testing project for this issue: https://github.com/lukeina2z/playground/tree/main/cpp/LogProviderWarning

[lalitb]

The previous fix #3592 reduced the warnings, but looks like MSVC can still emit C4996 just from compiling the headers in ABI v1 mode, and /WX turns that into a hard failure. Recommended workaround is to enable ABI v2 via the vcpkg option (or temporarily disable C4996 / don’t treat it as error). For a permanent fix, feel free to open a follow-up PR to guard the remaining header-scope deprecated references ((e.g., the EventLogger* wrappers/noop types).

[owent]

Could you share the warning messages and the versions of otel-cpp and vcpkg? Some internal codes may be missing to suppress deprecated warnings. The action logs at https://github.com/lukeina2z/playground/tree/main/cpp/LogProviderWarning appear to have expired, so the original logs would be helpful.

[lukeina2z]

I updated the repro steps. It should help to consistently reproduce this issue.

[owent]

Thanks, I reproduced it. I will rasie a PR to fix it.