fix: prioritize options over bool for macOS prefs and harden install script

- Check catalogItem.options before bool type in ConfigDetail and
  ConfigEditor so dropdown prefs (e.g. desktop click behavior) render
  correctly instead of showing ON/OFF toggle
- Move exit 0 inside main() in install scripts to prevent bash hanging
  on /dev/tty after curl pipe completes
- Add exec fallback exit in private install script

Author: fullstackjam

src/lib/components/ConfigDetail.svelte

@@ -468,14 +468,14 @@
 									<div class="prefs-kv-row">
 										<span class="prefs-kv-label">{catalogItem?.label ?? pref.key}</span>
 										<span class="prefs-kv-value">
-											{#if (catalogItem?.type ?? pref.type) === 'bool'}
+											{#if catalogItem?.options}
+												{@const opt = catalogItem.options.find((o: { value: string; label: string }) => o.value === pref.value)}
+												<span class="pref-option-val">{opt?.label ?? pref.value}</span>
+											{:else if (catalogItem?.type ?? pref.type) === 'bool'}
 												{@const boolOn = pref.value === 'true' || pref.value === '1'}
 												<span class="pref-bool {boolOn ? 'pref-bool-on' : 'pref-bool-off'}">
 													{boolOn ? 'ON' : 'OFF'}
 												</span>
-											{:else if catalogItem?.options}
-												{@const opt = catalogItem.options.find((o: { value: string; label: string }) => o.value === pref.value)}
-												<span class="pref-option-val">{opt?.label ?? pref.value}</span>
 											{:else}
 												<span class="pref-raw-val">{pref.value}</span>
 											{/if}

src/lib/components/ConfigEditor.svelte

@@ -554,15 +554,7 @@
 													</div>
 													{#if added && prefIdx >= 0}
 														<div class="pref-control">
-															{#if item.type === 'bool'}
-																<button
-																	class="pref-bool"
-																	class:on={macosPrefs[prefIdx].value === 'true'}
-																	onclick={() => updatePrefValue(prefIdx, macosPrefs[prefIdx].value === 'true' ? 'false' : 'true')}
-																>
-																	{macosPrefs[prefIdx].value === 'true' ? 'ON' : 'OFF'}
-																</button>
-															{:else if item.options}
+															{#if item.options}
 																<select
 																	class="pref-sel"
 																	value={macosPrefs[prefIdx].value}
@@ -572,6 +564,14 @@
 																		<option value={opt.value}>{opt.label}</option>
 																	{/each}
 																</select>
+															{:else if item.type === 'bool'}
+																<button
+																	class="pref-bool"
+																	class:on={macosPrefs[prefIdx].value === 'true'}
+																	onclick={() => updatePrefValue(prefIdx, macosPrefs[prefIdx].value === 'true' ? 'false' : 'true')}
+																>
+																	{macosPrefs[prefIdx].value === 'true' ? 'ON' : 'OFF'}
+																</button>
 															{:else}
 																<input
 																	type={(item.type === 'int' || item.type === 'float') ? 'number' : 'text'}

src/lib/macos-prefs-catalog.ts

@@ -38,8 +38,8 @@ export const MACOS_PREF_CATALOG: MacOSPrefCatalogItem[] = [
 	{ id: 'trackpad-natural-scroll', category: 'Trackpad', label: 'Natural scrolling', description: 'Scroll content in the direction your fingers move (iOS-style)', domain: 'NSGlobalDomain', key: 'com.apple.swipescrolldirection', type: 'bool', defaultValue: 'true' },
 	{ id: 'trackpad-three-finger-drag', category: 'Trackpad', label: 'Three-finger drag', description: 'Drag windows and items using three fingers on the trackpad', domain: 'com.apple.AppleMultitouchTrackpad', key: 'TrackpadThreeFingerDrag', type: 'bool', defaultValue: 'false' },
 
-	// Desktop
-	{ id: 'desktop-click-to-show', category: 'Desktop', label: 'Click desktop to show it', description: 'Click the desktop wallpaper to bring it to the front and hide all windows', domain: 'com.apple.WindowManager', key: 'EnableStandardClickToShowDesktop', type: 'bool', defaultValue: 'false' },
+	// Desktop & Stage Manager
+	{ id: 'desktop-click-to-show', category: 'Desktop & Stage Manager', label: 'Click wallpaper to show desktop', description: 'When clicking the desktop wallpaper, hide windows to reveal the desktop', domain: 'com.apple.WindowManager', key: 'EnableStandardClickToShowDesktop', type: 'bool', defaultValue: 'false', options: [{ value: 'true', label: 'Always' }, { value: 'false', label: 'Only in Stage Manager' }] },
 
 	// Keyboard
 	{ id: 'keyboard-key-repeat', category: 'Keyboard', label: 'Key repeat rate', description: 'How fast keys repeat when held down — lower number = faster (min 1)', domain: 'NSGlobalDomain', key: 'KeyRepeat', type: 'int', defaultValue: '2', min: 1, max: 15 },

src/lib/server/install-script.test.ts

@@ -12,6 +12,11 @@ describe('generatePrivateInstallScript', () => {
 		expect(script).toContain('main()');
 		expect(script).toMatch(/main "\$@"\s*$/);
 		expect(script).toContain('exec < /dev/tty');
+
+		// CRITICAL: main() must never return after exec < /dev/tty redirects stdin.
+		// Every code path inside main() must end with exit or exec, otherwise
+		// bash hangs waiting on /dev/tty when run via "curl | bash".
+		expect(script).toContain('exit 1\n}');
 	});
 
 	it('should generate private install script with sanitized username and slug', () => {
@@ -116,8 +121,15 @@ describe('generateInstallScript', () => {
 		const script = generateInstallScript('testuser', 'my-config', '', '');
 
 		expect(script).toContain('main()');
-		expect(script).toMatch(/main "\$@"\s*\nexit 0\s*$/);
+		expect(script).toMatch(/main "\$@"\s*$/);
 		expect(script).toContain('exec < /dev/tty');
+
+		// CRITICAL: main() must never return after exec < /dev/tty redirects stdin.
+		// Every code path inside main() must end with exit or exec, otherwise
+		// bash hangs waiting on /dev/tty when run via "curl | bash".
+		expect(script).toContain('exit 0\n}');
+		// No code should appear between main "$@" and end of script
+		expect(script).not.toMatch(/main "\$@"[\s\S]*exit/);
 	});
 
 	it('should generate basic install script without custom content', () => {

src/lib/server/install-script.ts

@@ -16,6 +16,9 @@ set -e
 main() {
 # When run via "curl | bash", stdin is the script content, not the terminal.
 # Reopen stdin from /dev/tty so interactive prompts (sudo, Homebrew) work.
+# IMPORTANT: This redirects stdin for the ENTIRE process. After main() returns,
+# bash would try to read the next command from /dev/tty (not the pipe) and hang.
+# Therefore main() MUST exit explicitly — never let it return to the caller.
 if [ ! -t 0 ] && [ -e /dev/tty ]; then
   exec < /dev/tty || true
 fi
@@ -84,6 +87,8 @@ echo "Authorized! Fetching install script..."
 echo ""
 
 exec bash <(curl -fsSL -H "Authorization: Bearer \$TOKEN" "\$APP_URL/${safeUsername}/${safeSlug}/install")
+echo "Error: Failed to launch install script" >&2
+exit 1
 }
 
 main "\$@"
@@ -107,6 +112,9 @@ TAP_NAME="openbootdotdev/tap"
 main() {
 # When run via "curl | bash", stdin is the script content, not the terminal.
 # Reopen stdin from /dev/tty so interactive prompts (read, sudo, Homebrew) work.
+# IMPORTANT: This redirects stdin for the ENTIRE process. After main() returns,
+# bash would try to read the next command from /dev/tty (not the pipe) and hang.
+# Therefore main() MUST exit explicitly — never let it return to the caller.
 if [[ ! -t 0 ]] && [[ -e /dev/tty ]]; then
   exec < /dev/tty || true
 fi
@@ -290,9 +298,9 @@ done
 
 echo ""
 echo "Installation complete!"
+exit 0
 }
 
 main "\$@"
-exit 0
 `;
 }