fix: remove duplicate custom_script and dotfiles from install script

The CLI already handles post-install scripts (with confirmation) and
dotfiles (clone/stow) via stepPostInstall and stepDotfiles. The install
script was executing them a second time unconditionally. Now the install
script only bootstraps Xcode + Homebrew + openboot, then delegates
everything to the CLI.

Author: fullstackjam

src/hooks.server.ts

@@ -67,7 +67,7 @@ export const handle: Handle = async ({ event, resolve }) => {
 						}));
 					}
 
-					const script = generateInstallScript(config.username, config.slug, config.custom_script, config.dotfiles_repo || '');
+					const script = generateInstallScript(config.username, config.slug);
 
 					env.DB.prepare('UPDATE configs SET install_count = install_count + 1 WHERE alias = ?').bind(alias).run().catch((e: unknown) => console.error('install count update failed:', e));
 
@@ -92,8 +92,8 @@ export const handle: Handle = async ({ event, resolve }) => {
 			const slug = installShMatch[2];
 
 			const config = await env.DB.prepare(
-				'SELECT c.custom_script, c.visibility, c.dotfiles_repo, c.user_id FROM configs c JOIN users u ON c.user_id = u.id WHERE u.username = ? AND c.slug = ?'
-			).bind(username, slug).first<{ custom_script: string; visibility: string; dotfiles_repo: string; user_id: string }>();
+				'SELECT c.visibility, c.user_id FROM configs c JOIN users u ON c.user_id = u.id WHERE u.username = ? AND c.slug = ?'
+			).bind(username, slug).first<{ visibility: string; user_id: string }>();
 
 			if (config) {
 				if (config.visibility === 'private') {
@@ -103,7 +103,7 @@ export const handle: Handle = async ({ event, resolve }) => {
 					}));
 				}
 
-				const script = generateInstallScript(username, slug, config.custom_script, config.dotfiles_repo || '');
+				const script = generateInstallScript(username, slug);
 
 				env.DB.prepare('UPDATE configs SET install_count = install_count + 1 WHERE user_id = ? AND slug = ?').bind(config.user_id, slug).run().catch((e: unknown) => console.error('install count update failed:', e));
 
@@ -139,7 +139,7 @@ export const handle: Handle = async ({ event, resolve }) => {
 						}));
 					}
 
-					const script = generateInstallScript(username, slug, config.custom_script, config.dotfiles_repo || '');
+					const script = generateInstallScript(username, slug);
 
 					env.DB.prepare('UPDATE configs SET install_count = install_count + 1 WHERE user_id = ? AND slug = ?').bind(config.user_id, slug).run().catch((e: unknown) => console.error('install count update failed:', e));
 

src/lib/server/install-script.test.ts

@@ -118,22 +118,20 @@ describe('generatePrivateInstallScript', () => {
 
 describe('generateInstallScript', () => {
 	it('should wrap everything in main() for safe curl|bash piping', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('main()');
 		expect(script).toMatch(/main "\$@"\s*$/);
 		expect(script).toContain('exec < /dev/tty');
 
 		// CRITICAL: main() must never return after exec < /dev/tty redirects stdin.
-		// Every code path inside main() must end with exit or exec, otherwise
-		// bash hangs waiting on /dev/tty when run via "curl | bash".
 		expect(script).toContain('exit 0\n}');
 		// No code should appear between main "$@" and end of script
 		expect(script).not.toMatch(/main "\$@"[\s\S]*exit/);
 	});
 
-	it('should generate basic install script without custom content', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+	it('should generate basic install script', () => {
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('#!/bin/bash');
 		expect(script).toContain('OpenBoot Installer');
@@ -143,117 +141,49 @@ describe('generateInstallScript', () => {
 	});
 
 	it('should include Xcode CLT installation', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('install_xcode_clt()');
 		expect(script).toContain('xcode-select -p');
 		expect(script).toContain('xcode-select --install');
 	});
 
 	it('should include Homebrew installation', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('install_homebrew()');
 		expect(script).toContain('command -v brew');
 		expect(script).toContain('Homebrew/install/HEAD/install.sh');
 	});
 
 	it('should handle ARM64 architecture', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('detect_arch()');
 		expect(script).toContain('/opt/homebrew/bin/brew');
 		expect(script).toContain('arm64)');
 	});
 
-	it('should include custom script when provided', () => {
-		const customScript = 'mkdir -p ~/projects\necho "Setup complete"';
-		const script = generateInstallScript('testuser', 'my-config', customScript, '');
-
-		expect(script).toContain('Running Custom Post-Install Script');
-		expect(script).toContain('base64 -d | bash');
-		expect(script).toContain('CUSTOM_SCRIPT_EXIT=$?');
-	});
-
-	it('should handle custom script errors gracefully', () => {
-		const customScript = 'exit 1';
-		const script = generateInstallScript('testuser', 'my-config', customScript, '');
-
-		expect(script).toContain('set +e');
-		expect(script).toContain('if [ $CUSTOM_SCRIPT_EXIT -ne 0 ]');
-		expect(script).toContain('Custom script exited with code');
-		expect(script).toContain('Installation will continue');
-	});
-
-	it('should not include custom script section when empty', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+	it('should not include custom script or dotfiles sections', () => {
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).not.toContain('Running Custom Post-Install Script');
 		expect(script).not.toContain('base64 -d');
-	});
-
-	it('should include dotfiles setup when repo provided', () => {
-		const dotfilesRepo = 'https://github.com/testuser/dotfiles.git';
-		const script = generateInstallScript('testuser', 'my-config', '', dotfilesRepo);
-
-		expect(script).toContain('Setting up Dotfiles');
-		expect(script).toContain('DOTFILES_REPO="https://github.com/testuser/dotfiles.git"');
-		expect(script).toContain('DOTFILES_DIR="$HOME/.dotfiles"');
-		expect(script).toContain('git clone "$DOTFILES_REPO"');
-		expect(script).toContain('stow -v --target="$HOME"');
-	});
-
-	it('should validate dotfiles repo URL is HTTPS', () => {
-		const dotfilesRepo = 'https://github.com/testuser/dotfiles.git';
-		const script = generateInstallScript('testuser', 'my-config', '', dotfilesRepo);
-
-		expect(script).toContain('if [[ ! "$DOTFILES_REPO" =~ ^https:// ]]');
-		expect(script).toContain('Invalid dotfiles repo URL (must use HTTPS)');
-	});
-
-	it('should handle existing dotfiles directory with git pull', () => {
-		const dotfilesRepo = 'https://github.com/testuser/dotfiles.git';
-		const script = generateInstallScript('testuser', 'my-config', '', dotfilesRepo);
-
-		expect(script).toContain('if [ -d "$DOTFILES_DIR" ]');
-		expect(script).toContain('Pulling latest changes...');
-		expect(script).toContain('git pull');
-	});
-
-	it('should remove existing zshrc files before stow', () => {
-		const dotfilesRepo = 'https://github.com/testuser/dotfiles.git';
-		const script = generateInstallScript('testuser', 'my-config', '', dotfilesRepo);
-
-		expect(script).toContain('rm -f "$HOME/.zshrc" "$HOME/.zshrc.pre-oh-my-zsh"');
-	});
-
-	it('should not include dotfiles section when repo not provided', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
-
 		expect(script).not.toContain('Setting up Dotfiles');
 		expect(script).not.toContain('DOTFILES_REPO');
 		expect(script).not.toContain('stow');
 	});
 
 	it('should sanitize username and slug in all references', () => {
-		const script = generateInstallScript('user@test', 'my config!', '', '');
+		const script = generateInstallScript('user@test', 'my config!');
 
 		expect(script).toContain('usertest/myconfig');
 		expect(script).not.toContain('user@test');
 		expect(script).not.toContain('my config!');
 	});
 
-	it('should include both custom script and dotfiles when both provided', () => {
-		const customScript = 'echo "Custom setup"';
-		const dotfilesRepo = 'https://github.com/testuser/dotfiles.git';
-		const script = generateInstallScript('testuser', 'my-config', customScript, dotfilesRepo);
-
-		expect(script).toContain('Running Custom Post-Install Script');
-		expect(script).toContain('Setting up Dotfiles');
-	});
-
 	it('should install openboot via Homebrew tap', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('TAP_NAME="openbootdotdev/tap"');
 		expect(script).toContain('brew install ${TAP_NAME}/openboot');
@@ -262,7 +192,7 @@ describe('generateInstallScript', () => {
 	});
 
 	it('should pass through additional arguments to openboot', () => {
-		const script = generateInstallScript('testuser', 'my-config', '', '');
+		const script = generateInstallScript('testuser', 'my-config');
 
 		expect(script).toContain('openboot --user "testuser/my-config" "$@"');
 	});

src/lib/server/install-script.ts

@@ -97,9 +97,7 @@ main "\$@"
 
 export function generateInstallScript(
 	username: string,
-	slug: string,
-	customScript: string,
-	dotfilesRepo: string
+	slug: string
 ): string {
 	const safeUsername = sanitizeShellArg(username);
 	const safeSlug = sanitizeShellArg(slug);
@@ -246,56 +244,6 @@ echo "Starting OpenBoot setup with config: @${safeUsername}/${safeSlug}"
 echo ""
 openboot --user "${safeUsername}/${safeSlug}" "\$@"
 
-${
-		customScript
-			? `
-echo ""
-echo "=== Running Custom Post-Install Script ==="
-set +e
-CUSTOM_SCRIPT_B64="${btoa(unescape(encodeURIComponent(customScript)))}"
-echo "\$CUSTOM_SCRIPT_B64" | base64 -d | bash
-CUSTOM_SCRIPT_EXIT=$?
-set -e
-if [ $CUSTOM_SCRIPT_EXIT -ne 0 ]; then
-  echo ""
-  echo "⚠ Custom script exited with code $CUSTOM_SCRIPT_EXIT"
-  echo "  Installation will continue, but check script output above."
-fi
-`
-			: ''
-	}
-${
-		dotfilesRepo
-			? `
-echo ""
-echo "=== Setting up Dotfiles ==="
-DOTFILES_REPO="${dotfilesRepo}"
-DOTFILES_DIR="\$HOME/.dotfiles"
-
-if [[ ! "\$DOTFILES_REPO" =~ ^https:// ]]; then
-  echo "Error: Invalid dotfiles repo URL (must use HTTPS)"
-  exit 1
-fi
-
-if [ -d "\$DOTFILES_DIR" ]; then
-  echo "Dotfiles directory already exists at \$DOTFILES_DIR"
-  echo "Pulling latest changes..."
-  cd "\$DOTFILES_DIR" && git pull
-else
-  echo "Cloning dotfiles from \$DOTFILES_REPO..."
-  git clone "\$DOTFILES_REPO" "\$DOTFILES_DIR"
-fi
-
-cd "\$DOTFILES_DIR"
-echo "Deploying dotfiles with stow..."
-rm -f "\$HOME/.zshrc" "\$HOME/.zshrc.pre-oh-my-zsh"
-for dir in */; do
-  [ -d "\$dir" ] && stow -v --target="\$HOME" "\${dir%/}" 2>/dev/null || true
-done
-`
-			: ''
-	}
-
 echo ""
 echo "Installation complete!"
 exit 0

src/routes/[username]/[slug]/install/+server.ts

@@ -12,9 +12,9 @@ export const GET: RequestHandler = async ({ platform, params, request }) => {
 		return new Response('User not found', { status: 404 });
 	}
 
-	const config = await env.DB.prepare('SELECT custom_script, visibility, dotfiles_repo FROM configs WHERE user_id = ? AND slug = ?')
+	const config = await env.DB.prepare('SELECT visibility FROM configs WHERE user_id = ? AND slug = ?')
 		.bind(user.id, params.slug)
-		.first<{ custom_script: string; visibility: string; dotfiles_repo: string }>();
+		.first<{ visibility: string }>();
 
 	if (!config) {
 		return new Response('Config not found', { status: 404 });
@@ -34,7 +34,7 @@ export const GET: RequestHandler = async ({ platform, params, request }) => {
 		}
 	}
 
-	const script = generateInstallScript(params.username, params.slug, config.custom_script, config.dotfiles_repo || '');
+	const script = generateInstallScript(params.username, params.slug);
 
 	return new Response(script, {
 		headers: {