From 626e1c5695215aa516f48bc777abee0ea8c36cfe Mon Sep 17 00:00:00 2001 From: Jian Li Date: Sat, 28 Feb 2026 15:12:09 +0800 Subject: [PATCH] Adding unit tests for the extend recommended alerts https://issues.redhat.com/browse/OTA-1811 introduces some new alerts, this PR meand to automate the tests to those alerts. In this PR I added two test file: 1. 4.22.0-extend-recommended-alert-cv.yaml This file covers: - VirtHandlerDaemonSetRolloutFailing + warning + precheck + firing - VMCannotBeEvicted + warning + not precheck + firing - Custom alert + warning + precheck + firing 2. 4.22.0-extend-recommended-critical-alert-cv.yaml This file covers: - VirtHandlerDaemonSetRolloutFailing + critical + precheck + firing - VMCannotBeEvicted + critical + precheck + pending --- ....22.0-extend-recommended-alert-alerts.json | 67 ++++++++++++++ .../4.22.0-extend-recommended-alert-cv.yaml | 91 +++++++++++++++++++ .../4.22.0-extend-recommended-alert.output | 28 ++++++ ...mended-alert.show-outdated-releases-output | 28 ++++++ ...end-recommended-critical-alert-alerts.json | 42 +++++++++ ...-extend-recommended-critical-alert-cv.yaml | 91 +++++++++++++++++++ ...0-extend-recommended-critical-alert.output | 15 +++ ...itical-alert.show-outdated-releases-output | 15 +++ .../admin/upgrade/recommend/examples_test.go | 4 + 9 files changed, 381 insertions(+) create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-alerts.json create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-cv.yaml create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.output create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.show-outdated-releases-output create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-alerts.json create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-cv.yaml create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.output create mode 100644 pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.show-outdated-releases-output diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-alerts.json b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-alerts.json new file mode 100644 index 0000000000..452837d1b6 --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-alerts.json @@ -0,0 +1,67 @@ +{ + "status": "success", + "data": { + "alerts": [ + { + "labels": { + "alertname": "VirtHandlerDaemonSetRolloutFailing", + "channel": "stable-4.22", + "namespace": "openshift-cluster-version", + "severity": "warning", + "upstream": "https://amd64.origin.releases.ci.openshift.org/graph", + "openShiftUpdatePrecheck": "true" + }, + "annotations": { + "description": "For more information refer to 'oc adm upgrade' or https://console-openshift-console.apps.ci-ln-plnvytb-76ef8.aws-2.ci.openshift.org/settings/cluster/.", + "summary": "Your upstream update recommendation service recommends you update your cluster." + }, + "state": "firing", + "activeAt": "2025-09-09T16:59:17.077287821Z", + "value": "2e+00", + "partialResponseStrategy": "WARN" + }, + { + "labels": { + "alertname": "VMCannotBeEvicted", + "container": "insights-operator", + "description": "GSS does not provide enterprise-level support for an OKD cluster", + "endpoint": "https", + "info_link": "https://console.redhat.com/openshift/insights/advisor/clusters/7a18f603-2a0c-4794-af53-85bdae9b8ea9?first=ccx_rules_ocp.external.rules.okd_cluster_unsupported%7COKD_CLUSTER_UNSUPPORTED", + "instance": "10.130.0.31:8443", + "job": "metrics", + "namespace": "openshift-insights", + "pod": "insights-operator-b8b5f97fc-kl8rr", + "service": "metrics", + "severity": "warning", + "total_risk": "Moderate", + "openShiftUpdatePrecheck": "false" + }, + "annotations": { + "description": "Insights recommendation \"GSS does not provide enterprise-level support for an OKD cluster\" with total risk \"Moderate\" was detected on the cluster. More information is available at https://console.redhat.com/openshift/insights/advisor/clusters/7a18f603-2a0c-4794-af53-85bdae9b8ea9?first=ccx_rules_ocp.external.rules.okd_cluster_unsupported%7COKD_CLUSTER_UNSUPPORTED.", + "summary": "An Insights recommendation is active for this cluster." + }, + "state": "firing", + "activeAt": "2025-09-09T16:52:41.445352906Z", + "value": "1e+00", + "partialResponseStrategy": "WARN" + }, + { + "labels": { + "alertname": "TestAlert", + "name": "ci-ln-plnvytb-76ef8-42h8v-worker-us-east-1a-84pg2", + "namespace": "openshift-machine-api", + "severity": "warning", + "openShiftUpdatePrecheck": "true" + }, + "annotations": { + "description": "The machine has been without a Running or Deleting phase for more than 60 minutes.\nThe machine may not have been provisioned properly from the infrastructure provider, or\nit might have issues with CertificateSigningRequests being approved.\n", + "summary": "machine ci-ln-plnvytb-76ef8-42h8v-worker-us-east-1a-84pg2 is in phase: " + }, + "state": "firing", + "activeAt": "2025-09-09T16:49:56.763336056Z", + "value": "1.757435418e+09", + "partialResponseStrategy": "WARN" + } + ] + } +} diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-cv.yaml b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-cv.yaml new file mode 100644 index 0000000000..ff81b6b06b --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert-cv.yaml @@ -0,0 +1,91 @@ +apiVersion: config.openshift.io/v1 +kind: ClusterVersion +metadata: + creationTimestamp: "2025-09-09T16:25:09Z" + generation: 3 + name: version + resourceVersion: "31455" + uid: 31502537-d38e-4652-a5a6-18b0d767b354 +spec: + channel: stable-4.22 + clusterID: 7a18f603-2a0c-4794-af53-85bdae9b8ea9 + upstream: https://amd64.origin.releases.ci.openshift.org/graph +status: + availableUpdates: + - image: registry.ci.openshift.org/ocp/release@sha256:64db99b4f820a919ba98e077f181f6b385a6883b88984a5acbebae0aef319561 + version: 4.22.0-0.nightly-2026-02-26-092444 + capabilities: + enabledCapabilities: + - Build + - CSISnapshot + - CloudControllerManager + - CloudCredential + - Console + - DeploymentConfig + - ImageRegistry + - Ingress + - Insights + - MachineAPI + - NodeTuning + - OperatorLifecycleManager + - OperatorLifecycleManagerV1 + - Storage + - baremetal + - marketplace + - openshift-samples + knownCapabilities: + - Build + - CSISnapshot + - CloudControllerManager + - CloudCredential + - Console + - DeploymentConfig + - ImageRegistry + - Ingress + - Insights + - MachineAPI + - NodeTuning + - OperatorLifecycleManager + - OperatorLifecycleManagerV1 + - Storage + - baremetal + - marketplace + - openshift-samples + conditions: + - lastTransitionTime: "2025-09-09T16:58:30Z" + status: "True" + type: RetrievedUpdates + - lastTransitionTime: "2025-09-09T16:25:36Z" + message: Capabilities match configured spec + reason: AsExpected + status: "False" + type: ImplicitlyEnabledCapabilities + - lastTransitionTime: "2025-09-09T16:25:36Z" + message: Payload loaded version="4.22.0-ec.3" image="quay.io/openshift-release-dev/ocp-release@sha256:58b98da1492b3f4af6129c4684b8e8cde4f2dc197e4b483bb6025971d59f92a5" + architecture="amd64" + reason: PayloadLoaded + status: "True" + type: ReleaseAccepted + - lastTransitionTime: "2025-09-09T16:55:08Z" + message: Done applying 4.22.0-ec.3 + status: "True" + type: Available + - lastTransitionTime: "2025-09-09T16:55:08Z" + status: "False" + type: Failing + - lastTransitionTime: "2025-09-09T16:55:08Z" + message: Cluster version is 4.22.0-ec.3 + status: "False" + type: Progressing + desired: + image: quay.io/openshift-release-dev/ocp-release@sha256:58b98da1492b3f4af6129c4684b8e8cde4f2dc197e4b483bb6025971d59f92a5 + version: 4.22.0-ec.3 + history: + - completionTime: "2025-09-09T16:55:08Z" + image: quay.io/openshift-release-dev/ocp-release@sha256:58b98da1492b3f4af6129c4684b8e8cde4f2dc197e4b483bb6025971d59f92a5 + startedTime: "2025-09-09T16:25:36Z" + state: Completed + verified: false + version: 4.22.0-ec.3 + observedGeneration: 1 + versionHash: XI4117989oE= diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.output b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.output new file mode 100644 index 0000000000..accdfe721c --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.output @@ -0,0 +1,28 @@ +The following conditions found no cause for concern in updating this cluster to later releases: recommended/CriticalAlerts (AsExpected), recommended/NodeAlerts (AsExpected), recommended/PodDisruptionBudgetAlerts (AsExpected), recommended/PodImagePullAlerts (AsExpected) + +The following conditions found cause for concern in updating this cluster to later releases: recommended/UpdatePrecheckAlerts/TestAlert/2, recommended/UpdatePrecheckAlerts/VirtHandlerDaemonSetRolloutFailing/0, recommended/VirtAlerts/VMCannotBeEvicted/1 + +recommended/UpdatePrecheckAlerts/VirtHandlerDaemonSetRolloutFailing/0=False: + + Reason: Alert:firing + Message: warning alert VirtHandlerDaemonSetRolloutFailing firing, suggesting issues worth investigating before updating the cluster. Your upstream update recommendation service recommends you update your cluster. The alert description is: For more information refer to 'oc adm upgrade' or https://console-openshift-console.apps.ci-ln-plnvytb-76ef8.aws-2.ci.openshift.org/settings/cluster/. + +recommended/VirtAlerts/VMCannotBeEvicted/1=False: + + Reason: Alert:firing + Message: warning alert VMCannotBeEvicted firing, which may slow workload redistribution during rolling node updates. An Insights recommendation is active for this cluster. The alert description is: Insights recommendation "GSS does not provide enterprise-level support for an OKD cluster" with total risk "Moderate" was detected on the cluster. More information is available at https://console.redhat.com/openshift/insights/advisor/clusters/7a18f603-2a0c-4794-af53-85bdae9b8ea9?first=ccx_rules_ocp.external.rules.okd_cluster_unsupported%7COKD_CLUSTER_UNSUPPORTED. + +recommended/UpdatePrecheckAlerts/TestAlert/2=False: + + Reason: Alert:firing + Message: warning alert TestAlert firing, suggesting issues worth investigating before updating the cluster. machine ci-ln-plnvytb-76ef8-42h8v-worker-us-east-1a-84pg2 is in phase: . The alert description is: The machine has been without a Running or Deleting phase for more than 60 minutes. + The machine may not have been provisioned properly from the infrastructure provider, or + it might have issues with CertificateSigningRequests being approved. + + +Upstream update service: https://amd64.origin.releases.ci.openshift.org/graph +Channel: stable-4.22 + +Updates to 4.22: + VERSION ISSUES + 4.22.0-0.nightly-2026-02-26-092444 no known issues relevant to this cluster diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.show-outdated-releases-output b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.show-outdated-releases-output new file mode 100644 index 0000000000..accdfe721c --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-alert.show-outdated-releases-output @@ -0,0 +1,28 @@ +The following conditions found no cause for concern in updating this cluster to later releases: recommended/CriticalAlerts (AsExpected), recommended/NodeAlerts (AsExpected), recommended/PodDisruptionBudgetAlerts (AsExpected), recommended/PodImagePullAlerts (AsExpected) + +The following conditions found cause for concern in updating this cluster to later releases: recommended/UpdatePrecheckAlerts/TestAlert/2, recommended/UpdatePrecheckAlerts/VirtHandlerDaemonSetRolloutFailing/0, recommended/VirtAlerts/VMCannotBeEvicted/1 + +recommended/UpdatePrecheckAlerts/VirtHandlerDaemonSetRolloutFailing/0=False: + + Reason: Alert:firing + Message: warning alert VirtHandlerDaemonSetRolloutFailing firing, suggesting issues worth investigating before updating the cluster. Your upstream update recommendation service recommends you update your cluster. The alert description is: For more information refer to 'oc adm upgrade' or https://console-openshift-console.apps.ci-ln-plnvytb-76ef8.aws-2.ci.openshift.org/settings/cluster/. + +recommended/VirtAlerts/VMCannotBeEvicted/1=False: + + Reason: Alert:firing + Message: warning alert VMCannotBeEvicted firing, which may slow workload redistribution during rolling node updates. An Insights recommendation is active for this cluster. The alert description is: Insights recommendation "GSS does not provide enterprise-level support for an OKD cluster" with total risk "Moderate" was detected on the cluster. More information is available at https://console.redhat.com/openshift/insights/advisor/clusters/7a18f603-2a0c-4794-af53-85bdae9b8ea9?first=ccx_rules_ocp.external.rules.okd_cluster_unsupported%7COKD_CLUSTER_UNSUPPORTED. + +recommended/UpdatePrecheckAlerts/TestAlert/2=False: + + Reason: Alert:firing + Message: warning alert TestAlert firing, suggesting issues worth investigating before updating the cluster. machine ci-ln-plnvytb-76ef8-42h8v-worker-us-east-1a-84pg2 is in phase: . The alert description is: The machine has been without a Running or Deleting phase for more than 60 minutes. + The machine may not have been provisioned properly from the infrastructure provider, or + it might have issues with CertificateSigningRequests being approved. + + +Upstream update service: https://amd64.origin.releases.ci.openshift.org/graph +Channel: stable-4.22 + +Updates to 4.22: + VERSION ISSUES + 4.22.0-0.nightly-2026-02-26-092444 no known issues relevant to this cluster diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-alerts.json b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-alerts.json new file mode 100644 index 0000000000..93c5c9e7dc --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-alerts.json @@ -0,0 +1,42 @@ +{ + "status": "success", + "data": { + "alerts": [ + { + "labels": { + "alertname": "VirtHandlerDaemonSetRolloutFailing", + "channel": "stable-4.22", + "namespace": "openshift-cluster-version", + "severity": "critical", + "upstream": "https://amd64.origin.releases.ci.openshift.org/graph", + "openShiftUpdatePrecheck": "true" + }, + "annotations": { + "description": "For more information refer to 'oc adm upgrade' or https://console-openshift-console.apps.ci-ln-plnvytb-76ef8.aws-2.ci.openshift.org/settings/cluster/.", + "summary": "Your upstream update recommendation service recommends you update your cluster." + }, + "state": "firing", + "activeAt": "2025-09-09T16:59:17.077287821Z", + "value": "2e+00", + "partialResponseStrategy": "WARN" + }, + { + "labels": { + "alertname": "VMCannotBeEvicted", + "name": "ci-ln-plnvytb-76ef8-42h8v-worker-us-east-1a-84pg2", + "namespace": "openshift-machine-api", + "severity": "critical", + "openShiftUpdatePrecheck": "true" + }, + "annotations": { + "description": "The machine has been without a Running or Deleting phase for more than 60 minutes.\nThe machine may not have been provisioned properly from the infrastructure provider, or\nit might have issues with CertificateSigningRequests being approved.\n", + "summary": "machine ci-ln-plnvytb-76ef8-42h8v-worker-us-east-1a-84pg2 is in phase: " + }, + "state": "pending", + "activeAt": "2025-09-09T16:49:56.763336056Z", + "value": "1.757435418e+09", + "partialResponseStrategy": "WARN" + } + ] + } +} diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-cv.yaml b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-cv.yaml new file mode 100644 index 0000000000..ff81b6b06b --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert-cv.yaml @@ -0,0 +1,91 @@ +apiVersion: config.openshift.io/v1 +kind: ClusterVersion +metadata: + creationTimestamp: "2025-09-09T16:25:09Z" + generation: 3 + name: version + resourceVersion: "31455" + uid: 31502537-d38e-4652-a5a6-18b0d767b354 +spec: + channel: stable-4.22 + clusterID: 7a18f603-2a0c-4794-af53-85bdae9b8ea9 + upstream: https://amd64.origin.releases.ci.openshift.org/graph +status: + availableUpdates: + - image: registry.ci.openshift.org/ocp/release@sha256:64db99b4f820a919ba98e077f181f6b385a6883b88984a5acbebae0aef319561 + version: 4.22.0-0.nightly-2026-02-26-092444 + capabilities: + enabledCapabilities: + - Build + - CSISnapshot + - CloudControllerManager + - CloudCredential + - Console + - DeploymentConfig + - ImageRegistry + - Ingress + - Insights + - MachineAPI + - NodeTuning + - OperatorLifecycleManager + - OperatorLifecycleManagerV1 + - Storage + - baremetal + - marketplace + - openshift-samples + knownCapabilities: + - Build + - CSISnapshot + - CloudControllerManager + - CloudCredential + - Console + - DeploymentConfig + - ImageRegistry + - Ingress + - Insights + - MachineAPI + - NodeTuning + - OperatorLifecycleManager + - OperatorLifecycleManagerV1 + - Storage + - baremetal + - marketplace + - openshift-samples + conditions: + - lastTransitionTime: "2025-09-09T16:58:30Z" + status: "True" + type: RetrievedUpdates + - lastTransitionTime: "2025-09-09T16:25:36Z" + message: Capabilities match configured spec + reason: AsExpected + status: "False" + type: ImplicitlyEnabledCapabilities + - lastTransitionTime: "2025-09-09T16:25:36Z" + message: Payload loaded version="4.22.0-ec.3" image="quay.io/openshift-release-dev/ocp-release@sha256:58b98da1492b3f4af6129c4684b8e8cde4f2dc197e4b483bb6025971d59f92a5" + architecture="amd64" + reason: PayloadLoaded + status: "True" + type: ReleaseAccepted + - lastTransitionTime: "2025-09-09T16:55:08Z" + message: Done applying 4.22.0-ec.3 + status: "True" + type: Available + - lastTransitionTime: "2025-09-09T16:55:08Z" + status: "False" + type: Failing + - lastTransitionTime: "2025-09-09T16:55:08Z" + message: Cluster version is 4.22.0-ec.3 + status: "False" + type: Progressing + desired: + image: quay.io/openshift-release-dev/ocp-release@sha256:58b98da1492b3f4af6129c4684b8e8cde4f2dc197e4b483bb6025971d59f92a5 + version: 4.22.0-ec.3 + history: + - completionTime: "2025-09-09T16:55:08Z" + image: quay.io/openshift-release-dev/ocp-release@sha256:58b98da1492b3f4af6129c4684b8e8cde4f2dc197e4b483bb6025971d59f92a5 + startedTime: "2025-09-09T16:25:36Z" + state: Completed + verified: false + version: 4.22.0-ec.3 + observedGeneration: 1 + versionHash: XI4117989oE= diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.output b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.output new file mode 100644 index 0000000000..1b9ee06cb6 --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.output @@ -0,0 +1,15 @@ +The following conditions found no cause for concern in updating this cluster to later releases: recommended/NodeAlerts (AsExpected), recommended/PodDisruptionBudgetAlerts (AsExpected), recommended/PodImagePullAlerts (AsExpected), recommended/UpdatePrecheckAlerts (AsExpected) + +The following conditions found cause for concern in updating this cluster to later releases: recommended/CriticalAlerts/VirtHandlerDaemonSetRolloutFailing/0 + +recommended/CriticalAlerts/VirtHandlerDaemonSetRolloutFailing/0=False: + + Reason: Alert:firing + Message: critical alert VirtHandlerDaemonSetRolloutFailing firing, suggesting significant cluster issues worth investigating. Your upstream update recommendation service recommends you update your cluster. The alert description is: For more information refer to 'oc adm upgrade' or https://console-openshift-console.apps.ci-ln-plnvytb-76ef8.aws-2.ci.openshift.org/settings/cluster/. + +Upstream update service: https://amd64.origin.releases.ci.openshift.org/graph +Channel: stable-4.22 + +Updates to 4.22: + VERSION ISSUES + 4.22.0-0.nightly-2026-02-26-092444 no known issues relevant to this cluster diff --git a/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.show-outdated-releases-output b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.show-outdated-releases-output new file mode 100644 index 0000000000..1b9ee06cb6 --- /dev/null +++ b/pkg/cli/admin/upgrade/recommend/examples/4.22.0-extend-recommended-critical-alert.show-outdated-releases-output @@ -0,0 +1,15 @@ +The following conditions found no cause for concern in updating this cluster to later releases: recommended/NodeAlerts (AsExpected), recommended/PodDisruptionBudgetAlerts (AsExpected), recommended/PodImagePullAlerts (AsExpected), recommended/UpdatePrecheckAlerts (AsExpected) + +The following conditions found cause for concern in updating this cluster to later releases: recommended/CriticalAlerts/VirtHandlerDaemonSetRolloutFailing/0 + +recommended/CriticalAlerts/VirtHandlerDaemonSetRolloutFailing/0=False: + + Reason: Alert:firing + Message: critical alert VirtHandlerDaemonSetRolloutFailing firing, suggesting significant cluster issues worth investigating. Your upstream update recommendation service recommends you update your cluster. The alert description is: For more information refer to 'oc adm upgrade' or https://console-openshift-console.apps.ci-ln-plnvytb-76ef8.aws-2.ci.openshift.org/settings/cluster/. + +Upstream update service: https://amd64.origin.releases.ci.openshift.org/graph +Channel: stable-4.22 + +Updates to 4.22: + VERSION ISSUES + 4.22.0-0.nightly-2026-02-26-092444 no known issues relevant to this cluster diff --git a/pkg/cli/admin/upgrade/recommend/examples_test.go b/pkg/cli/admin/upgrade/recommend/examples_test.go index 0129d31aee..61fbdb44b6 100644 --- a/pkg/cli/admin/upgrade/recommend/examples_test.go +++ b/pkg/cli/admin/upgrade/recommend/examples_test.go @@ -80,6 +80,10 @@ func TestExamples(t *testing.T) { var version string if version = variant.versions[cv]; version != "" { variant.outputSuffix = fmt.Sprintf(variant.outputSuffixPattern, version) + } else { + if variant.name == "specific version" { + continue + } } t.Run(fmt.Sprintf("%s-%s", cv, variant.name), func(t *testing.T) { t.Parallel()