-
Notifications
You must be signed in to change notification settings - Fork 5
fix: .versionrc.json postbump references non-existent sync-native-versions.js #823
Copy link
Copy link
Labels
follow-upDeferred work from PR reviews that needs trackingDeferred work from PR reviews that needs tracking
Description
Problem
.versionrc.json has a postbump script that references sync-native-versions.js:
"scripts": {
"postbump": "node scripts/sync-native-versions.js"
}But the file only exists as scripts/sync-native-versions.ts. The .js variant does not exist.
Impact
Currently low impact because the npm version lifecycle hook in package.json correctly runs the .ts version via node-ts.js wrapper:
"version": "node scripts/node-ts.js scripts/sync-native-versions.ts && git add package.json crates/codegraph-core/Cargo.toml"The .versionrc.json postbump is both redundant (npm lifecycle already handles the sync) and broken (references a non-existent .js file). If commit-and-tag-version ever changes execution order or the npm lifecycle hook is removed, the version sync would silently fail.
Fix
Either:
- Remove the
postbumpfrom.versionrc.jsonsince the npmversionlifecycle already handles it, or - Update it to
node scripts/node-ts.js scripts/sync-native-versions.ts
Found during review of #822.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
follow-upDeferred work from PR reviews that needs trackingDeferred work from PR reviews that needs tracking