-
Notifications
You must be signed in to change notification settings - Fork 4
fix(native): lower version gate after Rust incremental purge is complete #866
Copy link
Copy link
Open
Labels
follow-upDeferred work from PR reviews that needs trackingDeferred work from PR reviews that needs tracking
Description
Context
PR #865 fixes several native engine bugs (scoped deletion, barrel resolution, SQL purge order) but the Rust incremental purge still produces doubled node counts when the native orchestrator runs:
incremental-edge-parity: 22 nodes vs expected 11incremental-parity: 6 dataflow edges vs expected 3scoped-rebuild: deleted file nodes not purged (2 vs 0)
The version gate in shouldSkipNativeOrchestrator (pipeline.ts:274) deliberately uses <= 0 to keep 3.9.0 on the JS pipeline.
Action
Once the Rust purge_changed_files correctly removes old nodes before re-insert:
- Change
semverCompare(ctx.engineVersion, '3.9.0') <= 0to< 0(or bump the gate version) - Verify all three test suites pass with the native orchestrator enabled
Related
- PR fix(native): correct incremental purge, scoped deletion, and barrel resolution #865 (initial fixes)
- Greptile review comment on pipeline.ts:274
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
follow-upDeferred work from PR reviews that needs trackingDeferred work from PR reviews that needs tracking